Un-skip storage tests on HyperShift - #83094
Conversation
There is no reason the tests should be skipped and the PR that skips them does not mention why it was done.
WalkthroughThe AWS OVN conformance jobs for HyperShift releases 5.0 and 5.1 now remove storage-related entries from ChangesHyperShift conformance test skips
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse |
|
@jsafrane: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance-techpreview periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aws-ovn-conformance-techpreview |
|
@Nirshal: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Investigation summaryI traced the history of these test skips to understand why they were added and whether removing them is safe. How the skips were introducedThe The 5.1 periodics file was created on August 6 by @deepsm007 via PR #83050 (pre-branching 5.0 -> 5.1), mechanically copying the skips from 5.0. The fix is already in@jsafrane fixed the underlying VolumeGroupSnapshot issue and verified it on June 12 via a rehearsal of PR #80426 (the predecessor of this PR, covering only 5.0). The fix shipped in nightly PR #80426 was the first attempt to remove the skips but only covered 5.0 (since 5.1 didn't exist yet). This PR (#83094) supersedes it by covering both 5.0 and 5.1. No storage skips exist in 4.xI checked all periodics from 4.18 through 4.23 -- none of them have this job or these storage skips. The skips are specific to the 5.0 periodic (and its 5.1 copy). CI failures are unrelatedBoth rehearsal runs (5.0 and 5.1) are currently failing, but the failures are not caused by this change:
These are pre-existing issues with the techpreview conformance job on HyperShift, unrelated to the skip removal. ConclusionThe skips were a temporary workaround for a bug that has been fixed and verified for two months. Safe to merge. |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, jsafrane, Nirshal The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@jsafrane: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
ac00946
into
openshift:main
There is no reason the tests should be skipped and the PR that skips them does not mention why it was done.
There is no reason the tests should be skipped and the PR that skips them does not mention why it was done.
If they flake, please file a bug.
Summary by CodeRabbit