Skip to content

Un-skip storage tests on HyperShift - #83094

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
jsafrane:unskip-storage-hypershift
Aug 10, 2026
Merged

Un-skip storage tests on HyperShift#83094
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
jsafrane:unskip-storage-hypershift

Conversation

@jsafrane

@jsafrane jsafrane commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

There is no reason the tests should be skipped and the PR that skips them does not mention why it was done.
If they flake, please file a bug.

Summary by CodeRabbit

  • Re-enables storage conformance tests for HyperShift AWS OVN TechPreview jobs on OpenShift 5.0 and 5.1.
  • Removes skips for VolumeGroupSnapshot, NFS, and related data-consistency tests.
  • Retains the existing NLB reachability test skips.

There is no reason the tests should be skipped and the PR that skips them
does not mention why it was done.
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The AWS OVN conformance jobs for HyperShift releases 5.0 and 5.1 now remove storage-related entries from TEST_SKIPS. The two NLB reachability exclusions remain.

Changes

HyperShift conformance test skips

Layer / File(s) Summary
Remove storage test exclusions
ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml, ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.1__periodics.yaml
The AWS OVN conformance jobs no longer skip VolumeGroupSnapshot and NFS data-consistency tests. The two NLB exclusions remain.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: enxebre, mgencur, prb112

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only two YAML TEST_SKIPS values and adds no Ginkgo test titles or dynamic test-name content.
Test Structure And Quality ✅ Passed The commit changes only two periodics YAML files and no Ginkgo test source, so the listed Ginkgo quality requirements do not apply.
Microshift Test Compatibility ✅ Passed The pull request changes only YAML TEST_SKIPS entries in two periodic job files; it adds no Ginkgo tests or test references requiring MicroShift compatibility review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The patch changes only two YAML TEST_SKIPS entries; it adds no Ginkgo tests or test-source files requiring SNO compatibility review.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only two CI periodic YAML TEST_SKIPS lists; it adds or modifies no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only two YAML TEST_SKIPS entries; it adds no OTE binary or process-level code that can write to stdout.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only two YAML TEST_SKIPS entries and adds no Ginkgo tests or network code; the IPv6/disconnected compatibility check is not applicable.
No-Weak-Crypto ✅ Passed The pull request changes only two YAML TEST_SKIPS entries. Added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto, or secret-comparison usage.
Container-Privileges ✅ Passed The patch changes only two TEST_SKIPS values. Added lines contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit only removes storage test skips from two YAML TEST_SKIPS values; no logging code or sensitive data was added.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing storage test skips from HyperShift conformance jobs.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jsafrane

jsafrane commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jsafrane: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
openshift-ci Bot requested review from csrwng and enxebre August 7, 2026 10:54
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jsafrane: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aws-ovn-conformance-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance-techpreview N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Nirshal

Nirshal commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

/pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance-techpreview periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aws-ovn-conformance-techpreview

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Nirshal: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aws-ovn-conformance-techpreview 5b207ab link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aws-ovn-conformance-techpreview
ci/rehearse/periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance-techpreview 5b207ab link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Nirshal

Nirshal commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Investigation summary

I traced the history of these test skips to understand why they were added and whether removing them is safe.

How the skips were introduced

The e2e-aws-ovn-conformance-techpreview job did not exist before 5.0 -- it was created from scratch by @mtulio in PR #79439 (SPLAT-2668, merged June 10, 2026). During rehearsal, the VolumeGroupSnapshot and NFS storage tests were failing, so Marco added them to TEST_SKIPS as a workaround and opened OCPBUGS-87252 to track the issue.

The 5.1 periodics file was created on August 6 by @deepsm007 via PR #83050 (pre-branching 5.0 -> 5.1), mechanically copying the skips from 5.0.

The fix is already in

@jsafrane fixed the underlying VolumeGroupSnapshot issue and verified it on June 12 via a rehearsal of PR #80426 (the predecessor of this PR, covering only 5.0). The fix shipped in nightly 5.0.0-0.nightly-2026-06-12-141614. OCPBUGS-87252 is currently in Verified status with fix version 5.0.0.

PR #80426 was the first attempt to remove the skips but only covered 5.0 (since 5.1 didn't exist yet). This PR (#83094) supersedes it by covering both 5.0 and 5.1.

No storage skips exist in 4.x

I checked all periodics from 4.18 through 4.23 -- none of them have this job or these storage skips. The skips are specific to the 5.0 periodic (and its 5.1 copy).

CI failures are unrelated

Both rehearsal runs (5.0 and 5.1) are currently failing, but the failures are not caused by this change:

  • 5.0: 30 blocking failures, all in ClusterAPI Machine Management (ClusterAPIMachineManagement / ClusterAPIMachineManagementAWS), cluster-config-operator, CCO/STS, DRA, Prometheus alerts, and network segmentation. Zero storage-related failures.
  • 5.1: Failed during initialize -- cannot resolve the multi-initial release tag (expected, since the 5.1 branch was created just days ago and likely has no valid nightly payload yet).

These are pre-existing issues with the techpreview conformance job on HyperShift, unrelated to the skip removal.

Conclusion

The skips were a temporary workaround for a bug that has been fixed and verified for two months. Safe to merge.

@Nirshal

Nirshal commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@csrwng

csrwng commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, jsafrane, Nirshal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@jsafrane

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jsafrane: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit ac00946 into openshift:main Aug 10, 2026
14 of 16 checks passed
jzding pushed a commit to jzding/release that referenced this pull request Aug 11, 2026
There is no reason the tests should be skipped and the PR that skips them
does not mention why it was done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants