Fix hypershift-integration sed on openshift/api

[JoelSpeed]

The sed command got messed up in my latest fix

Summary by CodeRabbit

• Fixes the hypershift-integration CI verification for openshift/api.
• Corrects the sed paths for the openshift-api and client-go modules.
• Ensures the test uses valid ../openshift-* paths.

[JoelSpeed]

/pj-rehearse

[openshift-merge-bot]

@JoelSpeed: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7868c85c-686e-44bc-9d5a-de2f46e66ebc

📥 Commits

Reviewing files that changed from the base of the PR and between fba4b51 and e6fb584.

📒 Files selected for processing (1)

• ci-operator/config/openshift/api/openshift-api-master.yaml

---

Walkthrough

The verify-hypershift-integration test now uses valid relative paths for the github.com/openshift/api and github.com/openshift/client-go module replacements.

Changes

Hypershift integration paths

Layer / File(s)	Summary
Correct module replacement paths ci-operator/config/openshift/api/openshift-api-master.yaml	The test replaces malformed module paths with valid ../openshift-* paths for the OpenShift API and client-go modules.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• openshift/release#82983: Both PRs update module replacement paths in the verify-hypershift-integration test.

Suggested labels: lgtm

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the hypershift-integration sed fix in openshift/api, which matches the pull request changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only two sed paths in a YAML CI command; it adds no Ginkgo test titles or dynamic test-name values.
Test Structure And Quality	✅ Passed	The commit changes only YAML sed paths; it adds or modifies no Ginkgo It blocks or cluster operations, so the listed test-quality checks are not applicable.
Microshift Test Compatibility	✅ Passed	The patch changes only two sed paths in a YAML CI script; it adds no Ginkgo e2e tests or MicroShift-incompatible API and feature references.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only two sed paths in a YAML CI configuration; it adds no Ginkgo e2e tests or multi-node/HA assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The change only corrects two sed paths in a CI integration test; it adds no manifests, operator code, controllers, replicas, affinity, node selectors, or other scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only two sed paths in a YAML configuration; it adds no OTE binary or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The patch changes only two sed paths in a YAML CI command; it adds no Ginkgo e2e tests and introduces no IPv4 or external-connectivity assumptions.
No-Weak-Crypto	✅ Passed	The PR changes only two sed replacement paths in the YAML configuration. The diff contains no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, or crypto implementation.
Container-Privileges	✅ Passed	The commit changes only two sed paths. The changed CI YAML contains no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The patch only corrects two static sed paths. The affected test has no password, token, API key, PII, or environment-dump logging; its echo lines contain only module paths.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@JoelSpeed: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-api-master-verify-hypershift-integration	openshift/api	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[JoelSpeed]

/testwith openshift/api/master/verify-hypershift-integration openshift/api#2971

[JoelSpeed]

/pj-rehearse ack

I can see from the rehearsal we got past the "sed" point of the script this time

[openshift-merge-bot]

@JoelSpeed: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[everettraven]

The failure in the rehearsal run still looks like something that would cause a permafailure to me:

/go/src/github.com/openshift/hypershift/hack/tools/bin/controller-gen "crd" paths="./vendor/github.com/openshift/cluster-api-provider-agent/api/..." output:crd:artifacts:config=cmd/install/assets/crds/cluster-api-provider-agent
v1beta1/zz_conversion.go:7:2: cannot find module providing package github.com/openshift/api/config/v1: import lookup disabled by -mod=vendor
Error: not all generators ran successfully
run `controller-gen crd paths=./vendor/github.com/openshift/cluster-api-provider-agent/api/... output:crd:artifacts:config=cmd/install/assets/crds/cluster-api-provider-agent -w` to see all available markers, or `controller-gen crd paths=./vendor/github.com/openshift/cluster-api-provider-agent/api/... output:crd:artifacts:config=cmd/install/assets/crds/cluster-api-provider-agent -h` for usage

Is this something we can fix here as well?

[patrickdillon]

/lgtm

[patrickdillon]

/lgtm cancel

[patrickdillon]

/hold

[patrickdillon]

Sorry, added lgtm before seeing bryce's comment, but I caught it in time

feel free to remove the hold

[JoelSpeed]

I think that's because the rehearsal checks out the release repo, and not the API repo. So it's copying the release repo in place of o/api, and since release doesn't have a config/v1 path, this errors out.

I don't think these kinds of tests are actually rehearesable properly from my previous experience

[patrickdillon]

/hold cancel
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/api/OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.