Skip to content

CMP-3881: Change job names from config to scan-config#80918

Open
taimurhafeez wants to merge 1 commit into
openshift:mainfrom
taimurhafeez:CMP-3881-change-config-to-scan-config
Open

CMP-3881: Change job names from config to scan-config#80918
taimurhafeez wants to merge 1 commit into
openshift:mainfrom
taimurhafeez:CMP-3881-change-config-to-scan-config

Conversation

@taimurhafeez

@taimurhafeez taimurhafeez commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Previously, jobs were added for new suites and one of those was config. However, in PR where suite is being added, suite name has been modified from config to scan-config.
This PR modifies jobs names to reflect the change accordingly.

Summary by CodeRabbit

This PR updates CI job configuration for the ComplianceAsCode compliance-operator repository to align with recent naming changes in the compliance-operator codebase.

Practical Impact:
The e2e test job for the compliance-operator's AWS environment has been renamed from e2e-aws-config to e2e-aws-scan-config, with the corresponding make target updated from make e2e-config to make e2e-scan-config. This change ensures the OpenShift CI system invokes the correct test target that matches the compliance-operator's updated suite naming convention (from config to scan-config).

Configuration Updated:

  • File: ci-operator/config/ComplianceAsCode/compliance-operator/ComplianceAsCode-compliance-operator-master.yaml
  • Job name change: e2e-aws-confige2e-aws-scan-config
  • Make target change: make e2e-configmake e2e-scan-config

This is a coordination between two repositories where the release repository's CI job definitions now properly reference the compliance-operator's current test suite naming.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 23, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@taimurhafeez: This pull request references CMP-3881 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Previously, jobs were added for new suites and one of those was config. However, in PR where suite is being added, suite name has been modified from config to scan-config.
This PR modifies jobs to reflect the change accordingly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

In the compliance-operator master CI config, the job step previously named e2e-aws-config is renamed to e2e-aws-scan-config, and its make invocation is updated from make e2e-config to make e2e-scan-config.

Changes

CI Job Rename

Layer / File(s) Summary
Job key and make target rename
ci-operator/config/ComplianceAsCode/compliance-operator/ComplianceAsCode-compliance-operator-master.yaml
Job step key renamed from e2e-aws-config to e2e-aws-scan-config; make target updated from make e2e-config to make e2e-scan-config.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: renaming job names from 'config' to 'scan-config', which directly corresponds to the actual changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies CI job configuration only, contains no Ginkgo test code. Custom check for "Stable and Deterministic Test Names" is inapplicable to CI YAML configuration files.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test code quality is not applicable to this PR, which only modifies CI/CD YAML configuration files. No test code changes are present.
Microshift Test Compatibility ✅ Passed This PR only modifies CI job configuration YAML files in openshift/release repo; it does not add new Ginkgo e2e tests, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies CI job configuration (renaming e2e-aws-config to e2e-aws-scan-config), not Ginkgo test code, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies CI job configuration (test name and make target), not deployment manifests or operator code; no scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed This PR only modifies CI configuration YAML (job names and Makefile target references), not OTE binary source code. The OTE Binary Stdout Contract check applies to executable code, not CI configura...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates CI job configuration names in YAML; no new Ginkgo e2e tests are added, so IPv6/disconnected network compatibility check is not applicable.
No-Weak-Crypto ✅ Passed PR modifies only CI job configuration names in a YAML file. No cryptographic code, weak crypto patterns (MD5, SHA1, DES, RC4, etc.), or secret comparisons detected.
Container-Privileges ✅ Passed The PR modifies a CI configuration file that contains no container privilege escalation indicators (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root-as-user s...
No-Sensitive-Data-In-Logs ✅ Passed The PR modifies a CI configuration file with only job and make command name changes. No logging statements, passwords, tokens, API keys, PII, session IDs, or sensitive data are present or added.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2026
@openshift-ci openshift-ci Bot requested review from rhmdnd and yuumasato June 23, 2026 12:42
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@taimurhafeez: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-ComplianceAsCode-compliance-operator-master-e2e-aws-scan-config ComplianceAsCode/compliance-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@taimurhafeez: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yuumasato yuumasato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2026
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: taimurhafeez, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants