NO-ISSUE: Add promoted component images for Netris CI by danmanor · Pull Request #80915 · openshift/release

danmanor · 2026-06-23T12:18:07Z

Summary

Adds container and code images to OSAC component CI configs that will be promoted to the osac-project/latest imagestream. These are prerequisites for the Netris CI workflow (PR #80852) which imports them as base_images when testing other components.

Changes

Repo	New Image	Type	Purpose
osac-operator	`osac-operator-code`	`FROM src`	Source code for installer submodule overlay
fulfillment-service	`fulfillment-service`	`Containerfile`	Service container (promoted, importable by other repos)
fulfillment-service	`fulfillment-service-code`	`FROM src`	Source code for installer submodule overlay
osac-aap	`osac-aap-ee`	EE dockerfile	Ansible execution environment (promoted, importable by other repos)

No tests or dependencies are changed. Existing -pr images and e2e-vmaas tests are untouched.

All images verified locally with podman build.

Test plan

make update passes (validated locally)
All 4 new images build successfully (verified locally with podman)
Verify images are promoted to osac-project/latest after merge

🤖 Generated with Claude Code

Summary by CodeRabbit

This pull request updates OSAC component CI image build/promote configuration (ci-operator) so Netris cross-repository tests can consume the newly produced “base images” from the osac-project/latest imagestream.

Changes made:

osac-operator
- Added a new source-style image target osac-operator-code (FROM src).
- Kept the promoted operator test image as osac-operator by wiring e2e-vmaas COMPONENT_IMAGE to osac-operator.
- Promotion only excludes osac-installer-with-pr from being promoted.
fulfillment-service
- Ensures the container image target is fulfillment-service (built from Containerfile).
- Added fulfillment-service-code as a source-style image (FROM src, copies osac/ into /app/osac) for installer submodule overlay workflows.
- Wired e2e-vmaas COMPONENT_IMAGE to fulfillment-service.
- Promotion only excludes osac-installer-with-pr from being promoted.
osac-aap
- Added osac-aap-ee as the execution-environment image (CentOS Stream 9 based; installs Python 3.12 deps, Ansible collections/vendor, and oc with a kubectl symlink).
- Wired e2e-vmaas COMPONENT_IMAGE to osac-aap-ee (while keeping COMPONENT_IMAGE_NAME: osac-aap).
- Promotion only excludes osac-installer-with-pr from being promoted.

All changes are limited to CI image configuration/promotion and the e2e-vmaas component image wiring for these OSAC pipelines (no other tests or -pr/e2e-vmaas test logic are modified). The author reports local verification via podman build and that make update passes before merge.

coderabbitai · 2026-06-23T12:18:41Z

Walkthrough

Three OSAC component CI configurations are updated to add new image build entries and adjust image target naming for promotion workflows. Fulfillment-service adds explicit image targets including a code image, osac-aap redirects its build output target, and osac-operator adds a new code image. All three configurations remove old targets from promotion exclusion lists and update test environment variables to reference the new targets.

Changes

OSAC Component Image Configuration Updates

Layer / File(s)	Summary
fulfillment-service image builds and promotion `ci-operator/config/osac-project/fulfillment-service/osac-project-fulfillment-service-main.yaml`	Adds `fulfillment-service` Containerfile-based output target (renamed from `fulfillment-service-pr`) and new `fulfillment-service-code` image built from src stage. Removes `fulfillment-service-pr` from promotion exclusion list and updates test `COMPONENT_IMAGE` to `fulfillment-service`.
osac-aap image build target and test wiring `ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml`	Changes CentOS Stream 9 `dockerfile_literal` output target from `osac-aap-pr` to `osac-aap-ee` while retaining build content. Updates promotion exclusion list to exclude `osac-aap-ee` instead of `osac-aap-pr`. Wires test `COMPONENT_IMAGE` environment variable to `osac-aap-ee`.
osac-operator code image and promotion `ci-operator/config/osac-project/osac-operator/osac-project-osac-operator-main.yaml`	Adds new `osac-operator-code` image target built from src stage. Removes `osac-operator-pr` from promotion exclusion list. Updates test `COMPONENT_IMAGE` to reference `osac-operator`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

openshift/release#80807: Defines helm-based cluster-tool boot flow that overrides component image references via Helm values YAML, directly tied to these image target renaming changes.

Suggested labels

rehearsals-ack

Suggested reviewers

rgolangh
eranco74

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only YAML CI configuration files, not Ginkgo test code. The check for stable test names is not applicable as there are no test files with Ginkgo constructs being modified.
Test Structure And Quality	✅ Passed	This PR contains only CI configuration YAML files, not Ginkgo test code. The check is not applicable to this pull request as it targets test code quality, which is not present in these changes.
Microshift Test Compatibility	✅ Passed	PR modifies only CI configuration YAML files to add container/code images. No new Ginkgo e2e tests are added, so MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR adds only CI configuration changes (YAML files), not new Ginkgo e2e tests. Check for SNO test compatibility does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR modifies CI/CD pipeline configurations, not deployment manifests, operator code, or controllers. No Kubernetes resources with scheduling constraints are present.
Ote Binary Stdout Contract	✅ Passed	PR only modifies CI configuration YAML files defining container image builds. No Go test code, main() functions, or process-level code is added, so OTE stdout contract violations are not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. The changes are exclusively CI configuration modifications in YAML files that add new container/code images. The check does not apply.
No-Weak-Crypto	✅ Passed	The three changed YAML files (fulfillment-service, osac-aap, osac-operator CI configs) contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB usage; no custom crypto implementations; and no non-consta...
Container-Privileges	✅ Passed	No privileged container settings (privileged: true, hostPID/Network/IPC, SYS_ADMIN, allowPrivilegeEscalation, or root user) detected in the three CI configuration files modified by this PR.
No-Sensitive-Data-In-Logs	✅ Passed	The PR modifies CI configuration files to add container and code images. No logging statements, passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data are exposed in th...
Title check	✅ Passed	The title accurately describes the main change: adding promoted component images for OSAC (specifically fulfillment-service, osac-operator, and osac-aap images) to support the Netris CI workflow.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

danmanor · 2026-06-23T14:42:51Z

/pj-rehearse pull-ci-osac-project-fulfillment-service-main-images pull-ci-osac-project-osac-operator-main-images pull-ci-osac-project-osac-aap-main-images

openshift-merge-bot · 2026-06-23T14:42:54Z

@danmanor: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Add container and code images that will be promoted to the osac-project/latest imagestream for cross-repo import: - osac-operator: add osac-operator-code (source image) - fulfillment-service: add fulfillment-service (container image), fulfillment-service-code (source image) - osac-aap: add osac-aap-ee (execution environment image) These images are prerequisites for the Netris CI workflow which imports them as base_images when testing other components. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

openshift-merge-bot · 2026-06-23T15:02:28Z

[REHEARSALNOTIFIER]
@danmanor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-osac-project-fulfillment-service-main-e2e-vmaas	osac-project/fulfillment-service	presubmit	Ci-operator config changed
pull-ci-osac-project-fulfillment-service-main-images	osac-project/fulfillment-service	presubmit	Ci-operator config changed
pull-ci-osac-project-fulfillment-service-main-unit	osac-project/fulfillment-service	presubmit	Ci-operator config changed
pull-ci-osac-project-osac-aap-main-e2e-vmaas	osac-project/osac-aap	presubmit	Ci-operator config changed
pull-ci-osac-project-osac-aap-main-images	osac-project/osac-aap	presubmit	Ci-operator config changed
pull-ci-osac-project-osac-operator-main-e2e-vmaas	osac-project/osac-operator	presubmit	Ci-operator config changed
pull-ci-osac-project-osac-operator-main-images	osac-project/osac-operator	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

danmanor · 2026-06-23T15:23:25Z

/pj-rehearse pull-ci-osac-project-fulfillment-service-main-images pull-ci-osac-project-osac-operator-main-images pull-ci-osac-project-osac-aap-main-images

openshift-merge-bot · 2026-06-23T15:23:28Z

@danmanor: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

danmanor · 2026-06-23T15:24:08Z

/pj-rehearse pull-ci-osac-project-fulfillment-service-main-e2e-vmaas

openshift-merge-bot · 2026-06-23T15:24:11Z

@danmanor: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci-robot · 2026-06-23T15:38:05Z

@danmanor: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Adds container and code images to OSAC component CI configs that will be promoted to the osac-project/latest imagestream. These are prerequisites for the Netris CI workflow (PR #80852) which imports them as base_images when testing other components.

Changes

Repo New Image Type Purpose

osac-operator osac-operator-code FROM src Source code for installer submodule overlay

fulfillment-service fulfillment-service Containerfile Service container (promoted, importable by other repos)

fulfillment-service fulfillment-service-code FROM src Source code for installer submodule overlay

osac-aap osac-aap-ee EE dockerfile Ansible execution environment (promoted, importable by other repos)

No tests or dependencies are changed. Existing -pr images and e2e-vmaas tests are untouched.

All images verified locally with podman build.

Test plan

make update passes (validated locally)

All 4 new images build successfully (verified locally with podman)

Verify images are promoted to osac-project/latest after merge

🤖 Generated with Claude Code

Summary by CodeRabbit

This pull request updates OSAC component CI image build/promote configuration (ci-operator) so Netris cross-repository tests can consume the newly produced “base images” from the osac-project/latest imagestream.

Changes made:

osac-operator

Added a new source-style image target osac-operator-code (FROM src).

Kept the promoted operator test image as osac-operator by wiring e2e-vmaas COMPONENT_IMAGE to osac-operator.

Promotion only excludes osac-installer-with-pr from being promoted.

fulfillment-service

Ensures the container image target is fulfillment-service (built from Containerfile).

Added fulfillment-service-code as a source-style image (FROM src, copies osac/ into /app/osac) for installer submodule overlay workflows.

Wired e2e-vmaas COMPONENT_IMAGE to fulfillment-service.

Promotion only excludes osac-installer-with-pr from being promoted.

osac-aap

Added osac-aap-ee as the execution-environment image (CentOS Stream 9 based; installs Python 3.12 deps, Ansible collections/vendor, and oc with a kubectl symlink).

Wired e2e-vmaas COMPONENT_IMAGE to osac-aap-ee (while keeping COMPONENT_IMAGE_NAME: osac-aap).

Promotion only excludes osac-installer-with-pr from being promoted.

All changes are limited to CI image configuration/promotion and the e2e-vmaas component image wiring for these OSAC pipelines (no other tests or -pr/e2e-vmaas test logic are modified). The author reports local verification via podman build and that make update passes before merge.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

danmanor · 2026-06-23T15:46:04Z

/pj-rehearse pull-ci-osac-project-fulfillment-service-main-e2e-vmaas

openshift-merge-bot · 2026-06-23T15:46:06Z

@danmanor: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

danmanor · 2026-06-23T15:46:15Z

/hold

omer-vishlitzky · 2026-06-23T15:55:00Z

/lgtm
/approve

openshift-ci · 2026-06-23T15:56:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, omer-vishlitzky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/osac-project/fulfillment-service/OWNERS~~ [omer-vishlitzky]
~~ci-operator/config/osac-project/osac-aap/OWNERS~~ [danmanor]
~~ci-operator/config/osac-project/osac-operator/OWNERS~~ [danmanor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-06-23T18:06:00Z

@danmanor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/osac-project/fulfillment-service/main/e2e-vmaas	`34f246b`	link	unknown	`/pj-rehearse pull-ci-osac-project-fulfillment-service-main-e2e-vmaas`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot requested review from eranco74 and rgolangh June 23, 2026 12:19

danmanor force-pushed the osac-promote-component-images branch from f0b60c9 to e1c7fbf Compare June 23, 2026 14:27

danmanor force-pushed the osac-promote-component-images branch from e1c7fbf to 34f246b Compare June 23, 2026 14:59

danmanor changed the title ~~OSAC: Add promoted component images for Netris CI~~ NO-ISSUE: Add promoted component images for Netris CI Jun 23, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 23, 2026

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2026

openshift-ci Bot assigned omer-vishlitzky Jun 23, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2026

Conversation

danmanor commented Jun 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

danmanor commented Jun 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 23, 2026

Uh oh!

danmanor commented Jun 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 23, 2026

Uh oh!

danmanor commented Jun 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 23, 2026

Uh oh!

openshift-ci-robot commented Jun 23, 2026

Summary

Changes

Test plan

Summary by CodeRabbit

Uh oh!

danmanor commented Jun 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 23, 2026

Uh oh!

danmanor commented Jun 23, 2026

Uh oh!

omer-vishlitzky commented Jun 23, 2026

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

danmanor commented Jun 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading