Skip to content

Add CI tests for ConfigurablePKI installer feature#77043

Open
hasbro17 wants to merge 1 commit intoopenshift:mainfrom
hasbro17:configurable-pki-ci-test
Open

Add CI tests for ConfigurablePKI installer feature#77043
hasbro17 wants to merge 1 commit intoopenshift:mainfrom
hasbro17:configurable-pki-ci-test

Conversation

@hasbro17
Copy link
Copy Markdown
Contributor

This provides the presubmits for the installer support of the PKI config openshift/installer#10396

Summary

  • Adds step-registry components and CI jobs to validate the ConfigurablePKI feature gate, which changes installer-generated signer certificates from RSA-2048 to ECDSA P-384 by default when enabled
  • Two test scenarios: default behavior (ECDSA P-384 signers) and explicit RSA-4096 override, each as an optional presubmit and a 72h periodic
  • Verification step checks 7 signer CA secrets post-install and validates the PKI custom resource

New step-registry components

openshift-installer-pki-conf (ref) — Adds pki section to install-config.yaml via yq. No-op when PKI_ALGORITHM is unset, allowing the default behavior test.

openshift-installer-pki-verify (ref) — Verifies signer cert algorithms/key params and PKI CR post-install. Outputs a pass/fail summary table to stdout and writes full certificate details to the artifact
directory.

openshift-installer-pki-ipi-conf (chain) — Wraps ipi-confopenshift-installer-pki-conf to ensure correct ordering.

New CI jobs (openshift/installer, main branch)

Optional presubmits:

  • e2e-aws-ovn-pki-default — Feature gate ON, no explicit config → expects ECDSA P-384 signers
  • e2e-aws-ovn-pki-rsa — Feature gate ON, explicit RSA-4096 → expects RSA-4096 signers

Periodics (72h):

  • periodic-e2e-aws-ovn-pki-default — Same as default presubmit
  • periodic-e2e-aws-ovn-pki-rsa — Same as RSA presubmit

All jobs use CustomNoUpgrade with ConfigurablePKI=true, run PKI verification before the full e2e suite (fail fast), and target AWS IPI.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2026
@openshift-ci openshift-ci bot requested review from rwsu and sadasu March 30, 2026 06:13
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hasbro17
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hasbro17
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@hasbro17: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hasbro17
Copy link
Copy Markdown
Contributor Author

The rehearsals will of course fail until the installer support for PKI is actually merged from openshift/installer#10396

The goal is to merge this first and then run the presubmits on the installer PR to validate the PKI featuregate workflow.

@hasbro17 hasbro17 force-pushed the configurable-pki-ci-test branch from 1c7d82c to ada480e Compare March 30, 2026 18:56
@hasbro17
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@hasbro17: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Add step-registry components and CI jobs to validate the ConfigurablePKI
feature gate for the OpenShift installer. When enabled with
CustomNoUpgrade, signer certificates default to ECDSA P-384.

New step-registry components:
- openshift-installer-pki-conf: adds pki section to install-config.yaml
- openshift-installer-pki-verify: verifies signer cert algorithms and
  PKI CR post-install
- openshift-installer-pki-ipi-conf: chain wrapping ipi-conf + pki-conf

New CI jobs (openshift/installer, main branch):
- e2e-aws-ovn-pki-default: optional presubmit, verifies default ECDSA
  P-384 signer certs when feature gate is enabled without explicit config
- e2e-aws-ovn-pki-rsa: optional presubmit, verifies explicit RSA-4096
  override for signer certs
- periodic-e2e-aws-ovn-pki-default: periodic (72h) for default behavior
- periodic-e2e-aws-ovn-pki-rsa: periodic (72h) for RSA override

Assisted-by: Claude Code (Opus 4.6)
@hasbro17
Copy link
Copy Markdown
Contributor Author

Alright, the pki cert and CR verification test seems to be checking everything correctly now:

Logs for container test in pod e2e-aws-ovn-pki-rsa-openshift-installer-pki-verify: 
�[36mINFO�[0m[2026-03-30T21:54:35Z] =============================================
PKI Verification
Expected algorithm: RSA
Expected key param: 4096
=============================================

--- Checking: root-ca (openshift-machine-config-operator/machine-config-server-ca) ---
  Algorithm: rsaEncryption - OK
  FAIL: Expected 'Public-Key: (4096 bit)', got 'Public-Key: (2048 bit)'
--- Checking: kube-apiserver-to-kubelet-signer (openshift-kube-apiserver-operator/kube-apiserver-to-kubelet-signer) ---
  Algorithm: rsaEncryption - OK
  FAIL: Expected 'Public-Key: (4096 bit)', got 'Public-Key: (2048 bit)'
--- Checking: kube-apiserver-localhost-signer (openshift-kube-apiserver-operator/localhost-serving-signer) ---
  Algorithm: rsaEncryption - OK
  FAIL: Expected 'Public-Key: (4096 bit)', got 'Public-Key: (2048 bit)'
--- Checking: kube-apiserver-service-network-signer (openshift-kube-apiserver-operator/service-network-serving-signer) ---
  Algorithm: rsaEncryption - OK
  FAIL: Expected 'Public-Key: (4096 bit)', got 'Public-Key: (2048 bit)'
--- Checking: kube-apiserver-lb-signer (openshift-kube-apiserver-operator/loadbalancer-serving-signer) ---
  Algorithm: rsaEncryption - OK
  FAIL: Expected 'Public-Key: (4096 bit)', got 'Public-Key: (2048 bit)'
--- Checking: kube-control-plane-signer (openshift-kube-apiserver-operator/kube-control-plane-signer) ---
  Algorithm: rsaEncryption - OK
  FAIL: Expected 'Public-Key: (4096 bit)', got 'Public-Key: (2048 bit)'
--- Checking: aggregator-signer (openshift-kube-apiserver-operator/aggregator-client-signer) ---
  Algorithm: rsaEncryption - OK
  FAIL: Expected 'Public-Key: (4096 bit)', got 'Public-Key: (2048 bit)'

--- Checking PKI CR ---
  FAIL: PKI CR 'cluster' not found or error retrieving it

@hasbro17 hasbro17 force-pushed the configurable-pki-ci-test branch from ada480e to a04896f Compare March 31, 2026 05:36
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@hasbro17: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-main-e2e-aws-ovn-pki-default openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-main-e2e-aws-ovn-pki-rsa openshift/installer presubmit Presubmit changed
periodic-ci-openshift-installer-main-periodic-e2e-aws-ovn-pki-rsa N/A periodic Periodic changed
periodic-ci-openshift-installer-main-periodic-e2e-aws-ovn-pki-default N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

@hasbro17: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/main/e2e-aws-ovn-pki-default ada480e link unknown /pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-pki-default
ci/rehearse/periodic-ci-openshift-installer-main-periodic-e2e-aws-ovn-pki-rsa ada480e link unknown /pj-rehearse periodic-ci-openshift-installer-main-periodic-e2e-aws-ovn-pki-rsa
ci/rehearse/periodic-ci-openshift-installer-main-periodic-e2e-aws-ovn-pki-default ada480e link unknown /pj-rehearse periodic-ci-openshift-installer-main-periodic-e2e-aws-ovn-pki-default
ci/rehearse/openshift/installer/main/e2e-aws-ovn-pki-rsa ada480e link unknown /pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-pki-rsa

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hasbro17 hasbro17 changed the title WIP: Add CI tests for ConfigurablePKI installer feature Add CI tests for ConfigurablePKI installer feature Mar 31, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants