Skip to content

OCPBUGS-105768: Update s2i_images test for OCP samples sync - #31504

Open
aroyoredhat wants to merge 1 commit into
openshift:mainfrom
aroyoredhat:update-s2i-images-for-ocp-samples-sync
Open

OCPBUGS-105768: Update s2i_images test for OCP samples sync#31504
aroyoredhat wants to merge 1 commit into
openshift:mainfrom
aroyoredhat:update-s2i-images-for-ocp-samples-sync

Conversation

@aroyoredhat

@aroyoredhat aroyoredhat commented Aug 11, 2026

Copy link
Copy Markdown

Summary

  • nodejs: Replace 20-ubi822-ubi8 and 20-ubi922-ubi9 (Node.js 20 tags removed from ImageStreams)
  • python: Remove 3.11-ubi8 and 3.11-ubi9 entries (tags removed from ImageStreams), enable 3.12-ubi9 (already available)

These image tags are being removed from the cluster-samples-operator ImageStreams in openshift/cluster-samples-operator#695. Without this update, the e2e-aws-ovn-image-ecosystem tests fail with image pull errors for the removed tags.

Test plan

Made with Cursor

Summary by CodeRabbit

  • Updates
    • Updated the S2I image catalog to support Python 3.12 on UBI9.
    • Removed Python 3.11 image entries for UBI8 and UBI9.
    • Replaced Node.js 20 image entries with Node.js 22 for UBI8 and UBI9.
    • Retained the existing Node.js 22 UBI10 entry.

Replace removed image tags with their available equivalents:
- nodejs: 20-ubi8 -> 22-ubi8, 20-ubi9 -> 22-ubi9
- python: remove 3.11-ubi8 and 3.11-ubi9, enable 3.12-ubi9

These tags are being removed from the cluster-samples-operator
ImageStreams in openshift/cluster-samples-operator#695.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Walkthrough

The S2I image catalog updates supported Python and Node.js versions for UBI8 and UBI9 entries. It removes Python 3.11 entries, enables Python 3.12 on UBI9, and updates Node.js 20 entries to Node.js 22.

Changes

S2I image catalog

Layer / File(s) Summary
Update catalog image versions
test/extended/image_ecosystem/s2i_images.go
The catalog removes Python 3.11 UBI8 and UBI9 entries, enables Python 3.12 on UBI9, and changes Node.js UBI8 and UBI9 entries from version 20 to version 22 with updated expected output and tags.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only static S2I catalog entries; the changed file contains no Ginkgo declarations or runtime-generated test-title values.
Test Structure And Quality ✅ Passed The PR changes only S2I image fixture entries; it adds no Ginkgo It blocks, setup/cleanup, waits, or assertions to review for these requirements.
Microshift Test Compatibility ✅ Passed The commit changes only s2i_images.go data entries; it adds no Ginkgo e2e tests or new OpenShift API references requiring MicroShift compatibility review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The commit only updates S2I image metadata in s2i_images.go; it adds no Ginkgo tests or multi-node/HA assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only S2I image-tag test data in s2i_images.go; it adds no manifests, controllers, workloads, replicas, affinities, selectors, tolerations, or other scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only S2I tag data; the changed file has no stdout or logging calls, and the OTE entrypoint writes diagnostics to os.Stderr while initializing logs.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only s2i_images.go data entries; it adds no Ginkgo It, Describe, Context, or When tests and introduces no networking or external connectivity assumptions.
No-Weak-Crypto ✅ Passed The commit only updates S2I image tags and versions; added lines contain no weak-crypto terms, crypto imports, or custom secret comparisons.
Container-Privileges ✅ Passed The commit changes only image-test Go data. It adds no container or Kubernetes manifest and no privilege-related fields or root execution settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit changes only static Python/Node image metadata; added lines contain no logging calls or sensitive-data fields, and no credential-bearing values are introduced.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the update to the s2i_images test and its purpose of synchronizing with OCP samples changes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from rhdmalone and shannon August 11, 2026 14:36
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2026
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 11, 2026
@rhdmalone

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2026
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aroyoredhat, rhdmalone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-ovn-image-ecosystem

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@aroyoredhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aroyoredhat aroyoredhat changed the title Update s2i_images test for OCP samples sync OCPBUGS-105768: Update s2i_images test for OCP samples sync Aug 11, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 11, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@aroyoredhat: This pull request references Jira Issue OCPBUGS-105768, which is invalid:

  • expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • nodejs: Replace 20-ubi822-ubi8 and 20-ubi922-ubi9 (Node.js 20 tags removed from ImageStreams)
  • python: Remove 3.11-ubi8 and 3.11-ubi9 entries (tags removed from ImageStreams), enable 3.12-ubi9 (already available)

These image tags are being removed from the cluster-samples-operator ImageStreams in openshift/cluster-samples-operator#695. Without this update, the e2e-aws-ovn-image-ecosystem tests fail with image pull errors for the removed tags.

Test plan

Made with Cursor

Summary by CodeRabbit

  • Updates
  • Updated the S2I image catalog to support Python 3.12 on UBI9.
  • Removed Python 3.11 image entries for UBI8 and UBI9.
  • Replaced Node.js 20 image entries with Node.js 22 for UBI8 and UBI9.
  • Retained the existing Node.js 22 UBI10 entry.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aroyoredhat

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@aroyoredhat: This pull request references Jira Issue OCPBUGS-105768, which is invalid:

  • expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aroyoredhat

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 11, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@aroyoredhat: This pull request references Jira Issue OCPBUGS-105768, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants