OCPBUGS-105606: Allow DualReplica stable-system CVO Available blips from NoExecuteTaintManager - #31501
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@eggfoobar: This pull request references Jira Issue OCPBUGS-105606, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe stable operator state transition test detects DualReplica topology and permits specific transient ChangesOperator transition handling
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@eggfoobar: This pull request references Jira Issue OCPBUGS-105606, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eggfoobar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go`:
- Around line 90-97: Update the csi-snapshot-controller exception comment and
returned message in the isTwoNode branch to describe both DualReplica and
HighlyAvailableArbiterMode, or use the generic “two-node topology” wording. Keep
the existing condition matching and exception behavior unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 716ea3a2-b3de-4880-8dad-975b9d716178
📒 Files selected for processing (1)
pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go
| // DualReplica / TNF: serial NoExecuteTaintManager tests NoExecute-taint a control-plane | ||
| // node (masters are also workers), so Deployments briefly cannot schedule. | ||
| if isTwoNode { | ||
| switch operator { | ||
| case "csi-snapshot-controller": | ||
| if strings.Contains(condition.Message, `Waiting for Deployment`) { | ||
| return "csi-snapshot-controller may report Available=False while Waiting for Deployment during DualReplica disruptive serial tests (e.g. NoExecuteTaintManager)" | ||
| } |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Make the exception message match both topology modes.
Line 51 also enables this branch for configv1.HighlyAvailableArbiterMode, but the comment and the return text mention only DualReplica. An accepted HighlyAvailableArbiter condition will report the wrong topology. Use “two-node topology” or name both modes.
Suggested wording
- // DualReplica / TNF: serial NoExecuteTaintManager tests NoExecute-taint a control-plane
+ // Two-node topology: serial NoExecuteTaintManager tests NoExecute-taint a control-plane
...
- return "csi-snapshot-controller may report Available=False while Waiting for Deployment during DualReplica disruptive serial tests (e.g. NoExecuteTaintManager)"
+ return "csi-snapshot-controller may report Available=False while Waiting for Deployment during two-node disruptive serial tests (e.g. NoExecuteTaintManager)"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // DualReplica / TNF: serial NoExecuteTaintManager tests NoExecute-taint a control-plane | |
| // node (masters are also workers), so Deployments briefly cannot schedule. | |
| if isTwoNode { | |
| switch operator { | |
| case "csi-snapshot-controller": | |
| if strings.Contains(condition.Message, `Waiting for Deployment`) { | |
| return "csi-snapshot-controller may report Available=False while Waiting for Deployment during DualReplica disruptive serial tests (e.g. NoExecuteTaintManager)" | |
| } | |
| // Two-node topology: serial NoExecuteTaintManager tests NoExecute-taint a control-plane | |
| // node (masters are also workers), so Deployments briefly cannot schedule. | |
| if isTwoNode { | |
| switch operator { | |
| case "csi-snapshot-controller": | |
| if strings.Contains(condition.Message, `Waiting for Deployment`) { | |
| return "csi-snapshot-controller may report Available=False while Waiting for Deployment during two-node disruptive serial tests (e.g. NoExecuteTaintManager)" | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go`
around lines 90 - 97, Update the csi-snapshot-controller exception comment and
returned message in the isTwoNode branch to describe both DualReplica and
HighlyAvailableArbiterMode, or use the generic “two-node topology” wording. Keep
the existing condition matching and exception behavior unchanged.
Source: Coding guidelines
…ntManager Serial NoExecuteTaintManager tests taint a control-plane node on DualReplica (masters are also workers), briefly driving csi-snapshot-controller and packageserver Available=False. Mirror the existing upgrade-path exceptions in the stable-system monitor so TNF serial jobs do not fail on these expected blips. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: ehila <ehila@redhat.com>
f4a867c to
64bb99a
Compare
|
Scheduling required tests: |
|
@eggfoobar: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Serial NoExecuteTaintManager tests taint a control-plane node on DualReplica (masters are also workers), briefly driving csi-snapshot-controller and packageserver Available=False. Mirror the existing upgrade-path exceptions in the stable-system monitor so TNF serial jobs do not fail on these expected blips.
Summary by CodeRabbit