OCPBUGS-105466: monitortests: recognize PascalCase TNF JobRunning CO reasons

[eggfoobar]

CEO OCPBUGS-84695 renamed TNF job condition types to PascalCase, so etcd Available blips now report TNFSetupJob_JobRunning instead of tnf-setup-job_JobRunning. Accept both shapes in the DualReplica exception.

Summary by CodeRabbit

• Bug Fixes
  • Improved recognition of TNF job status reasons across legacy and newer naming formats.
  • Ensured only reasons ending with _JobRunning are treated as active job statuses.
• Tests
  • Added coverage for uppercase, concatenated, and completed TNF job reason variants.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@eggfoobar: This pull request references Jira Issue OCPBUGS-105466, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

CEO OCPBUGS-84695 renamed TNF job condition types to PascalCase, so etcd Available blips now report TNFSetupJob_JobRunning instead of tnf-setup-job_JobRunning. Accept both shapes in the DualReplica exception.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eggfoobar]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-upgrade

[coderabbitai]

Walkthrough

The TNF job reason matcher now accepts legacy and uppercase TNF running reasons while requiring the _JobRunning suffix. Tests cover the supported variants and reject an uppercase completion reason.

Changes

TNF reason matching

Layer / File(s)	Summary
Reason matching and validation pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go, pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators_test.go	The matcher accepts legacy tnf- and uppercase TNF prefixes only when the reason ends with _JobRunning. Tests cover setup, fencing, auth, update-setup, and after-setup variants, plus a rejected completion reason.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: hongkailiu, stbenjam, tmshort

---

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

• Ignore

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Stable And Deterministic Test Names	❌ Error	The new subtests call t.Run(tt.reason), so titles include generated-looking identifiers such as 064736551, abc12345, and deadbeef.	Add a separate static name field for each case, and pass that field to t.Run; keep the reason value only in the test body.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the monitor test change to recognize PascalCase TNF JobRunning condition reasons.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Test Structure And Quality	✅ Passed	The change extends one table-driven unit test for one predicate, creates no cluster resources, uses no waits, and follows nearby testify test patterns.
Microshift Test Compatibility	✅ Passed	The PR changes only a helper and a standard Go testing unit test; it adds no Ginkgo e2e tests or MicroShift-incompatible test usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only monitor logic and a standard Go testing unit test; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only TNF reason matching and unit-test cases; it adds no deployment manifests, controllers, replicas, affinity, tolerations, selectors, spread constraints, or PDBs.
Ote Binary Stdout Contract	✅ Passed	The PR only changes TNF reason matching and unit-test data; the diff adds no main/init/suite setup code or stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only extends an existing standard Go table-driven unit test; it adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto	✅ Passed	The two changed Go files add only string prefix/suffix matching and test literals; no weak-crypto imports, APIs, custom crypto, or secret comparisons appear.
Container-Privileges	✅ Passed	The PR changes only two Go files. The exact patch and changed-file scan contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The patch only changes TNF reason matching, comments, and tests; it adds no logging or output of passwords, tokens, PII, hostnames, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1245f990-94a0-11f1-9eba-719b88671b2c-0

[openshift-ci-robot]

@eggfoobar: This pull request references Jira Issue OCPBUGS-105466, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

CEO OCPBUGS-84695 renamed TNF job condition types to PascalCase, so etcd Available blips now report TNFSetupJob_JobRunning instead of tnf-setup-job_JobRunning. Accept both shapes in the DualReplica exception.

Summary by CodeRabbit

• Bug Fixes
• Improved recognition of TNF job status reasons across legacy and newer naming formats.
• Ensured only reasons ending with _JobRunning are treated as active job statuses.
• Tests
• Added coverage for uppercase, concatenated, and completed TNF job reason variants.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[eggfoobar]

/payload-aggregate periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-upgrade 2

[openshift-ci]

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/49d9a980-94bc-11f1-9d65-03ba0320edb3-0

[eggfoobar]

/retest-required

[eggfoobar]

/verified by ci

CI shows the test no longer failing, the aggregated run also showed the test no longer failing.

[openshift-ci-robot]

@eggfoobar: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

CI shows the test no longer failing, the aggregated run also showed the test no longer failing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[neisw]

/approve

[fonta-rh]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, fonta-rh, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [neisw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 29be8bd and 2 for PR HEAD bbfb7c0 in total

[openshift-ci]

@eggfoobar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn	bbfb7c0	link	true	/test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.