Skip to content

[DNM] Remove net-seg E2Es covered by OTE tests - #31497

Open
pperiyasamy wants to merge 1 commit into
openshift:mainfrom
pperiyasamy:remove_net_seg_e2es
Open

[DNM] Remove net-seg E2Es covered by OTE tests#31497
pperiyasamy wants to merge 1 commit into
openshift:mainfrom
pperiyasamy:remove_net_seg_e2es

Conversation

@pperiyasamy

@pperiyasamy pperiyasamy commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Tests
    • Removed end-to-end test coverage for network segmentation, connectivity, isolation, lifecycle, and policy scenarios.
    • Retained supporting helper functionality used by the remaining test suite.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7ef87be3-f3b7-4ff8-9601-dcbc3fedb44a

📥 Commits

Reviewing files that changed from the base of the PR and between a302321 and 797609c.

📒 Files selected for processing (2)
  • test/extended/networking/network_segmentation.go
  • test/extended/networking/network_segmentation_policy.go
💤 Files with no reviewable changes (2)
  • test/extended/networking/network_segmentation_policy.go
  • test/extended/networking/network_segmentation.go

Walkthrough

The change removes the network segmentation and network policy end-to-end test suites. It also removes imports used only by the deleted tests. Supporting helper functions remain.

Changes

Network Segmentation Test Removal

Layer / File(s) Summary
Remove segmentation test coverage
test/extended/networking/network_segmentation.go, test/extended/networking/network_segmentation_policy.go
The UDN/CUDN segmentation scenarios and network-policy tests are deleted. Unused Kubernetes error, probe, pod readiness, and pod-security imports are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the removal of network segmentation E2E tests and identifies that OTE tests cover them.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit adds no lines; it removes all Ginkgo title call sites from network_segmentation.go and deletes the policy test file.
Test Structure And Quality ✅ Passed The PR only removes the two net-seg E2E suites; the retained helper file has zero Ginkgo test declarations, and no new test-quality violations remain.
Microshift Test Compatibility ✅ Passed The PR diff contains only 1,568 deleted lines in two networking files and no added Ginkgo tests, so the MicroShift API compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit contains only deletions: 0 added and 1,568 deleted lines across the two files, with no added Ginkgo declarations. No new test requires SNO review.
Topology-Aware Scheduling Compatibility ✅ Passed The commit only deletes two files under test/extended/networking; it adds no manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR adds no lines and removes both suites; the retained helper file has no stdout calls or process-level suite setup.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff adds 0 lines and removes both Ginkgo test suites; no new It, Describe, Context, or When blocks introduce IPv4 or external-connectivity requirements.
No-Weak-Crypto ✅ Passed The patch has 0 additions and only deletes two networking test files; the surviving helper imports no crypto package and uses no flagged algorithms or secret comparisons.
Container-Privileges ✅ Passed The patch adds no lines. It removes privileged namespace settings and NET_ADMIN capability setup; no new privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or escalation settings are introduced.
No-Sensitive-Data-In-Logs ✅ Passed The diff adds no lines (0 additions, 1,568 deletions). Remaining logs contain only temporary paths, ServiceAccount name, and test namespace; no passwords, tokens, keys, PII, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pperiyasamy
Once this PR has been reviewed and has the lgtm label, please assign kyrtapz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@pperiyasamy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-2of2 797609c link true /test e2e-aws-ovn-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant