Skip to content

Revendor OTE to fix panic when spec is pending#31298

Open
mdbooth wants to merge 1 commit into
openshift:mainfrom
mdbooth:revendor-openshift-tests-extension
Open

Revendor OTE to fix panic when spec is pending#31298
mdbooth wants to merge 1 commit into
openshift:mainfrom
mdbooth:revendor-openshift-tests-extension

Conversation

@mdbooth

@mdbooth mdbooth commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Pulls in openshift-eng/openshift-tests-extension#70

Summary by CodeRabbit

  • Chores
    • Updated dependencies for system stability and compatibility.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d958e917-ea10-45b2-994c-e2f6fe4c44a6

📥 Commits

Reviewing files that changed from the base of the PR and between 710a45d and e7674cc.

⛔ Files ignored due to path filters (8)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/openshift-eng/openshift-tests-extension/pkg/cmd/cmdrun/runsuite.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift-eng/openshift-tests-extension/pkg/cmd/cmdrun/runtest.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift-eng/openshift-tests-extension/pkg/extension/extensiontests/types.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift-eng/openshift-tests-extension/pkg/flags/output.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo/parallel.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo/util.go is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (1)
  • go.mod

Walkthrough

This PR updates the github.com/openshift-eng/openshift-tests-extension dependency in go.mod from commit 0fed2b824818 (dated 20260127) to a newer commit 2fd5b2fa4221 (dated 20260612). The change is a single-line version bump in the main require block.

Changes

Dependency Version Update

Layer / File(s) Summary
openshift-tests-extension version update
go.mod
The github.com/openshift-eng/openshift-tests-extension dependency is updated from commit 0fed2b824818 to commit 2fd5b2fa4221 in the main require block.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning FAIL: In changed Ginkgo tests, assertions omit failure messages: access.go uses o.Expect(err).NotTo(o.HaveOccurred()) and config_admission_test.go uses o.Expect(err).To(o.HaveOccurred()) without msg. Add descriptive messages to HaveOccurred assertions (e.g., o.Expect(err).NotTo(o.HaveOccurred(), "...") / o.Expect(err).To(o.HaveOccurred(), "...")) and audit other cluster-interacting waits/assertions for similar omissions.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: revendoring the OTE dependency to address a specific bug (panic when spec is pending).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR #31298 only updates go.mod/go.sum and vendored OTE framework .go files; searches in the updated OTE files found no Ginkgo It/Describe/Context title strings with dynamic data.
Microshift Test Compatibility ✅ Passed PR #31298 only updates go.mod/vendor for openshift-tests-extension; the OTE PR #70 changes are ginkgo framework/tests with no forbidden OpenShift APIs/resources referenced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR #31298 only revendors openshift-tests-extension (go.mod/go.sum + vendored ginkgo/util framework); it does not add any new Ginkgo e2e test specs, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates go.mod/go.sum and vendored openshift-tests-extension files; no deployment manifests or controller scheduling/topology constraints were added or modified.
Ote Binary Stdout Contract ✅ Passed Scanned vendored OTE vnd github.com/openshift-eng/openshift-tests-extension: no main/init/TestMain/BeforeSuite stdout writes; os.Stdout only in cmdinfo/cmdlist/cmdrun JSON output, and ginkgo/util.g...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only updates OTE dependency + vendored framework Go files; none contain ginkgo e2e blocks or hardcoded IPv4/public HTTP connectivity patterns.
No-Weak-Crypto ✅ Passed Scanned vendored openshift-tests-extension Go code for MD5/SHA1/DES/RC4/3DES/Blowfish/ECB and constant-time/secret compare patterns—no matches found.
Container-Privileges ✅ Passed PR #31298 changes only go.mod/go.sum and vendored OTE Go sources (no Kubernetes/YAML manifests); therefore no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation changes were...
No-Sensitive-Data-In-Logs ✅ Passed PR #31298 changes only go.mod (dependency revendor); no logging code is modified, and a scan of go.mod finds no credential/token/password patterns.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the vendor-update Touching vendor dir or related files label Jun 12, 2026
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mdbooth
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from p0lyn0mial and sjenning June 12, 2026 11:30
@mdbooth

mdbooth commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

This closes the loop on openshift-eng/openshift-tests-extension#70

@stbenjam I appreciate that:

  • The PR which introduced a pending spec has been reverted
  • You have already merged an alternative

Consequently we may not want this PR at all, and we'll just revendor OTE according to some other schedule or more pressing requirements. Happy to close if it's not required.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 12, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@mdbooth: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant