OCPBUGS-86221: update authentication operator conditions to no longer expect WellKnownReadyProgressing

[everettraven]

Because the WellKnownReadyController should never have been reporting a progressing condition based on the current definitions of the cluster operator status condition types as it does not have any operands and is a strictly observational controller.

See openshift/cluster-authentication-operator#901 which depends on this change to pass CI.

In an attempt to prevent breaking CI prior to openshift/cluster-authentication-operator#901 being merged, a follow up PR will add the new WellKnownReadyDegradationObserved condition to this list.

Summary by CodeRabbit

• Tests
  • Updated authentication operator status condition requirements for non-OIDC scenarios, removing an unnecessary operator condition from the expected status list.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@everettraven: This pull request references Jira Issue OCPBUGS-86221, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Because the WellKnownReadyController should never have been reporting a progressing condition based on the current definitions of the cluster operator status condition types as it does not have any operands and is a strictly observational controller.

See openshift/cluster-authentication-operator#901 which depends on this change to pass CI.

In an attempt to prevent breaking CI prior to openshift/cluster-authentication-operator#901 being merged, a follow up PR will add the new WellKnownReadyDegradationObserved condition to this list.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5b90b9c3-de24-42e7-9611-594399823b3c

📥 Commits

Reviewing files that changed from the base of the PR and between fa583f7 and e125a07.

📒 Files selected for processing (1)

• test/extended/operators/management_plane_operators.go

💤 Files with no reviewable changes (1)

• test/extended/operators/management_plane_operators.go

---

Walkthrough

This PR removes the "WellKnownReadyControllerProgressing" condition from the required operator conditions for non-OIDC authentications in the extended management plane operators test.

Changes

Authentication Test Conditions

Layer / File(s)	Summary
Non-OIDC authentication required conditions test/extended/operators/management_plane_operators.go	The condition list for non-OIDC authentication types in the authentications runtime-conditional function is updated to exclude WellKnownReadyControllerProgressing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	Test lacks assertion messages (lines 409, 412, 432), missing timeouts on cluster API calls, and no BeforeEach/AfterEach cleanup despite using cluster-scoped resources.	Add meaningful messages to Expect() calls; wrap API calls in Eventually() with timeouts; implement BeforeEach/AfterEach for resource lifecycle management.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: removing the WellKnownReadyProgressing condition from authentication operator conditions, which aligns with the code change in the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Test names use static strings with no dynamic information. All Ginkgo test titles contain only stable descriptive text without any generated values, timestamps, or node/namespace names.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added; the PR only removes a condition string from an existing conditions list used by a test that already skips on MicroShift.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The new Ginkgo test validates operator conditions without multi-node assumptions and includes skips for MicroShift/Hypershift. It works on SNO.
Topology-Aware Scheduling Compatibility	✅ Passed	This change modifies a test file that validates operator conditions, not deployment manifests or scheduling constraints. No topology-incompatible scheduling logic is introduced.
Ote Binary Stdout Contract	✅ Passed	PR removes only a condition string from a test data list; no stdout-writing code exists at process level in the modified test file.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. The change is a single-line removal from a condition list in an existing test's configuration data, not the addition of new test code.
No-Weak-Crypto	✅ Passed	File contains no weak cryptographic algorithms, custom crypto implementations, or insecure comparisons—only Kubernetes operator condition names and configuration data.
Container-Privileges	✅ Passed	The PR modifies a Go test file containing operator condition definitions. No Kubernetes manifests or container configurations are present, making the container-privileges check inapplicable.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds a test file with 4 logging statements that only log schema resources, condition names, and generic error messages - no passwords, tokens, API keys, PII, or customer data.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: everettraven
Once this PR has been reviewed and has the lgtm label, please assign sdodson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• test/extended/operators/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@everettraven: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.