CORENET-6864, CORENET-6169: remove some duplicate ovnk test cases

[jluhrsen]

the following test cases are duplicated with test that will run with the ovnk OTE work which will be enabled with this PR [0]. they are failing because upstream OVNK has bumped it's CNI version to 1.1.0 and these tests are hardcoded here (or in multus [1]) and don't accept 1.1.0 yet. The upstream change in ovnk also updated it's tests so when they run via OTE, they will pass.

[0] #30560
[1] openshift/multus-cni#278

Summary by CodeRabbit

• Tests
  • Removed test cases validating network attachment definition creation against specifications
  • Removed associated test helper functions for manifest validation
  • Reduced overall test coverage for network attachment definition manifest generation

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@jluhrsen: This pull request references CORENET-6864 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

This pull request references CORENET-6169 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

the following test cases are duplicated with test that will run with the ovnk OTE work which will be enabled with this PR [0]. they are failing because upstream OVNK has bumped it's CNI version to 1.1.0 and these tests are hardcoded here (or in multus [1]) and don't accept 1.1.0 yet. The upstream change in ovnk also updated it's tests so when they run via OTE, they will pass.

[0] #30560
[1] openshift/multus-cni#278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 3c4136c and 2692e1d.

📒 Files selected for processing (1)

• test/extended/networking/network_segmentation.go

---

Walkthrough

The pull request removes test coverage from a networking test file by eliminating two test cases and associated helper functions that validated NetworkAttachmentDefinition manifest generation, while adjusting imports. The functional test surface is reduced without any API changes.

Changes

Cohort / File(s)	Summary
Test Coverage Reduction test/extended/networking/network_segmentation.go	Removed two test cases asserting NetworkAttachmentDefinition creation from UserDefinedNetwork specs, eliminated helper functions for NAD manifest validation (assertNetAttachDefManifest and assertClusterNADManifest), and cleaned up related validation code paths. Updated imports to use exutil alias and removed unused k8s/types references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Test Structure And Quality	⚠️ Warning	Test code lacks meaningful failure messages in approximately 61 of 71 assertions, significantly impacting debuggability despite strong setup/cleanup practices.	Add descriptive failure messages to all Expect() assertions, prioritizing critical operations like pod creation, network setup, and connectivity tests.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: removal of duplicate test cases from the OVNK networking tests, with clear Jira issue references.
Stable And Deterministic Test Names	✅ Passed	All test names are stable and deterministic with static descriptive strings. Dynamic values are properly placed within test bodies, not in test titles.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jluhrsen
Once this PR has been reviewed and has the lgtm label, please assign tssurya for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• test/extended/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jluhrsen: This pull request references CORENET-6864 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

This pull request references CORENET-6169 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

the following test cases are duplicated with test that will run with the ovnk OTE work which will be enabled with this PR [0]. they are failing because upstream OVNK has bumped it's CNI version to 1.1.0 and these tests are hardcoded here (or in multus [1]) and don't accept 1.1.0 yet. The upstream change in ovnk also updated it's tests so when they run via OTE, they will pass.

[0] #30560
[1] openshift/multus-cni#278

Summary by CodeRabbit

• Tests
• Removed test cases validating network attachment definition creation against specifications
• Removed associated test helper functions for manifest validation
• Reduced overall test coverage for network attachment definition manifest generation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@jluhrsen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-fips	2692e1d	link	true	/test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.