OCPBUGS-77364: [release-4.20]:cert tests: mark TLS registry test as informing#30814
OCPBUGS-77364: [release-4.20]:cert tests: mark TLS registry test as informing#30814wangke19 wants to merge 2 commits intoopenshift:release-4.20from
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wangke19 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Add ote.Informing() to both certificate tests so that failures are recorded but don't block CI jobs: - all tls artifacts must be registered - all registered tls artifacts must have no metadata violation regressions This allows the tests to continue gathering data without blocking development while certificates are being properly registered and metadata is being fixed.
Add IsRosaCluster() function to test/extended/util/framework.go and use it to skip TLS certificate tests on ROSA clusters, similar to how we skip for MicroShift and Hypershift. ROSA clusters do not auto-collect TLS certificates the same way as standard OpenShift clusters.
3d0d83c to
b5159c9
Compare
|
/jira cherry-pick OCPBUGS-76856 |
|
@wangke19: Jira Issue OCPBUGS-76856 has been cloned as Jira Issue OCPBUGS-77364. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wangke19: This pull request references Jira Issue OCPBUGS-77364, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@wangke19: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/jira refresh |
|
@wangke19: This pull request references Jira Issue OCPBUGS-77364, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/jira refresh |
|
@wangke19: This pull request references Jira Issue OCPBUGS-77364, which is valid. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-ovn-serial-1of2 |
This is a backport of #30779 to release-4.20.
Summary
This PR backports changes to mark TLS certificate tests as informing and skip them on ROSA clusters, allowing the tests to continue gathering data without blocking CI while certificates are being properly registered.
Changes
Commit 1: Mark TLS certificate tests as informing
ote.Informing()to both certificate tests so failures are recorded but don't block CI jobs:Commit 2: Skip TLS certificate tests on ROSA clusters
IsRosaCluster()function totest/extended/util/framework.goRelated
Test Plan
The changes have been manually backported and adapted from the tested commits in #30779. The backport resolves conflicts by keeping existing code patterns while applying the semantic changes (adding
ote.Informing()and ROSA cluster skipping).