Skip to content

OCPBUGS-77364: [release-4.20]:cert tests: mark TLS registry test as informing#30814

Open
wangke19 wants to merge 2 commits intoopenshift:release-4.20from
wangke19:backport-30779-to-release-4.20
Open

OCPBUGS-77364: [release-4.20]:cert tests: mark TLS registry test as informing#30814
wangke19 wants to merge 2 commits intoopenshift:release-4.20from
wangke19:backport-30779-to-release-4.20

Conversation

@wangke19
Copy link
Contributor

@wangke19 wangke19 commented Feb 26, 2026

This is a backport of #30779 to release-4.20.

Summary

This PR backports changes to mark TLS certificate tests as informing and skip them on ROSA clusters, allowing the tests to continue gathering data without blocking CI while certificates are being properly registered.

Changes

Commit 1: Mark TLS certificate tests as informing

  • Add ote.Informing() to both certificate tests so failures are recorded but don't block CI jobs:
    • "all tls artifacts must be registered"
    • "all registered tls artifacts must have no metadata violation regressions"
  • This allows tests to continue gathering data without blocking development while certificates are being properly registered and metadata is being fixed

Commit 2: Skip TLS certificate tests on ROSA clusters

  • Add IsRosaCluster() function to test/extended/util/framework.go
  • Use it to skip TLS certificate tests on ROSA clusters (similar to MicroShift and Hypershift)
  • ROSA clusters do not auto-collect TLS certificates the same way as standard OpenShift clusters

Related

Test Plan

The changes have been manually backported and adapted from the tested commits in #30779. The backport resolves conflicts by keeping existing code patterns while applying the semantic changes (adding ote.Informing() and ROSA cluster skipping).

@wangke19 wangke19 changed the title [release-4.21] :cert tests: mark TLS registry test as informing [release-4.20]:cert tests: mark TLS registry test as informing Feb 26, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wangke19
Once this PR has been reviewed and has the lgtm label, please assign dennisperiquet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Add ote.Informing() to both certificate tests so that failures are
recorded but don't block CI jobs:
- all tls artifacts must be registered
- all registered tls artifacts must have no metadata violation regressions

This allows the tests to continue gathering data without blocking
development while certificates are being properly registered and
metadata is being fixed.
Add IsRosaCluster() function to test/extended/util/framework.go and
use it to skip TLS certificate tests on ROSA clusters, similar to how
we skip for MicroShift and Hypershift.

ROSA clusters do not auto-collect TLS certificates the same way as
standard OpenShift clusters.
@wangke19 wangke19 force-pushed the backport-30779-to-release-4.20 branch from 3d0d83c to b5159c9 Compare February 26, 2026 07:56
@wangke19
Copy link
Contributor Author

/jira cherry-pick OCPBUGS-76856

@openshift-ci-robot
Copy link

@wangke19: Jira Issue OCPBUGS-76856 has been cloned as Jira Issue OCPBUGS-77364. Will retitle bug to link to clone.
/retitle OCPBUGS-77364: [release-4.20]:cert tests: mark TLS registry test as informing

Details

In response to this:

/jira cherry-pick OCPBUGS-76856

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20]:cert tests: mark TLS registry test as informing OCPBUGS-77364: [release-4.20]:cert tests: mark TLS registry test as informing Feb 26, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 26, 2026
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-77364, which is invalid:

  • expected dependent Jira Issue OCPBUGS-76856 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a backport of #30779 to release-4.20.

Summary

This PR backports changes to mark TLS certificate tests as informing and skip them on ROSA clusters, allowing the tests to continue gathering data without blocking CI while certificates are being properly registered.

Changes

Commit 1: Mark TLS certificate tests as informing

  • Add ote.Informing() to both certificate tests so failures are recorded but don't block CI jobs:
  • "all tls artifacts must be registered"
  • "all registered tls artifacts must have no metadata violation regressions"
  • This allows tests to continue gathering data without blocking development while certificates are being properly registered and metadata is being fixed

Commit 2: Skip TLS certificate tests on ROSA clusters

  • Add IsRosaCluster() function to test/extended/util/framework.go
  • Use it to skip TLS certificate tests on ROSA clusters (similar to MicroShift and Hypershift)
  • ROSA clusters do not auto-collect TLS certificates the same way as standard OpenShift clusters

Related

Test Plan

The changes have been manually backported and adapted from the tested commits in #30779. The backport resolves conflicts by keeping existing code patterns while applying the semantic changes (adding ote.Informing() and ROSA cluster skipping).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

@wangke19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-image-registry 3d0d83c link true /test e2e-aws-ovn-image-registry
ci/prow/e2e-aws-ovn-serial-1of2 b5159c9 link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-gcp-ovn b5159c9 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-serial-2of2 b5159c9 link true /test e2e-aws-ovn-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wangke19
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 27, 2026
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-77364, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-76856 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-76856 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

/retest

@wangke19
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-77364, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-76856 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-76856 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

/test e2e-aws-ovn-serial-1of2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants