OCPNODE-3932: Add automated tests for non-CNV swap configuration#30807
Open
BhargaviGudi wants to merge 1 commit intoopenshift:mainfrom
Open
OCPNODE-3932: Add automated tests for non-CNV swap configuration#30807BhargaviGudi wants to merge 1 commit intoopenshift:mainfrom
BhargaviGudi wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@BhargaviGudi: This pull request references OCPNODE-3932 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
Contributor
Author
|
/payload-job periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-ovn-conformance |
Contributor
|
@BhargaviGudi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/371272f0-115e-11f1-870d-84023c2ce795-0 |
BhargaviGudi
force-pushed
the
bgudi-swap-noncnv
branch
from
97336a9 to
350340b
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BhargaviGudi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Scheduling required tests: |
BhargaviGudi
force-pushed
the
bgudi-swap-noncnv
branch
from
350340b to
00cdbe8
Compare
Contributor
Author
|
/payload-job periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-ovn-conformance |
Contributor
|
@BhargaviGudi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/531edb50-1190-11f1-8b42-574034db1f18-0 |
Contributor
Author
|
/payload-job periodic-ci-openshift-release-master-nightly-4.22-e2e-metal-ipi-ovn-ipv6 |
Contributor
Author
|
/payload-job periodic-ci-openshift-release-master-ci-4.22-e2e-aws-upgrade-ovn-single-node |
Contributor
|
@BhargaviGudi: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
1 similar comment
Contributor
|
@BhargaviGudi: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
Ran make verify-deps Skip for hypershift cluster Skip for SNO clusters
BhargaviGudi
force-pushed
the
bgudi-swap-noncnv
branch
from
00cdbe8 to
2a38891
Compare
|
@BhargaviGudi: This pull request references OCPNODE-3932 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
Contributor
Author
|
/test e2e-vsphere-ovn |
Contributor
Author
|
/verified by @BhargaviGudi |
openshift-ci-robot
added
the
verified
|
@BhargaviGudi: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
/retest |
Contributor
|
@BhargaviGudi: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
Note: e2e-metal-ipi-ovn-ipv6 and e2e-vsphere-ovn are failing due to cluster installation failure. |
BhargaviGudi
changed the title
openshift-ci
bot
added
do-not-merge/hold
Contributor
Author
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Job Failure Risk Analysis for sha: 2a38891
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds automated tests for non-CNV swap configuration on OpenShift nodes.
Skips the tests for Hypershift and SNO clusters.
Jira story: https://issues.redhat.com/browse/OCPNODE-3932
Validates:
Files Added
test/extended/node/node_swap.go- Test casestest/extended/node/node_utils.go- Helper functions for node and kubelet config operationsTest cases:
OCP-86394
OCP-86395
[Jira:Node][sig-node] Node non-cnv swap configuration should have correct default kubelet swap settings with worker nodes failSwapOn=false, control plane nodes failSwapOn=true, and both swapBehavior=NoSwap [Jira:Node] [OCP-86394] github.com/openshift/origin/test/extended/node/node_swap.go:46 STEP: Creating a kubernetes client @ 01/12/26 13:53:15.953 I0112 13:53:15.954150 54173 discovery.go:214] Invalidating discovery information I0112 13:53:19.087172 54173 client.go:293] configPath is now "/tmp/configfile1332138601" I0112 13:53:19.087205 54173 client.go:368] The user is now "e2e-test-node-swap-btg8f-user" I0112 13:53:19.087220 54173 client.go:370] Creating project "e2e-test-node-swap-btg8f" I0112 13:53:19.509151 54173 client.go:378] Waiting on permissions in project "e2e-test-node-swap-btg8f" ... I0112 13:53:20.757654 54173 client.go:407] DeploymentConfig capability is enabled, adding 'deployer' SA to the list of default SAs I0112 13:53:21.030854 54173 client.go:422] Waiting for ServiceAccount "default" to be provisioned... I0112 13:53:21.780319 54173 client.go:422] Waiting for ServiceAccount "builder" to be provisioned... I0112 13:53:22.497353 54173 client.go:422] Waiting for ServiceAccount "deployer" to be provisioned... I0112 13:53:23.214772 54173 client.go:432] Waiting for RoleBinding "system:image-pullers" to be provisioned... I0112 13:53:23.828307 54173 client.go:432] Waiting for RoleBinding "system:image-builders" to be provisioned... I0112 13:53:24.362820 54173 client.go:432] Waiting for RoleBinding "system:deployers" to be provisioned... I0112 13:53:25.572055 54173 client.go:465] Project "e2e-test-node-swap-btg8f" has been fully provisioned. I0112 13:53:25.876964 54173 framework.go:2334] microshift-version configmap not found STEP: Getting worker nodes @ 01/12/26 13:53:25.877 STEP: Validating kubelet configuration on each worker node @ 01/12/26 13:53:26.184 STEP: Checking failSwapOn=false on worker node bgudi-j12-kgf87-worker-a-ks7zw @ 01/12/26 13:53:26.491 I0112 13:53:26.491051 54173 node_swap.go:60] Worker node bgudi-j12-kgf87-worker-a-ks7zw: failSwapOn=false ✓ STEP: Checking swapBehavior=NoSwap on worker node bgudi-j12-kgf87-worker-a-ks7zw @ 01/12/26 13:53:26.491 I0112 13:53:26.491076 54173 node_swap.go:65] Worker node bgudi-j12-kgf87-worker-a-ks7zw: swapBehavior=NoSwap ✓ STEP: Checking failSwapOn=false on worker node bgudi-j12-kgf87-worker-b-hnkhq @ 01/12/26 13:53:26.799 I0112 13:53:26.799069 54173 node_swap.go:60] Worker node bgudi-j12-kgf87-worker-b-hnkhq: failSwapOn=false ✓ STEP: Checking swapBehavior=NoSwap on worker node bgudi-j12-kgf87-worker-b-hnkhq @ 01/12/26 13:53:26.799 I0112 13:53:26.799116 54173 node_swap.go:65] Worker node bgudi-j12-kgf87-worker-b-hnkhq: swapBehavior=NoSwap ✓ STEP: Checking failSwapOn=false on worker node bgudi-j12-kgf87-worker-c-xbbkd @ 01/12/26 13:53:27.105 I0112 13:53:27.105627 54173 node_swap.go:60] Worker node bgudi-j12-kgf87-worker-c-xbbkd: failSwapOn=false ✓ STEP: Checking swapBehavior=NoSwap on worker node bgudi-j12-kgf87-worker-c-xbbkd @ 01/12/26 13:53:27.105 I0112 13:53:27.105664 54173 node_swap.go:65] Worker node bgudi-j12-kgf87-worker-c-xbbkd: swapBehavior=NoSwap ✓ STEP: Getting control plane nodes @ 01/12/26 13:53:27.105 STEP: Validating kubelet configuration on each control plane node @ 01/12/26 13:53:27.404 STEP: Checking failSwapOn=true on control plane node bgudi-j12-kgf87-master-0.us-central1-a.c.openshift-qe.internal @ 01/12/26 13:53:27.695 I0112 13:53:27.695585 54173 node_swap.go:81] Control plane node bgudi-j12-kgf87-master-0.us-central1-a.c.openshift-qe.internal: failSwapOn=true ✓ STEP: Checking swapBehavior=NoSwap on control plane node bgudi-j12-kgf87-master-0.us-central1-a.c.openshift-qe.internal @ 01/12/26 13:53:27.695 I0112 13:53:27.695623 54173 node_swap.go:86] Control plane node bgudi-j12-kgf87-master-0.us-central1-a.c.openshift-qe.internal: swapBehavior=NoSwap ✓ STEP: Checking failSwapOn=true on control plane node bgudi-j12-kgf87-master-1.us-central1-b.c.openshift-qe.internal @ 01/12/26 13:53:28.006 I0112 13:53:28.007013 54173 node_swap.go:81] Control plane node bgudi-j12-kgf87-master-1.us-central1-b.c.openshift-qe.internal: failSwapOn=true ✓ STEP: Checking swapBehavior=NoSwap on control plane node bgudi-j12-kgf87-master-1.us-central1-b.c.openshift-qe.internal @ 01/12/26 13:53:28.007 I0112 13:53:28.007073 54173 node_swap.go:86] Control plane node bgudi-j12-kgf87-master-1.us-central1-b.c.openshift-qe.internal: swapBehavior=NoSwap ✓ STEP: Checking failSwapOn=true on control plane node bgudi-j12-kgf87-master-2.us-central1-c.c.openshift-qe.internal @ 01/12/26 13:53:28.295 I0112 13:53:28.295523 54173 node_swap.go:81] Control plane node bgudi-j12-kgf87-master-2.us-central1-c.c.openshift-qe.internal: failSwapOn=true ✓ STEP: Checking swapBehavior=NoSwap on control plane node bgudi-j12-kgf87-master-2.us-central1-c.c.openshift-qe.internal @ 01/12/26 13:53:28.295 I0112 13:53:28.295549 54173 node_swap.go:86] Control plane node bgudi-j12-kgf87-master-2.us-central1-c.c.openshift-qe.internal: swapBehavior=NoSwap ✓ I0112 13:53:28.295564 54173 node_swap.go:88] Test PASSED: All nodes have correct default swap settings I0112 13:53:28.641012 54173 client.go:681] Deleted {user.openshift.io/v1, Resource=users e2e-test-node-swap-btg8f-user}, err: I0112 13:53:28.920122 54173 client.go:681] Deleted {oauth.openshift.io/v1, Resource=oauthclients e2e-client-e2e-test-node-swap-btg8f}, err: I0112 13:53:29.205068 54173 client.go:681] Deleted {oauth.openshift.io/v1, Resource=oauthaccesstokens sha256~B0he02YdA3rQmivC_6pxgH1W-Fq8OxWRhXi4bkQlJnk}, err: STEP: Destroying namespace "e2e-test-node-swap-btg8f" for this suite. @ 01/12/26 13:53:29.205 • [13.618 seconds] ------------------------------ Ran 1 of 1 Specs in 13.618 seconds SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 SkippedWill run 1 of 1 specs ------------------------------ [Jira:Node][sig-node] Node non-cnv swap configuration should reject user override of swap settings via KubeletConfig API [OCP-86395] github.com/openshift/origin/test/extended/node/node_swap.go:91 STEP: Creating a kubernetes client @ 01/12/26 15:25:28.344 I0112 15:25:28.345790 88048 discovery.go:214] Invalidating discovery information I0112 15:25:33.846094 88048 client.go:293] configPath is now "/tmp/configfile1714018848" I0112 15:25:33.846149 88048 client.go:368] The user is now "e2e-test-node-swap-9tzrc-user" I0112 15:25:33.846161 88048 client.go:370] Creating project "e2e-test-node-swap-9tzrc" I0112 15:25:34.199847 88048 client.go:378] Waiting on permissions in project "e2e-test-node-swap-9tzrc" ... I0112 15:25:35.381516 88048 client.go:407] DeploymentConfig capability is enabled, adding 'deployer' SA to the list of default SAs I0112 15:25:35.640898 88048 client.go:422] Waiting for ServiceAccount "default" to be provisioned... I0112 15:25:36.300768 88048 client.go:422] Waiting for ServiceAccount "builder" to be provisioned... I0112 15:25:37.016542 88048 client.go:422] Waiting for ServiceAccount "deployer" to be provisioned... I0112 15:25:37.731628 88048 client.go:432] Waiting for RoleBinding "system:image-pullers" to be provisioned... I0112 15:25:38.398078 88048 client.go:432] Waiting for RoleBinding "system:image-builders" to be provisioned... I0112 15:25:39.013079 88048 client.go:432] Waiting for RoleBinding "system:deployers" to be provisioned... I0112 15:25:40.139612 88048 client.go:465] Project "e2e-test-node-swap-9tzrc" has been fully provisioned. I0112 15:25:40.446533 88048 framework.go:2334] microshift-version configmap not found STEP: Creating machine config client @ 01/12/26 15:25:40.446 STEP: Getting initial machine config resourceVersion @ 01/12/26 15:25:40.446 STEP: Creating a KubeletConfig with swap settings @ 01/12/26 15:25:40.704 STEP: Attempting to apply the KubeletConfig @ 01/12/26 15:25:40.704 I0112 15:25:40.704259 88048 node_swap.go:126] Creating KubeletConfig with failSwapOn=true and swapBehavior=LimitedSwap STEP: Checking KubeletConfig status for expected error message @ 01/12/26 15:25:40.963 I0112 15:25:43.234048 88048 node_swap.go:152] Found Failure condition: Error: KubeletConfiguration: failSwapOn is not allowed to be set, but contains: true STEP: Verifying machine config was not created or updated @ 01/12/26 15:25:43.234 STEP: Verifying worker nodes still have correct swap settings @ 01/12/26 15:25:48.508 STEP: Verifying failSwapOn=false remains unchanged on worker node ci-op-5v1xq5wl-10999-jrj4s-worker-centralus1-9dz4n @ 01/12/26 15:25:49.458 I0112 15:25:49.458183 88048 node_swap.go:185] Worker node ci-op-5v1xq5wl-10999-jrj4s-worker-centralus1-9dz4n: failSwapOn=false (unchanged) ✓ STEP: Verifying swapBehavior=NoSwap remains unchanged on worker node ci-op-5v1xq5wl-10999-jrj4s-worker-centralus1-9dz4n @ 01/12/26 15:25:49.458 I0112 15:25:49.458219 88048 node_swap.go:190] Worker node ci-op-5v1xq5wl-10999-jrj4s-worker-centralus1-9dz4n: swapBehavior=NoSwap (unchanged) ✓ STEP: Verifying failSwapOn=false remains unchanged on worker node ci-op-5v1xq5wl-10999-jrj4s-worker-centralus2-75l7t @ 01/12/26 15:25:49.754 I0112 15:25:49.754444 88048 node_swap.go:185] Worker node ci-op-5v1xq5wl-10999-jrj4s-worker-centralus2-75l7t: failSwapOn=false (unchanged) ✓ STEP: Verifying swapBehavior=NoSwap remains unchanged on worker node ci-op-5v1xq5wl-10999-jrj4s-worker-centralus2-75l7t @ 01/12/26 15:25:49.754 I0112 15:25:49.754525 88048 node_swap.go:190] Worker node ci-op-5v1xq5wl-10999-jrj4s-worker-centralus2-75l7t: swapBehavior=NoSwap (unchanged) ✓ STEP: Verifying failSwapOn=false remains unchanged on worker node ci-op-5v1xq5wl-10999-jrj4s-worker-centralus3-9lnrz @ 01/12/26 15:25:50.073 I0112 15:25:50.073677 88048 node_swap.go:185] Worker node ci-op-5v1xq5wl-10999-jrj4s-worker-centralus3-9lnrz: failSwapOn=false (unchanged) ✓ STEP: Verifying swapBehavior=NoSwap remains unchanged on worker node ci-op-5v1xq5wl-10999-jrj4s-worker-centralus3-9lnrz @ 01/12/26 15:25:50.073 I0112 15:25:50.073813 88048 node_swap.go:190] Worker node ci-op-5v1xq5wl-10999-jrj4s-worker-centralus3-9lnrz: swapBehavior=NoSwap (unchanged) ✓ I0112 15:25:50.073838 88048 node_swap.go:193] Test PASSED: KubeletConfig with failSwapOn was properly rejected I0112 15:25:50.687721 88048 client.go:681] Deleted {user.openshift.io/v1, Resource=users e2e-test-node-swap-9tzrc-user}, err: I0112 15:25:50.993412 88048 client.go:681] Deleted {oauth.openshift.io/v1, Resource=oauthclients e2e-client-e2e-test-node-swap-9tzrc}, err: I0112 15:25:51.258458 88048 client.go:681] Deleted {oauth.openshift.io/v1, Resource=oauthaccesstokens sha256~urJPAAwYTdNinFhNqG-lZ1UzWd8-qHq8FcVca9OcY-s}, err: STEP: Destroying namespace "e2e-test-node-swap-9tzrc" for this suite. @ 01/12/26 15:25:51.258 • [23.184 seconds] ------------------------------ Ran 1 of 1 Specs in 23.185 seconds SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped