Skip to content

TRT-2545: Extend known image checker to cover openshift-must-gather-* namespaces #30777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Feb 27, 2026
Merged

TRT-2545: Extend known image checker to cover openshift-must-gather-* namespaces #30777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pkg/monitortests/testframework/knownimagechecker/monitortest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ func (*clusterImageValidator) ConstructComputedIntervals(ctx context.Context, st
// EvaluateTestsFromConstructedIntervals checks whether the cluster pulled an image that is
// outside the allowed list of images. The list is defined as a set of static test case images, the
// local cluster registry, any repository referenced by the image streams in the cluster's 'openshift'
// namespace, or the location that input images are cloned from. Only namespaces prefixed with 'e2e-'
// are checked.
// namespace, or the location that input images are cloned from. Namespaces prefixed with 'e2e-' or
// 'openshift-must-gather-' are checked.
// any image not in the allowed prefixes is considered a failure, as the user
// may have added a new test image without calling the appropriate helpers
func (w *clusterImageValidator) EvaluateTestsFromConstructedIntervals(ctx context.Context, finalIntervals monitorapi.Intervals) ([]*junitapi.JUnitTestCase, error) {
Expand Down Expand Up @@ -146,8 +146,9 @@ func (w *clusterImageValidator) EvaluateTestsFromConstructedIntervals(ctx contex
if event.Message.Reason != "Pulled" {
continue
}
// only look at pull events from an e2e-* namespace
if !strings.HasPrefix(event.Locator.Keys[monitorapi.LocatorNamespaceKey], "e2e-") {
// only look at pull events from test-owned namespaces (e2e-* and openshift-must-gather-*)
ns := event.Locator.Keys[monitorapi.LocatorNamespaceKey]
if !strings.HasPrefix(ns, "e2e-") && !strings.HasPrefix(ns, "openshift-must-gather-") {
continue
}

Expand Down