OCPBUGS-74151: Add test for CPMS OnDelete strategy with full master replacement#30760
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci
bot
added
do-not-merge/work-in-progress
|
/testwith openshift/cluster-etcd-operator/main/e2e-aws-ovn-etcd-scaling openshift/cluster-etcd-operator#1540 |
|
Not sure if multipr tests work on presubmits like that but hopefully that goes through. |
|
Scheduling required tests: |
hasbro17
force-pushed
the
delete-all-scaling-test
branch
from
533dead to
2df8f6a
Compare
|
/testwith openshift/cluster-etcd-operator/main/e2e-aws-ovn-etcd-scaling openshift/cluster-etcd-operator#1540 |
|
Scheduling required tests: |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 2df8f6a
|
hasbro17
force-pushed
the
delete-all-scaling-test
branch
from
2df8f6a to
e24dcd0
Compare
|
/testwith openshift/cluster-etcd-operator/main/e2e-aws-ovn-etcd-scaling openshift/cluster-etcd-operator#1540 |
|
/retitle OCPBUGS-74151: Add test for CPMS OnDelete strategy with full master replacement |
openshift-ci
bot
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/valid-reference
|
@hasbro17: This pull request references Jira Issue OCPBUGS-74151, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @jubittajohn |
|
This test will fail as is without openshift/cluster-etcd-operator#1540 Once this is in, we'll run the scaling presubmit on openshift/cluster-etcd-operator#1540 to verify that change. |
hasbro17
force-pushed
the
delete-all-scaling-test
branch
from
e24dcd0 to
b5686a4
Compare
|
/testwith openshift/cluster-etcd-operator/main/e2e-aws-ovn-etcd-scaling openshift/cluster-etcd-operator#1540 |
|
Updating the OWNERS while we're here. |
|
/cherry-pick release-4.21 release-4.20 release-4.19 release-4.18 |
|
@hasbro17: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Scheduling required tests: |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: b5686a4
|
|
/testwith openshift/cluster-etcd-operator/main/e2e-aws-ovn-etcd-scaling openshift/cluster-etcd-operator#1540 |
Creates a new test case that validates the ControlPlaneMachineSet OnDelete strategy by deleting all three master machines simultaneously and verifying CPMS correctly replaces them while maintaining cluster health. The test switches CPMS to OnDelete strategy, deletes all master machines, and validates that CPMS creates replacements with proper etcd membership transitions. Verifies that all old etcd members are removed from both the cluster and etcd-endpoints ConfigMap, and new members are properly integrated. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
hasbro17
force-pushed
the
delete-all-scaling-test
branch
from
b5686a4 to
1ddc35b
Compare
|
The membership changes take place just fine but the test keeps timing out on the API server rollout. I expect the removal of the old machines takes a while and that triggers new revisions. |
|
/testwith openshift/cluster-etcd-operator/main/e2e-aws-ovn-etcd-scaling openshift/cluster-etcd-operator#1540 |
|
Scheduling required tests: |
|
Alright that did it |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dusk125, hasbro17 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
openshift-ci-robot
added
the
verified
|
@hasbro17: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
Job Failure Risk Analysis for sha: 1ddc35b
|
|
/retest-required |
1 similar comment
|
/retest-required |
openshift-merge-bot
bot
merged commit 020bb93
into
openshift:main
|
@hasbro17: Jira Issue OCPBUGS-74151: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-74151 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@hasbro17: new pull request created: #30802 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@hasbro17: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Fix included in accepted release 4.22.0-0.nightly-2026-02-21-040517 |
7 participants
E2E test for openshift/cluster-etcd-operator#1540
Creates a new test case that validates the ControlPlaneMachineSet OnDelete strategy by deleting all three master machines simultaneously and verifying CPMS correctly replaces them while maintaining cluster health.
The test switches CPMS to OnDelete strategy, deletes all master machines, and validates that CPMS creates replacements with proper etcd membership transitions. Verifies that all old etcd members are removed from both the cluster and etcd-endpoints ConfigMap, and new members are properly integrated.
TODO: need to wire up the vertical scaling workflow in the openshift/release repo so that this test runs in its own job/presubmit and gets skipped in the regular etcd scaling.