OCPBUGS-62875: images: test that creating an imagestream with --dry-run does not actually create the object#30403
OCPBUGS-62875: images: test that creating an imagestream with --dry-run does not actually create the object#30403liouk wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@liouk: This pull request references Jira Issue OCPBUGS-62875, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
test/extended/images/dryrun.go
Outdated
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| // wait for 30s to make sure we'll not miss any resource created accidentally | ||
| err = wait.PollUntilContextTimeout(context.Background(), 1*time.Second, 30*time.Second, true, func(ctx context.Context) (bool, error) { |
There was a problem hiding this comment.
This guarantees that test will return after 30 seconds. Maybe it is better to return just after 10 seconds.
a7639ca to
7872e88
Compare
|
/lgtm |
|
/retest |
|
The failed jobs I think there is no fixed |
|
/verified later @wangke19 |
|
@wangke19: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/approve |
|
/hold Revision 7872e88 was retested 3 times: holding |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 7872e88
New tests seen in this PR at sha: 7872e88
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, flavianmissi, liouk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by e2e tests |
|
@wangke19: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/unhold |
|
/test e2e-aws-ovn-fips |
|
/retest |
|
/test e2e-aws-ovn-fips |
|
Backport to 4.20 PR #30389 |
|
/hold |
|
/retest |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 15f0885
New tests seen in this PR at sha: 15f0885
|
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 15f0885
New tests seen in this PR at sha: 15f0885
|
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 15f0885
New tests seen in this PR at sha: 15f0885
|
|
/retest |
|
@liouk: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 15f0885
New tests seen in this PR at sha: 15f0885
|
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 15f0885
New tests seen in this PR at sha: 15f0885
|
|
/jira refresh The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity. |
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-62875, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This test will fail without openshift/oc#2117 and must not be merged before the fix.
/hold