Skip to content

OSDOCS-20054: Remove invalid amd_iommu=on kernel argument - #118945

Open
dwivedipranav-dev wants to merge 1 commit into
openshift:mainfrom
dwivedipranav-dev:OSDOCS-20054-fix-amd-iommu
Open

OSDOCS-20054: Remove invalid amd_iommu=on kernel argument#118945
dwivedipranav-dev wants to merge 1 commit into
openshift:mainfrom
dwivedipranav-dev:OSDOCS-20054-fix-amd-iommu

Conversation

@dwivedipranav-dev

Copy link
Copy Markdown

Summary

  • Removes the incorrect instruction to set amd_iommu=on in the IOMMU MachineConfig procedure.
  • Clarifies that AMD IOMMU is enabled by default when AMD-Vi is enabled in BIOS; intel_iommu=on remains valid for Intel.
  • Updates modules/virt-adding-kernel-arguments-enable-iommu.adoc (used by PCI passthrough and vGPU).
    Jira: https://issues.redhat.com/browse/OSDOCS-20054

Cherry-picks

Please cherry-pick to: enterprise-4.16, enterprise-4.17, enterprise-4.18, enterprise-4.19, enterprise-4.20, enterprise-4.21, enterprise-4.22

Test plan

  • Preview the PCI passthrough and vGPU assemblies
  • Confirm the Intel example still uses intel_iommu=on
  • Confirm this module no longer recommends amd_iommu=on
  • SME review of optional iommu=pt wording

AMD IOMMU does not accept 'on' and is enabled by default when AMD-Vi
is enabled in BIOS. Keep intel_iommu=on for Intel CPUs.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 27, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 27, 2026

Copy link
Copy Markdown

@dwivedipranav-dev: This pull request references OSDOCS-20054 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

  • Removes the incorrect instruction to set amd_iommu=on in the IOMMU MachineConfig procedure.
  • Clarifies that AMD IOMMU is enabled by default when AMD-Vi is enabled in BIOS; intel_iommu=on remains valid for Intel.
  • Updates modules/virt-adding-kernel-arguments-enable-iommu.adoc (used by PCI passthrough and vGPU).
    Jira: https://issues.redhat.com/browse/OSDOCS-20054

Cherry-picks

Please cherry-pick to: enterprise-4.16, enterprise-4.17, enterprise-4.18, enterprise-4.19, enterprise-4.20, enterprise-4.21, enterprise-4.22

Test plan

  • Preview the PCI passthrough and vGPU assemblies
  • Confirm the Intel example still uses intel_iommu=on
  • Confirm this module no longer recommends amd_iommu=on
  • SME review of optional iommu=pt wording

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2026
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown

Hi @dwivedipranav-dev. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants