[OSDOCS#17059]: CQA 2.0 disconeted update withot OSUS#115120
Open
rh-sgehlot wants to merge 1 commit into
Open
Conversation
openshift-ci
Bot
added
the
size/M
rh-sgehlot
force-pushed
the
OSDOCS#17059_CQA_2.0_disconnected_update
branch
from
b64d9df to
584bb9e
Compare
|
@rh-sgehlot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
skopacz1
reviewed
Jul 10, 2026
skopacz1
left a comment
skopacz1
left a comment
Contributor
There was a problem hiding this comment.
Nicely done, here are some initial comments and I can take another look once these are addressed next week.
Comment on lines
5
to
10
| endif::openshift-origin[] | ||
| ifdef::openshift-origin[] | ||
| [id="updating-disconnected-cluster"] | ||
| = Updating a cluster in a disconnected environment by using the CLI | ||
| endif::openshift-origin[] | ||
| include::_attributes/common-attributes.adoc[] |
Contributor
There was a problem hiding this comment.
So on the DITA errors guide page the author line error talks more about spacing in between headings and the following content, maybe adding spaces here wherever applicable would suffice:
Suggested change
| endif::openshift-origin[] | |
| ifdef::openshift-origin[] | |
| [id="updating-disconnected-cluster"] | |
| = Updating a cluster in a disconnected environment by using the CLI | |
| endif::openshift-origin[] | |
| include::_attributes/common-attributes.adoc[] |
Comment on lines
+15
to
+16
| [role="_abstract"] | ||
| You can update a cluster in a disconnected environment without using the OpenShift Update Service by using the CLI. |
Contributor
There was a problem hiding this comment.
Okay I didn't actually realize that on the call, this addition was your own. I would actually have two intros here, one for enterprise docs that talks about updates without OSUS, and one for OKD that doesn't mention OSUS and instead focuses on the CLI:
Suggested change
| [role="_abstract"] | |
| You can update a cluster in a disconnected environment without using the OpenShift Update Service by using the CLI. | |
| ifndef::openshift-origin[] | |
| [role="_abstract"] | |
| You can update a cluster in a disconnected environment without using the OpenShift Update Service. | |
| endif::openshift-origin[] | |
| ifdef::openshift-origin[] | |
| [role="_abstract"] | |
| You can update a cluster in a disconnected environment by using the CLI. | |
| endif::openshift-origin[] |
| .Additional resources | ||
| * xref:../../disconnected/updating/mirroring-image-repository.adoc#mirroring-ocp-image-repository[Mirroring {product-title} images] | ||
| * xref:../../authentication/using-rbac.adoc#using-rbac[Using RBAC to define and apply permissions] | ||
| * xref:../../backup_and_restore/control_plane_backup_and_restore/backing-up-etcd.adoc#backup-etcd[etcd backup] |
Contributor
There was a problem hiding this comment.
Suggested change
| * xref:../../backup_and_restore/control_plane_backup_and_restore/backing-up-etcd.adoc#backup-etcd[etcd backup] | |
| * xref:../../backup_and_restore/control_plane_backup_and_restore/backing-up-etcd.adoc#backup-etcd[Backing up etcd] |
| * You must provision a local container image registry with the container images for your update, as described in "Mirroring {product-title} images". | ||
| * You must have access to the cluster as a user with `admin` privileges. | ||
| See "Using RBAC to define and apply permissions". | ||
| * You must have a recent "etcd backup" in case your update fails and you must "restore your cluster to a previous state". |
Contributor
There was a problem hiding this comment.
Suggested change
| * You must have a recent "etcd backup" in case your update fails and you must "restore your cluster to a previous state". | |
| * You must have a recent etcd backup in case your update fails and you must restore your cluster to a previous state. | |
| For more information, see "Backing up etcd" and "Restoring to a previous cluster state". |
| * xref:../../disconnected/updating/mirroring-image-repository.adoc#mirroring-ocp-image-repository[Mirroring {product-title} images] | ||
| * xref:../../authentication/using-rbac.adoc#using-rbac[Using RBAC to define and apply permissions] | ||
| * xref:../../backup_and_restore/control_plane_backup_and_restore/backing-up-etcd.adoc#backup-etcd[etcd backup] | ||
| * xref:../../backup_and_restore/control_plane_backup_and_restore/disaster_recovery/scenario-2-restoring-cluster-state.adoc#dr-restoring-cluster-state[restore your cluster to a previous state] |
Contributor
There was a problem hiding this comment.
Suggested change
| * xref:../../backup_and_restore/control_plane_backup_and_restore/disaster_recovery/scenario-2-restoring-cluster-state.adoc#dr-restoring-cluster-state[restore your cluster to a previous state] | |
| * xref:../../backup_and_restore/control_plane_backup_and_restore/disaster_recovery/scenario-2-restoring-cluster-state.adoc#dr-restoring-cluster-state[Restoring to a previous cluster state] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version(s):
4.20 +
Issue:
https://redhat.atlassian.net/browse/OSDOCS-17059
Link to docs preview:
https://115120--ocpdocs-pr.netlify.app/openshift-enterprise/latest/disconnected/updating/disconnected-update.html
QE review:
Additional information: