OCPBUGS-73844: Let import mode be decided by the cluster when not specified by Prashanth684 · Pull Request #2183 · openshift/oc

Prashanth684 · 2026-01-15T20:47:58Z

Today, we default to "Legacy" importmode when no option is specified. With the introduction of
https://issues.redhat.com/browse/MULTIARCH-4552, the importmode is determined by the Cluster version's desired.architecture - which if set to "Multi", the import mode is PreserveOriginal else Legacy. Hence we don't need to default to Legacy all the time.

openshift-ci-robot · 2026-01-15T20:48:05Z

@Prashanth684: This pull request references Jira Issue OCPBUGS-73844, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Today, we default to "Legacy" importmode when no option is specified. With the introduction of
https://issues.redhat.com/browse/MULTIARCH-4552, the importmode is determined by the Cluster version's desired.architecture - which if set to "Multi", the import mode is PreserveOriginal else Legacy. Hence we don't need to default to Legacy all the time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-01-15T20:48:12Z

Walkthrough

Removed automatic defaulting of image ImportMode to "Legacy" across CLI commands and helpers; flag help texts updated to explain behaviors for PreserveOriginal, Legacy, and unspecified (cluster-determined) modes. Tests were updated to expect an empty ImportMode when unset.

Changes

Cohort / File(s)	Summary
Import image CLI `pkg/cli/importimage/importimage.go`	Removed default initialization of `ImportMode` in `NewImportImageOptions`; removed fallback to Legacy in `Validate`; updated `--import-mode` flag description to document Legacy, PreserveOriginal, and cluster-determined (unspecified) behaviors.
Import image tests `pkg/cli/importimage/importimage_test.go`	Removed assertions expecting `ImportModeLegacy` in many test cases; replaced with empty `TagImportPolicy{}` where appropriate; preserved explicit PreserveOriginal/Legacy cases.
New app CLI `pkg/cli/newapp/newapp.go`	Updated `--import-mode` flag help text to state behavior for Legacy, PreserveOriginal, and when unspecified (cluster determines).
New build CLI `pkg/cli/newbuild/newbuild.go`	Updated `--import-mode` flag help text to state behavior for Legacy, PreserveOriginal, and when unspecified (cluster determines).
Tag CLI and tests `pkg/cli/tag/tag.go`, `pkg/cli/tag/tag_test.go`	Updated `--import-mode` flag description; removed defaulting of empty `importMode` to Legacy in `Validate`; tests adjusted to expect empty `importMode` when unset.
Newapp helper `pkg/helpers/newapp/cmd/newapp.go`	Stopped coercing empty `ImportMode` to `ImportModeLegacy` in `AppConfig.Run()`; left `ImportMode` empty with comment that cluster/version will determine final mode.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-01-15T20:50:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Prashanth684
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

xiuwang · 2026-01-16T02:39:16Z

/verified by @xiuwang

openshift-ci-robot · 2026-01-16T02:39:29Z

@xiuwang: This PR has been marked as verified by @xiuwang.

Details

In response to this:

/verified by @xiuwang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ardaguclu · 2026-01-16T09:44:50Z

pkg/cli/importimage/importimage.go

 	cmd.Flags().BoolVar(&o.All, "all", o.All, "If true, import all tags from the provided source on creation or if --from is specified")
 	cmd.Flags().StringVar(&o.ReferencePolicy, "reference-policy", o.ReferencePolicy, "Allow to request pullthrough for external image when set to 'local'. Defaults to 'source'.")
-	cmd.Flags().StringVar(&o.ImportMode, "import-mode", o.ImportMode, "Imports the full manifest list of a tag when set to 'PreserveOriginal'. Defaults to 'Legacy'.")
+	cmd.Flags().StringVar(&o.ImportMode, "import-mode", o.ImportMode, "Imports the full manifest list of a tag when set to 'PreserveOriginal'. When set to 'Legacy', imports a single sub-manifest. When unspecified, the cluster determines the import mode.")


Wouldn't this be a breaking change?. Because we implicitly change a default behavior. So people who rely on Legacy behavior by default will start getting failures?.

The default behavior will only change for clusters installed with the multi-arch payload, where the expectation is that images are manifestlisted. That being said, we should document that on multi-arch clusters, the default behavior is importing manifestlisted images and to get the legacy behavior, --import-mode=Legacy needs to be added.

That makes sense. Let's update When unspecified, the cluster determines the import mode. to more explicit about the behavior, such as "When unspecified, if the cluster is single-arch, it will be Legacy; if the cluster is multi-arch, it will PreserveOriginal", etc.

…cified Today, we default to "Legacy" importmode when no option is specified. With the introduction of https://issues.redhat.com/browse/MULTIARCH-4552, the importmode is determined by the Cluster version's `desired.architecture` - which if set to "Multi", the import mode is PreserveOriginal else Legacy. Hence we don't need to default to Legacy all the time.

openshift-ci · 2026-01-17T03:09:13Z

@Prashanth684: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

xiuwang · 2026-01-19T03:47:03Z

/verified by @xiuwang

Test oc import-image, oc tag, oc new-app, oc new-build in multi arch clusters, without --import-mode specified, the import mode is default to PreserveOriginal, and no regression in single arch cluster, default to Legacy when not specify --import-mode

openshift-ci-robot · 2026-01-19T03:47:15Z

@xiuwang: This PR has been marked as verified by @xiuwang.

Details

In response to this:

/verified by @xiuwang

Test oc import-image, oc tag, oc new-app, oc new-build in multi arch clusters, without --import-mode specified, the import mode is default to PreserveOriginal, and no regression in single arch cluster, default to Legacy when not specify --import-mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ardaguclu · 2026-01-19T05:46:51Z

Just dropped a comment about documentation update. Other than that this looks good to me. Additionally, you need to fix invalid-jira label.

flavianmissi · 2026-02-04T11:39:06Z

/jira refresh

openshift-ci-robot · 2026-02-04T11:39:15Z

@flavianmissi: This pull request references Jira Issue OCPBUGS-73844, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci bot requested review from ardaguclu and ingvagabund January 15, 2026 20:50

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 16, 2026

ardaguclu reviewed Jan 16, 2026

View reviewed changes

Prashanth684 force-pushed the ocpbugs-73844 branch from 4b2b377 to 2ed2d79 Compare January 16, 2026 18:44

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jan 16, 2026

Prashanth684 force-pushed the ocpbugs-73844 branch from 2ed2d79 to 8a98fbc Compare January 16, 2026 23:21

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 19, 2026

openshift-ci bot requested a review from xiuwang February 4, 2026 11:39

Conversation

Prashanth684 commented Jan 15, 2026

Uh oh!

openshift-ci-robot commented Jan 15, 2026

Uh oh!

coderabbitai bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci bot commented Jan 15, 2026

Uh oh!

xiuwang commented Jan 16, 2026

Uh oh!

openshift-ci-robot commented Jan 16, 2026

Uh oh!

ardaguclu Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Prashanth684 Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

ardaguclu Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 17, 2026

Uh oh!

xiuwang commented Jan 19, 2026

Uh oh!

openshift-ci-robot commented Jan 19, 2026

Uh oh!

ardaguclu commented Jan 19, 2026

Uh oh!

flavianmissi commented Feb 4, 2026

Uh oh!

openshift-ci-robot commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai bot commented Jan 15, 2026 •

edited

Loading

ardaguclu Jan 16, 2026 •

edited

Loading