Remove unused printer column from VMFR CRD#2092
Remove unused printer column from VMFR CRD#2092PrasadJoshi12 wants to merge 1 commit intoopenshift:oadp-devfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: PrasadJoshi12 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 WalkthroughRemoved the Pod name printer column definition from two CRD (Custom Resource Definition) manifest files for VirtualMachineFileRestore. The extraPrinterColumn entry referencing Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/label ai-gen-bugfix |
|
@PrasadJoshi12: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@PrasadJoshi12: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
shubham-pampattiwar
left a comment
There was a problem hiding this comment.
IMO If this particular printer column is not being used then we should first decide whether we want to use it or not.
If yes, we want to use then Lets implement the controller changes needed for it.
If no, then the CRD needs to be changed in VMFR controller repo first and then make the change here in OADP Operator CRDs or else the CRDs would be out of sync.
Let me know what you guys think ? @PrasadJoshi12 @mpryc
Why the changes were made
Fixes:OADP-7460
How to test the changes made