Skip to content

Remove unused printer column from VMFR CRD#2092

Closed
PrasadJoshi12 wants to merge 1 commit intoopenshift:oadp-devfrom
PrasadJoshi12:vmfr
Closed

Remove unused printer column from VMFR CRD#2092
PrasadJoshi12 wants to merge 1 commit intoopenshift:oadp-devfrom
PrasadJoshi12:vmfr

Conversation

@PrasadJoshi12
Copy link
Contributor

Why the changes were made

Fixes:OADP-7460

How to test the changes made

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PrasadJoshi12
Once this PR has been reviewed and has the lgtm label, please assign shubham-pampattiwar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

Removed the Pod name printer column definition from two CRD (Custom Resource Definition) manifest files for VirtualMachineFileRestore. The extraPrinterColumn entry referencing status.fileServingInfo.podName was deleted, eliminating the Pod column from the OpenAPI schema display. No validation logic or other schema definitions were altered.

Changes

Cohort / File(s) Summary
CRD Printer Column Removal
bundle/manifests/oadp.openshift.io_virtualmachinefilerestores.yaml, config/crd/bases/oadp.openshift.io_virtualmachinefilerestores.yaml
Removed extraPrinterColumn entry for Pod name (status.fileServingInfo.podName) from additionalPrinterColumns in v1alpha1 schema.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PrasadJoshi12
Copy link
Contributor Author

/label ai-gen-bugfix

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2026

@PrasadJoshi12: The label(s) /label ai-gen-bugfix cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label ai-gen-bugfix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2026

@PrasadJoshi12: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/5.0-e2e-test-aws b3ff310 link false /test 5.0-e2e-test-aws
ci/prow/4.22-e2e-test-aws b3ff310 link false /test 4.22-e2e-test-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO If this particular printer column is not being used then we should first decide whether we want to use it or not.
If yes, we want to use then Lets implement the controller changes needed for it.
If no, then the CRD needs to be changed in VMFR controller repo first and then make the change here in OADP Operator CRDs or else the CRDs would be out of sync.
Let me know what you guys think ? @PrasadJoshi12 @mpryc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants