OU-1213: IncidentPage add error state #750
Conversation
|
@tremes: This pull request references OU-1213 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@tremes: This pull request references OU-1213 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| {loadError && <AccessDenied message={loadError.message} />} | ||
| {!loadError && alertsAreLoading && incidentsAreLoading ? ( |
There was a problem hiding this comment.
This makes the logic a bit hard to follow. Should we nest the ternary?
loadError ? <...> : (
alertsAreLoading && incidentsAreLoading ? <... > : <...>
)
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@tremes: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
This is adding use of
AccessDeniedto the IncidentPage when user doesn't have sufficient permissions.Previously it displayed only spinning spinner.
When this fix is applied, it looks like:
