OU-1040: feat: fix misaligned start dates by always loading 15 days

[rioloc]

This PR introduces the following change for the Incident component:

• The UI always load data for 15 days, still executing a query_range call per day
• IncidentsChart and AlertsChart have been updated to filter out, from the 15 days data, the datapoints which are not in currentTime - Last N Days

Before

By downloading only datapoints for "Last N Days" the displayed Start date would be relative to N days

After

Start displays an absolute date, even when Last N Days is far in the future rather than the start date

Limit

Start will always be limited to at max 15 days, because it is the max range we currently support. So if a metric is older than 15 days the Start time will always be set to 15 days ago, and will change/increase as the time goes on.

Video recording

recording.1.webm

[openshift-ci-robot]

@rioloc: This pull request references OU-1040 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR introduces the following change for the Incident component:

• The UI always load data for 15 days with a single query_range call, instead of having a call per day. This is achieved by changing the getIncidentsTimeRanges function.
• IncidentsChart and AlertsChart have been updated to filter out, from the 15 days data, the one which are not in currentTime - Last N Days

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@rioloc: This pull request references OU-1040 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR introduces the following change for the Incident component:

• The UI always load data for 15 days with a single query_range call, instead of having a call per day. This is achieved by changing the getIncidentsTimeRanges function.
• IncidentsChart and AlertsChart have been updated to filter out, from the 15 days data, the one which are not in currentTime - Last N Days

Before

By downloading only datapoints for "Last N Days" the displayed Start date would be relative to N days

After

Start displays an absolute date, even when Last N Days is far in the future rather than the start date

Video recording

recording.1.webm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rioloc: This pull request references OU-1040 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR introduces the following change for the Incident component:

• The UI always load data for 15 days, still executing a query_range call per day
• IncidentsChart and AlertsChart have been updated to filter out, from the 15 days data, the one which are not in currentTime - Last N Days

Before

By downloading only datapoints for "Last N Days" the displayed Start date would be relative to N days

After

Start displays an absolute date, even when Last N Days is far in the future rather than the start date

Video recording

recording.1.webm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rioloc: This pull request references OU-1040 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR introduces the following change for the Incident component:

• The UI always load data for 15 days, still executing a query_range call per day
• IncidentsChart and AlertsChart have been updated to filter out, from the 15 days data, the datapoints which are not in currentTime - Last N Days

Before

By downloading only datapoints for "Last N Days" the displayed Start date would be relative to N days

After

Start displays an absolute date, even when Last N Days is far in the future rather than the start date

Video recording

recording.1.webm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rioloc: This pull request references OU-1040 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR introduces the following change for the Incident component:

• The UI always load data for 15 days, still executing a query_range call per day
• IncidentsChart and AlertsChart have been updated to filter out, from the 15 days data, the datapoints which are not in currentTime - Last N Days

Before

By downloading only datapoints for "Last N Days" the displayed Start date would be relative to N days

After

Start displays an absolute date, even when Last N Days is far in the future rather than the start date

Limit

Start will always be limited to at max 15 days, because it is the max range we currently support. So if a metric is older than 15 days the Start time will always be set to 15 days ago, and will change/increase as the time goes on.

Video recording

recording.1.webm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[falox]

/lgtm

[falox]

/cc @DavidRajnoha

[rioloc]

/hold

[DavidRajnoha]

/test-incidents

[falox]

/lgtm cancel

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rioloc
Once this PR has been reviewed and has the lgtm label, please assign zhuje for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[DavidRajnoha]

/test e2e-incidents

[tremes]

Can the incident.values.length be equal to 0 (similar with alerts)? Should we check that?

[rioloc]

incident.values.length equal to 0 would mean having some incidents with no datapoints?

[tremes]

yes probably yes. So it's probably an edge case right? Not sure how likely it is though.

[openshift-ci]

@rioloc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-monitoring	2385dcc	link	false	/test e2e-monitoring
ci/prow/e2e-aws-ovn	2385dcc	link	true	/test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rioloc]

Closed due to alternative implementation in #749