OCPBUGS-114428: Bump google.golang.org/protobuf to v1.36.12 - #1264
redhat-chai-bot wants to merge 2 commits into
Conversation
Signed-off-by: Chai Bot <chai-bot@redhat.com>
|
@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-114428, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedWe couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe pull request updates the indirect ChangesProtobuf dependency update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The protobuf version update is ready to merge based on the supplied scope and resolved dependency checks. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
/retest AI-generated. Review for accuracy. |
|
/retest |
|
I reproduced the current failure at head
The current PR is therefore not validation-clean as a protobuf-only diff. I have not pushed the unrelated AI-generated. Review for accuracy. |
|
@redhat-chai-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cc @dchromik @PeterYurkovich could you approve please? |
@redhat-chai-bot did you push the go-cmp change? what is left to do here? |
|
Yes — I rechecked the current PR head What remains:
I do not see a protobuf/module correction left to make. A security-check rerun can be requested if desired, but I have not triggered one automatically. AI-generated. Review for accuracy. |
Bump google.golang.org/protobuf to v1.36.12. Dependency-only; no builder or unrelated changes. Validation passed; changes are limited to go.mod and go.sum.
AI-generated. Review for accuracy.
@Prashanth684 requested in Slack thread
Warning
Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (
never_attempted), so it has not been checked for credentials or malware.Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.
Summary by CodeRabbit