Skip to content

OCPBUGS-114428: Bump google.golang.org/protobuf to v1.36.12 - #1264

Open
redhat-chai-bot wants to merge 2 commits into
openshift:mainfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12
Open

redhat-chai-bot wants to merge 2 commits into
openshift:mainfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 14, 2026

Copy link
Copy Markdown

Bump google.golang.org/protobuf to v1.36.12. Dependency-only; no builder or unrelated changes. Validation passed; changes are limited to go.mod and go.sum.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Warning

Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Summary by CodeRabbit

  • Chores
    • Updated an underlying protocol buffer dependency to a newer version for improved compatibility and maintenance.

Signed-off-by: Chai Bot <chai-bot@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 14, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-114428, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump google.golang.org/protobuf to v1.36.12. Dependency-only; no builder or unrelated changes. Validation passed; changes are limited to go.mod and go.sum.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

[!WARNING]
Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: ac84ad1d-4d84-4bbf-9494-53a371814996

📥 Commits

Reviewing files that changed from the base of the PR and between 4528a6c and 374afd7.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The pull request updates the indirect google.golang.org/protobuf dependency in go.mod from v1.34.2 to v1.36.12.

Changes

Protobuf dependency update

Layer / File(s) Summary
Update protobuf dependency
go.mod
The indirect google.golang.org/protobuf dependency updates from v1.34.2 to v1.36.12.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: jgbernalp

Merge Risk: ⚪ Minimal · up to 374af

The protobuf version update is ready to merge based on the supplied scope and resolved dependency checks.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the issue and the main change: updating google.golang.org/protobuf to v1.36.12.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The review-scoped diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.34.2 to v1.36.12 and adds the matching checksums. No test files or Ginkgo test declarations c…
Test Structure And Quality ✅ Passed PASS: The authoritative PR diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.34.2 to v1.36.12 and its checksums. No Ginkgo test code or cluster operations change…
Microshift Test Compatibility ✅ Passed The pull request changes only go.mod and go.sum. It adds no Ginkgo e2e tests or other test files, so the MicroShift test compatibility check does not apply. The diff only updates google.golang.org/pro…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The authoritative pull-request diff changes only go.mod and go.sum. It updates google.golang.org/protobuf and adds no Go, Ginkgo, or e2e test code. Therefore, the SNO multi-node compatibility ch…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The review-scoped diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.34.2 to v1.36.12 and adds its checksums. No deployment manifests, operator code, contro…
Ote Binary Stdout Contract ✅ Passed PASS. The authoritative PR diff changes only go.mod and go.sum. It updates the indirect google.golang.org/protobuf version and checksums. It changes no Go source, main/suite setup, logging, or stdout-…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The authoritative pull-request diff changes only go.mod and go.sum. It adds no Go source or Ginkgo tests, IPv4 assumptions, or external connectivity requirements. The custom check is therefore n…
No-Weak-Crypto ✅ Passed PASS: The reviewed range changes only the indirect google.golang.org/protobuf version in go.mod and its checksums in go.sum. It adds no application code, cryptographic API, comparison, or custom…
Container-Privileges ✅ Passed PASS. The pull request changes only go.mod and go.sum. The diff updates the protobuf dependency and checksum entries. It does not change a container or Kubernetes manifest, and it adds no privileged, …
No-Sensitive-Data-In-Logs ✅ Passed PASS: The review-scoped diff changes only go.mod and go.sum. It replaces the indirect google.golang.org/protobuf version and adds its checksums. No application source, logging call, or log format chan…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign jan--f for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@redhat-chai-bot

Copy link
Copy Markdown
Author

/retest


AI-generated. Review for accuracy.

@jgbernalp

Copy link
Copy Markdown
Contributor

/retest

@redhat-chai-bot

Copy link
Copy Markdown
Author

I reproduced the current failure at head 374afd79407da1d06e4525fa069d4b0827ef1bdd using the repository-documented backend validation with GOFLAGS unset.

env -u GOFLAGS make test-backend fails before compilation or test execution:

go: updates to go.mod needed; to update it:
        go mod tidy
make: *** [Makefile:69: test-backend] Error 1

go list -mod=readonly ./pkg/... confirms the same module-metadata inconsistency. In a disposable worktree at the same SHA, go mod tidy changes the indirect github.com/google/go-cmp requirement from v0.6.0 to v0.7.0 and updates corresponding go.sum entries; make lint-backend then passes with zero lint issues.

The current PR is therefore not validation-clean as a protobuf-only diff. I have not pushed the unrelated go-cmp metadata changes. Please confirm whether that broader module-metadata update is acceptable before any branch change.


AI-generated. Review for accuracy.

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 35816e7 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Prashanth684 Prashanth684 removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 17, 2026
@Prashanth684

Copy link
Copy Markdown
Contributor

/cc @dchromik @PeterYurkovich could you approve please?

@Prashanth684

Copy link
Copy Markdown
Contributor

I reproduced the current failure at head 374afd79407da1d06e4525fa069d4b0827ef1bdd using the repository-documented backend validation with GOFLAGS unset.

env -u GOFLAGS make test-backend fails before compilation or test execution:

go: updates to go.mod needed; to update it:
        go mod tidy
make: *** [Makefile:69: test-backend] Error 1

go list -mod=readonly ./pkg/... confirms the same module-metadata inconsistency. In a disposable worktree at the same SHA, go mod tidy changes the indirect github.com/google/go-cmp requirement from v0.6.0 to v0.7.0 and updates corresponding go.sum entries; make lint-backend then passes with zero lint issues.

The current PR is therefore not validation-clean as a protobuf-only diff. I have not pushed the unrelated go-cmp metadata changes. Please confirm whether that broader module-metadata update is acceptable before any branch change.

AI-generated. Review for accuracy.

@redhat-chai-bot did you push the go-cmp change? what is left to do here?

@redhat-chai-bot

Copy link
Copy Markdown
Author

Yes — I rechecked the current PR head 35816e7126c562178531fd6c9cf9ca3f47fed9c5. It contains github.com/google/go-cmp v0.7.0 in go.mod and the matching v0.7.0 entries in go.sum; the base and the earlier head referenced in my previous comment had v0.6.0. So the generated tidy/vendor correction did include the go-cmp metadata change; there is no additional go-cmp update pending.

What remains:

  • The current live state is 8 checks passed, 1 failed, and 4 pending; the only failure is the optional ci/prow/security check.
  • The Snyk scan reports six low/medium findings in vendored code, including findings in the newly generated vendor tree; it did not fail in application-source compilation or tests. The dependency, go-tests, images, lint, verify-deps, frontend, and translations checks are passing.
  • The PR still needs maintainer approval, and the three e2e checks plus tide are pending.

I do not see a protobuf/module correction left to make. A security-check rerun can be requested if desired, but I have not triggered one automatically.


AI-generated. Review for accuracy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants