Skip to content

USHIFT-7033: RPM test suites: set release#6738

Open
pmtk wants to merge 1 commit into
openshift:mainfrom
pmtk:rpm-set-release/main
Open

USHIFT-7033: RPM test suites: set release#6738
pmtk wants to merge 1 commit into
openshift:mainfrom
pmtk:rpm-set-release/main

Conversation

@pmtk
Copy link
Copy Markdown
Member

@pmtk pmtk commented May 26, 2026

Summary by CodeRabbit

  • Tests
    • Updated test configurations to explicitly set target RHEL release versions (9.8 and 10.2) before executing RPM package management test suites across multiple test scenarios.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 26, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 26, 2026

@pmtk: This pull request references USHIFT-7033 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: dc5f6b15-b3f7-4e26-82a5-6c9829346631

📥 Commits

Reviewing files that changed from the base of the PR and between 7424765 and 33de2af.

📒 Files selected for processing (5)
  • test/scenarios-bootc/el10/presubmits/el102-src@rpm-install.sh
  • test/scenarios-bootc/el9/presubmits/el98-src@rpm-install.sh
  • test/scenarios/presubmits/el98-src@rpm-install.sh.disabled
  • test/scenarios/releases/el98@rpm-standard1.sh
  • test/scenarios/releases/el98@rpm-standard2.sh

Walkthrough

This PR adds a single subscription-manager release version setting command to five test scenario scripts. Each script sets the appropriate RHEL release (9.8 or 10.2) on host1 during test preparation, before repository configuration and test suite execution.

Changes

Subscription-manager Release Setup

Layer / File(s) Summary
Add subscription-manager release settings to test scenarios
test/scenarios-bootc/el10/presubmits/el102-src@rpm-install.sh, test/scenarios-bootc/el9/presubmits/el98-src@rpm-install.sh, test/scenarios/presubmits/el98-src@rpm-install.sh.disabled, test/scenarios/releases/el98@rpm-standard1.sh, test/scenarios/releases/el98@rpm-standard2.sh
Each test scenario script now explicitly sets the subscription-manager release version for its target RHEL release (10.2 or 9.8) on host1 within scenario_run_tests() before repository enabling and test execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • ggiguash
  • eslutsky
  • copejon
🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding subscription-manager release settings across multiple RPM test suites in the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only shell scripts (.sh files) containing no Ginkgo test definitions (It, Describe, Context, When). The check is not applicable to this PR.
Test Structure And Quality ✅ Passed PR modifies only bash shell scripts for test scenario configuration, not Ginkgo test code. Custom check for Ginkgo test structure is not applicable.
Microshift Test Compatibility ✅ Passed PR modifies shell test setup scripts only, not Ginkgo e2e tests. Check is inapplicable: no test code using OpenShift APIs added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies bash shell scripts; no Ginkgo e2e tests added. The check applies only to new Ginkgo tests, which are not present.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only test scenario scripts, not deployment manifests or operator code. No Kubernetes scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies shell test scenario scripts; no Go binaries, main functions, or OTE framework code are modified. The check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only bash shell scripts using Robot Framework, not Ginkgo e2e tests. Check is specific to Ginkgo tests (It/Describe/Context/When patterns), which don't exist here.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2026
@pmtk pmtk marked this pull request as ready for review May 26, 2026 14:28
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2026
@openshift-ci openshift-ci Bot requested review from eslutsky and pacevedom May 26, 2026 14:30
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

@pmtk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-release-arm 33de2af link true /test e2e-aws-tests-release-arm
ci/prow/e2e-aws-tests-release 33de2af link true /test e2e-aws-tests-release

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants