AGENT-1522: bump InternalReleaseImage to v1 (and simply version dependency) - #6280
Merged
openshift-merge-bot[bot] merged 7 commits intoJul 10, 2026
Conversation
Contributor
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@andfasano: This pull request references AGENT-1522 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (470)
📒 Files selected for processing (27)
🚧 Files skipped from review as they are similar to previous changes (27)
WalkthroughThis PR migrates InternalReleaseImage clients, informers, controllers, bootstrap handling, daemon logic, tests, admission policy references, and related dependency versions from ChangesInternalReleaseImage v1 migration
Estimated code review effort: 4 (Complex) | ~60 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
|
Contributor
Author
|
/test ? |
Contributor
Author
|
/test e2e-agent-compact-ipv4 |
Contributor
Author
|
/test e2e-agent-compact-ipv4-iso-no-registry |
1 similar comment
Contributor
Author
|
/test e2e-agent-compact-ipv4-iso-no-registry |
andfasano
force-pushed
the
bump-iri-to-v1-and-simplify-version-dependency
branch
from
July 7, 2026 18:18
1926ec7 to
706ea0d
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 405: The current golang.org/x/crypto version is still within the affected
SSH range, so update the dependency in go.mod to a release past the SSH fix
threshold. Make sure the replacement version is reflected consistently for the
vendored ssh package and any imports from golang.org/x/crypto/ssh used by
ssh_client.go and mco_password.go, then refresh vendoring so the safe version is
picked up.
In `@pkg/daemon/internalreleaseimage/internalreleaseimage_manager.go`:
- Around line 179-187: The log message in updateInternalReleaseImage includes an
accidental package prefix, so update the klog.V(4).Infof string in
Manager.updateInternalReleaseImage to match the other InternalReleaseImage log
messages and remove the stray mcfgv1. prefix while keeping the same update
context and enqueueInternalReleaseImage behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Contributor
|
/retest-required |
Contributor
Author
|
/test e2e-agent-compact-ipv4-iso-no-registry |
Contributor
Author
|
/test bootstrap-unit |
Contributor
Author
|
/test bootstrap-unit |
4 similar comments
Contributor
Author
|
/test bootstrap-unit |
Contributor
Author
|
/test bootstrap-unit |
Contributor
Author
|
/test bootstrap-unit |
Contributor
Author
|
/test bootstrap-unit |
Contributor
Author
|
/test e2e-agent-compact-ipv4-iso-no-registry |
1 similar comment
Contributor
Author
|
/test e2e-agent-compact-ipv4-iso-no-registry |
Contributor
|
/lgtm |
Contributor
|
Scheduling tests matching the |
andfasano
force-pushed
the
bump-iri-to-v1-and-simplify-version-dependency
branch
from
July 9, 2026 07:28
5705d21 to
89bd517
Compare
latest available to fetch InternalReleaseImage v1
andfasano
force-pushed
the
bump-iri-to-v1-and-simplify-version-dependency
branch
from
July 10, 2026 06:03
05799b2 to
52da16f
Compare
openshift-ci-robot
removed
the
verified
openshift-ci
Bot
removed
lgtm
Contributor
Author
|
Resolved conflicts in go.mod (from recently merged #6286) /test e2e-agent-compact-ipv4-iso-no-registry |
Contributor
|
@andfasano: This pull request references AGENT-1522 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
/lgtm |
Contributor
|
Scheduling tests matching the |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, bfournie, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest-required |
Contributor
|
/test e2e-aws-ovn |
Contributor
Author
|
/verified by @andfasano |
openshift-ci-robot
added
the
verified
Contributor
|
@andfasano: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
@yuqi-zhang @djoshy @pablintino would be possible to override the |
Contributor
|
Just as a note, with #6284 merging, I think this is still building a payload with the old logic, so let's try rebasing and see if it works before override |
Contributor
|
/override ci/prow/e2e-aws-ovn-upgrade This is failing for unrelated reasons it looks like, and should be safe enough with a previous passing test (although that was some versions ago) plus the fact that this just does an API bump Will monitor post-merge in case this is causing problems |
Contributor
|
@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-aws-ovn-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
@andfasano: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch merges #6174 and @zaneb branch bootstrap-iri-v1.
Apart bumping the IRI version to v1, the main goal is to allow a smoother version transition, thus the changes in the Bootstrap command and Renderer (where essentially the IRI object wasn't used at all, only its presence was relevant)
Summary by CodeRabbit
machineconfiguration/v1API across the operator, daemon, controller bootstrap, and e2e coverage.v1.machineconfiguration.openshift.io/v1.v1alpha1vsv1.