OCPBUGS-86332: remove tests using base images older than 4.13

[sergiordlr]

- What I did

Remove the tests using base images older than 4.13.

Images older than 4.13 are not going to receive more fixes. Hence, we need to remove the tests using them.

A new test case was added to test that the oldest supported version (4.13) can be used without problems.

• g.It("[PolarionID:89097][OTP] Scaleup using 4.13 cloud image",

- How to verify it

Tests using older images should not run in the automation

Summary by CodeRabbit

• Tests
  • Refined test suite: removed older bootimage-based scaleup and certificate-rotation cases, consolidated scaleup coverage to a single cloud-image case, and updated platform applicability. Added comments documenting the bootimage cutoff and listing removed references.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@sergiordlr: This pull request references Jira Issue OCPBUGS-86332, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did

Remove the tests using base images older than 4.13.

Images older than 4.13 are not going to receive more fixes. Hence, we need to remove the tests using them.

- How to verify it

Tests using older images should not run in the automation

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Removes legacy bootimage-related Ginkgo tests and consolidates scale tests: test setup now only initializes the worker MCP; multiple scaleup cases are replaced by a single "Scaleup using 4.13 cloud image" test with updated platform skips; the PolarionID:80403 test was removed and replaced by comments referencing OCPBUGS-86332.

Changes

Boot Image Test Exclusion and Cleanup

Layer / File(s)	Summary
Reduce JustBeforeEach setup test/extended-priv/mco_scale.go	JustBeforeEach now only declares and assigns wMcp (worker MachineConfigPool), removing prior mMcp and machineConfiguration initialization.
Replace legacy scale tests with single 4.13 case test/extended-priv/mco_scale.go	Replaces multiple g.It scaleup cases (4.1, 4.3, 4.12 cloud images and the prior 2.2.0 ignition case) with one Scaleup using 4.13 cloud image test marked for Platform:aws, Platform:gce, Platform:vsphere, and adds a bootimage-policy comment noting the cutoff (starting 4.22).
Remove PolarionID:80403 and add bugfix comment test/extended-priv/mco_security.go	Deletes the PolarionID:80403 MCS certificate rotation test and adds comments referencing OCPBUGS-86332 and the bootimage cutoff beginning in 4.22.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

lgtm

Suggested reviewers

• dkhater-redhat

🚥 Pre-merge checks | ✅ 8 | ❌ 4

❌ Failed checks (4 warnings)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	New 4.13 scale test reaches getRHCOSImagesInfo which performs http.Get to raw.githubusercontent.com, but lacks disconnected-cluster skip protection as noted in review comments and codebase patterns.	Add g.Label("Skipped:Disconnected") to the new 4.13 test, or implement skipTestIfDisconnected() check within SimpleScaleUPTest before calling getRHCOSImagesInfo.
Microshift Test Compatibility	⚠️ Warning	New test uses machine.openshift.io and machineconfiguration.openshift.io APIs unavailable on MicroShift without protection ([apigroup] tag, [Skipped:MicroShift] label, or IsMicroShiftCluster check).	Add [apigroup:machine.openshift.io] tag to test name, or add [Skipped:MicroShift] label, or guard with exutil.IsMicroShiftCluster() check per instructions.
Single Node Openshift (Sno) Test Compatibility	⚠️ Warning	New test "Scaleup using 4.13 cloud image" at line 83 scales worker nodes; lacks SNO compatibility protection ([Skipped:SingleReplicaTopology] label or exutil.IsSingleNode() check).	Add [Skipped:SingleReplicaTopology] label to test name, or add exutil.IsSingleNode() check with skip; SNO CI jobs automatically skip labeled tests.
Ipv6 And Disconnected Network Test Compatibility	⚠️ Warning	The new test requires external connectivity: calls cloneMachineSet() → getRHCOSImagesInfo() which performs http.Get() to raw.githubusercontent.com, failing in disconnected IPv6-only environments.	Add [Skipped:Disconnected] to test name or skip on disconnected clusters. Implement internal RHCOS metadata caching to avoid external URLs.

✅ Passed checks (8 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly and specifically describes the main change: removing tests that use base images older than 4.13, which is consistent with the changeset modifications to both test files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Test names contain no dynamic content; new test uses static strings and version numbers only, with no generated identifiers, timestamps, node/pod names, or UUIDs.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR removes test cases using base images older than 4.13, modifying only test files. No new deployment manifests, operator code, or scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	All changes are within Ginkgo test blocks. No process-level code, init functions, or direct stdout writes were added. Comments and test removals pose no contract violation.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

test/extended-priv/mco_security.go (1)

944-944: 💤 Low value

Consider consistent spacing in Exclude labels for readability.

This file uses mixed patterns for exclude labels: "Exclude:CategoryName" for category-style names (line 454) and "Exclude: descriptive sentence" for full sentences (lines 551, 638). The new label is a full sentence but uses the no-space pattern. For consistency with other descriptive exclude messages, consider "Exclude: Starting in 4.22..." (with space after colon).

Optional style consistency fix

-g.It("[PolarionID:80403][OTP] Validate MCS Certificate Rotation with 2.2.0 User-Data Secret [Disruptive]", g.Label("Platform:aws", "Exclude:Starting in 4.22 we will no longer fix any bootimage related bugs from bootimages earlier than 4.13"), func() {
+g.It("[PolarionID:80403][OTP] Validate MCS Certificate Rotation with 2.2.0 User-Data Secret [Disruptive]", g.Label("Platform:aws", "Exclude: Starting in 4.22 we will no longer fix any bootimage related bugs from bootimages earlier than 4.13"), func() {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/extended-priv/mco_security.go` at line 944, The Exclude label on the
g.It test invocation uses "Exclude:Starting in 4.22..." without a space after
the colon; update the label in the g.It(...) call so it matches the project's
descriptive exclude pattern by changing it to "Exclude: Starting in 4.22..."
(ensure the string inside the g.It(...) labels array is adjusted accordingly) so
spacing is consistent with other tests like the ones at lines referencing other
Exclude messages.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@test/extended-priv/mco_security.go`:
- Line 944: The Exclude label on the g.It test invocation uses "Exclude:Starting
in 4.22..." without a space after the colon; update the label in the g.It(...)
call so it matches the project's descriptive exclude pattern by changing it to
"Exclude: Starting in 4.22..." (ensure the string inside the g.It(...) labels
array is adjusted accordingly) so spacing is consistent with other tests like
the ones at lines referencing other Exclude messages.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e148bc7b-0464-47d5-ae97-88da5e7ba527

📥 Commits

Reviewing files that changed from the base of the PR and between 13d8044 and d7c369b.

📒 Files selected for processing (2)

• test/extended-priv/mco_scale.go
• test/extended-priv/mco_security.go

[sergiordlr]

/retest

Manually triggered executions

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-vsphere-mco-tp-longduration/2057494415009648640
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-fips-proxy-longduration/2057494449457467392

[isabella-janssen]

/lgtm
/jira refresh

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-86332, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/lgtm
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

[openshift-ci-robot]

@sergiordlr: This pull request references Jira Issue OCPBUGS-86332, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

- What I did

Remove the tests using base images older than 4.13.

Images older than 4.13 are not going to receive more fixes. Hence, we need to remove the tests using them.

A new test case was added to test that the oldest supported version (4.13) can be used without problems.

• g.It("[PolarionID:89097][OTP] Scaleup using 4.13 cloud image",

- How to verify it

Tests using older images should not run in the automation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/extended-priv/mco_scale.go`:
- Around line 83-91: This new 4.13 scale test calls getRHCOSImagesInfo which
does an http.Get to raw.githubusercontent.com, so add a disconnected-cluster
guard before running SimpleScaleUPTest: detect a disconnected environment (reuse
existing helper like skipIfDisconnectedCluster or implement a short check that
verifies external HTTP access) and call it after
skipTestIfSupportedPlatformNotMatched and before SimpleScaleUPTest;
alternatively, change SimpleScaleUPTest to accept an internal RHCOS metadata
source or flag to avoid getRHCOSImagesInfo in disconnected setups (refer to
getRHCOSImagesInfo and SimpleScaleUPTest to locate the change).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 35e51932-4e9f-480a-80d4-ad22afdb101a

📥 Commits

Reviewing files that changed from the base of the PR and between d7c369b and 70e8d89.

📒 Files selected for processing (2)

• test/extended-priv/mco_scale.go
• test/extended-priv/mco_security.go

[pablintino]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, pablintino, sergiordlr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [isabella-janssen,pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sergiordlr]

We manually executed the new test with 4.13 base image

  {
    "name": "[sig-mco][Suite:openshift/machine-config-operator/longduration][Serial][Disruptive] MCO scale [PolarionID:89097][OTP] Scaleup using 4.13 cloud image",
    "lifecycle": "blocking",
    "duration": 639402,
    "startTime": "2026-05-25 10:52:35.963693 UTC",
    "endTime": "2026-05-25 11:03:15.366259 UTC",
    "result": "passed",

/verified by @sergiordlr

[openshift-ci-robot]

@sergiordlr: This PR has been marked as verified by @sergiordlr.

Details

In response to this:

We manually executed the new test with 4.13 base image

 {
   "name": "[sig-mco][Suite:openshift/machine-config-operator/longduration][Serial][Disruptive] MCO scale [PolarionID:89097][OTP] Scaleup using 4.13 cloud image",
   "lifecycle": "blocking",
   "duration": 639402,
   "startTime": "2026-05-25 10:52:35.963693 UTC",
   "endTime": "2026-05-25 11:03:15.366259 UTC",
   "result": "passed",

/verified by @sergiordlr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@sergiordlr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@sergiordlr: Jira Issue Verification Checks: Jira Issue OCPBUGS-86332
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-86332 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

- What I did

Remove the tests using base images older than 4.13.

Images older than 4.13 are not going to receive more fixes. Hence, we need to remove the tests using them.

A new test case was added to test that the oldest supported version (4.13) can be used without problems.

• g.It("[PolarionID:89097][OTP] Scaleup using 4.13 cloud image",

- How to verify it

Tests using older images should not run in the automation

Summary by CodeRabbit

• Tests
• Refined test suite: removed older bootimage-based scaleup and certificate-rotation cases, consolidated scaleup coverage to a single cloud-image case, and updated platform applicability. Added comments documenting the bootimage cutoff and listing removed references.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in release 5.0.0-0.nightly-2026-05-27-134409

[sergiordlr]

/cherry-pick release-4.22

[openshift-cherrypick-robot]

@sergiordlr: new pull request created: #6104

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.