OCPNODE-3880: Add criocredentialproviderconfig event handler#5487
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
865fa47 to
8a072e4
Compare
|
/test all |
|
@QiWang19: This pull request references OCPNODE-3880 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
8a072e4 to
75dfbfd
Compare
|
/test all |
75dfbfd to
511fde6
Compare
|
/test all |
511fde6 to
0ff0fe8
Compare
|
/test all |
0ff0fe8 to
5d5008b
Compare
|
/test all |
5d5008b to
7d79743
Compare
147fbf2 to
3027d6a
Compare
|
/test all |
3027d6a to
9a477a8
Compare
|
/test all |
9a477a8 to
58fa6bc
Compare
|
@QiWang19: This pull request references OCPNODE-3880 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@QiWang19: This pull request references OCPNODE-3880 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test all |
|
/lgtm |
|
/retest-required |
| ctrl.syncCRIOCredentialProviderConfigStatusOnly(err, apicfgv1alpha1.ConditionTypeMachineConfigRendered, apicfgv1alpha1.ReasonMachineConfigRenderingFailed, "could not generate CRIOCredentialProvider Ignition config: %v", err) | ||
| return err | ||
| } | ||
| if len(overlappedEntries) > 0 { |
There was a problem hiding this comment.
When overlaps exist, this sets ConditionTypeValidated to False with ReasonConfigurationPartiallyApplied. If the user later removes the conflicting entries from the CR, no code path resets this condition back to True. The stale warning persists indefinitely.
Do we need to add an else branch (or an unconditional call after the loop) that sets ConditionTypeValidated to True when len(overlappedEntries) == 0?
| builtInLabelKey = "machineconfiguration.openshift.io/mco-built-in" | ||
| configMapName = "crio-default-container-runtime" | ||
| forceSyncOnUpgrade = "force-sync-on-upgrade" | ||
| genericCredProviderConfigPath = "/etc/kubernetes/credential-providers/generic-credential-provider.yaml" |
There was a problem hiding this comment.
Nit: kubeletCrioImageCredProviderConfPath duplicates constants.KubeletCrioImageCredProviderConfPath from pkg/daemon/constants/constants.go. Consider using the constants package instead of redefining the value here.
c8f5763 to
c953926
Compare
c953926 to
18b41eb
Compare
|
/retest |
|
/verified by @QiWang19 |
|
@QiWang19: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@isabella-janssen could you take a look? |
|
/approve |
|
/retest-required |
|
The failure is related to the bootstrap being run with techpreview enabled. When this feature gate is enabled, the container runtime config controller attempts to watch for TechpreviewNoUpgrade resource |
|
/retest-required |
|
rebaesd to resolve the conflict. |
|
/test bootstrap-unit |
1 similar comment
|
/test bootstrap-unit |
Signed-off-by: Qi Wang <qiwan@redhat.com>
|
/test bootstrap-unit |
|
/verified by @QiWang19 |
|
@QiWang19: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/test e2e-openstack |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, QiWang19, saschagrunert, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@QiWang19: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- What I did
Implement criocredentialprovierconfig that is used by
crio-credential-providerplugin to fetch private mirror image pull secrets from the secret object.The handler creates
97-pool-generated-credentialproviderconfigto rollout configurations to file/etc/kubernetes/credential-providers/[platform]-credential-provider.yaml.workflow: https://github.com/openshift/enhancements/blob/master/enhancements/api-review/criocredentialproviderconfig-for-namespace-scoped-mirror-authentication.md#workflow-description
- How to verify it
clusterCRIOCredentialProviderConfig resource, file updated with a new sectionname: crio-credential-providernamespace:mynamespacecontainers.imageis from mirrorsourceregistryjournalctl _COMM=crio-credentialon the scheduled node- Description for the changelog
Summary by CodeRabbit
New Features
Chores / Defaults
Security & Permissions
Tests