OCPEDGE-2238: feat(tests): add e2e tests for device class deletion

[qJkee]

Summary by CodeRabbit

• Tests
  • Enhanced test coverage for device class removal operations
  • Validates cluster stability and resource cleanup after device class removal
  • Confirms protection against removing required device classes

[openshift-ci-robot]

@qJkee: This pull request references OCPEDGE-2238 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [qJkee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.53%. Comparing base (b1c27ff) to head (e1013d0).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1722      +/-   ##
==========================================
- Coverage   48.69%   48.53%   -0.17%     
==========================================
  Files          52       52              
  Lines        3709     3709              
==========================================
- Hits         1806     1800       -6     
- Misses       1753     1756       +3     
- Partials      150      153       +3     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ef7ace51-1a3e-4eac-b976-8a5d074c59f4

📥 Commits

Reviewing files that changed from the base of the PR and between d5880ba and 2476677.

📒 Files selected for processing (2)

• test/e2e/device_class_removal_test.go
• test/e2e/lvm_suite_test.go

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

---

Walkthrough

A new end-to-end test suite for device class removal is introduced, verifying that non-default device classes can be removed from LVM clusters, storage-related resources are properly cleaned up, and API validation prevents removal of default device classes.

Changes

Cohort / File(s)	Summary
Device Class Removal E2E Tests test/e2e/device_class_removal_test.go	New e2e test file with cleanup verification tests (device class removal and storage cleanup) and webhook validation tests (API constraint checks for default device class removal). Tests handle topology-based skips, thin-pool scenarios, and cluster readiness validation.
LVM E2E Suite Integration test/e2e/lvm_suite_test.go	Registers the new "Device Class Removal" test section to the Ginkgo test suite to run serially.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[qJkee]

/retest

[openshift-ci-robot]

@qJkee: This pull request references OCPEDGE-2238 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

• Tests

• Enhanced test coverage for device class removal operations
• Validates cluster stability and resource cleanup after device class removal
• Confirms protection against removing required device classes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.