OCPBUGS-78694: [release-4.20]: openstack: Disable LoadBalancer in cloud config when Octavia is unavailable by eshulman2 · Pull Request #10401 · openshift/installer

eshulman2 · 2026-03-17T10:23:34Z

When Octavia (load-balancer) endpoint is not available in the OpenStack service catalog, explicitly set [LoadBalancer] enabled = false in the cloud provider config. This prevents the Cloud Controller Manager from crashing on startup due to an upstream change in cloud-provider-openstack that changed error handling from klog.Errorf to klog.Fatalf when the LoadBalancer client cannot be created.

The fix uses the same pattern already established in the cluster destroy code (pkg/destroy/openstack/openstack.go) to detect Octavia availability by checking for gophercloud.ErrEndpointNotFound.

Fixes: https://issues.redhat.com/browse/OCPBUGS-64842
backports #10326

coderabbitai · 2026-03-17T10:23:42Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e803384b-02c6-4e6a-8551-db52a5442b39

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…ilable When Octavia (load-balancer) endpoint is not available in the OpenStack service catalog, explicitly set [LoadBalancer] enabled = false in the cloud provider config. This prevents the Cloud Controller Manager from crashing on startup due to an upstream change in cloud-provider-openstack that changed error handling from klog.Errorf to klog.Fatalf when the LoadBalancer client cannot be created. The fix uses the same pattern already established in the cluster destroy code (pkg/destroy/openstack/openstack.go) to detect Octavia availability by checking for gophercloud.ErrEndpointNotFound. Fixes: https://issues.redhat.com/browse/OCPBUGS-64842 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

eshulman2 · 2026-03-17T14:05:10Z

/jira

openshift-ci-robot · 2026-03-17T14:25:06Z

@eshulman2: This pull request references Jira Issue OCPBUGS-78694, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-78694 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When Octavia (load-balancer) endpoint is not available in the OpenStack service catalog, explicitly set [LoadBalancer] enabled = false in the cloud provider config. This prevents the Cloud Controller Manager from crashing on startup due to an upstream change in cloud-provider-openstack that changed error handling from klog.Errorf to klog.Fatalf when the LoadBalancer client cannot be created.

The fix uses the same pattern already established in the cluster destroy code (pkg/destroy/openstack/openstack.go) to detect Octavia availability by checking for gophercloud.ErrEndpointNotFound.

Fixes: https://issues.redhat.com/browse/OCPBUGS-64842

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

eshulman2 · 2026-03-17T14:30:54Z

/jira refresh

openshift-ci-robot · 2026-03-17T14:31:00Z

@eshulman2: This pull request references Jira Issue OCPBUGS-78694, which is invalid:

expected dependent Jira Issue OCPBUGS-78696 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

stephenfin · 2026-03-18T15:08:29Z

/test e2e-openstack-ovn

stephenfin

/lgtm
/approve
/label backport-risk-assessed

openshift-ci · 2026-03-18T15:13:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/asset/manifests/openstack/OWNERS~~ [stephenfin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stephenfin · 2026-03-19T12:07:35Z

/test e2e-openstack-ovn

stephenfin · 2026-03-19T12:12:14Z

/test e2e-openstack-ovn

mandre · 2026-03-19T14:15:39Z

/retitle OCPBUGS-78694: [release-4.20]: openstack: Disable LoadBalancer in cloud config when Octavia is unavailable

eshulman2 · 2026-03-23T19:42:56Z

/jira refresh

openshift-ci-robot · 2026-03-23T19:43:04Z

@eshulman2: This pull request references Jira Issue OCPBUGS-78694, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-78696 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-78696 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

stephenfin · 2026-03-24T09:50:41Z

/test e2e-openstack-ovn

eshulman2 · 2026-03-24T10:00:14Z

/verified later

openshift-ci-robot · 2026-03-24T10:00:18Z

@eshulman2: /verified later <@username> requires at least one GitHub @username to be specified (it can be a comma delimited list). It indicates the engineer(s) that will be performing the verification. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

eshulman2 · 2026-03-24T15:39:00Z

/verified later eshulman

openshift-ci-robot · 2026-03-24T15:39:12Z

@eshulman2: Jira verification commands are restricted to collaborators for this repo.

Details

In response to this:

/verified later eshulman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

eshulman2 · 2026-03-25T10:14:26Z

/verified later eshulman

openshift-ci-robot · 2026-03-25T10:14:37Z

@eshulman2: Jira verification commands are restricted to collaborators for this repo.

Details

In response to this:

/verified later eshulman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

stephenfin · 2026-03-25T10:46:08Z

/verified later eshulman2

openshift-ci-robot · 2026-03-25T10:46:21Z

@stephenfin: Only users can be targets for the /verified later command.

Details

In response to this:

/verified later eshulman2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

stephenfin · 2026-03-25T10:47:13Z

/verified later eshulman

I'm guessing we need #10434 first but let's see

openshift-ci-robot · 2026-03-25T10:47:25Z

@stephenfin: Only users can be targets for the /verified later command.

Details

In response to this:

/verified later eshulman

I'm guessing we need #10434 first but let's see

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

eshulman2 · 2026-03-25T14:09:43Z

/verified later eshulman2

openshift-ci-robot · 2026-03-25T14:09:54Z

@eshulman2: Jira verification commands are restricted to collaborators for this repo.

Details

In response to this:

/verified later eshulman2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

stephenfin · 2026-03-25T14:56:48Z

/verified later eshulman2

openshift-ci-robot · 2026-03-25T14:57:00Z

@stephenfin: Only users can be targets for the /verified later command.

Details

In response to this:

/verified later eshulman2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

stephenfin · 2026-03-25T17:14:00Z

/verified later @stephenfin

Will re-assign later.

openshift-ci-robot · 2026-03-25T17:14:15Z

@stephenfin: This PR has been marked to be verified later by @stephenfin.

Details

In response to this:

/verified later @stephenfin

Will re-assign later.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2026-03-25T20:04:46Z

/test e2e-openstack-ovn

openshift-ci-robot · 2026-03-26T15:04:38Z

/retest-required

Remaining retests: 0 against base HEAD 86a146b and 2 for PR HEAD e99ff60 in total

sadasu · 2026-03-30T12:41:59Z

/override ci/prow/e2e-openstack-ovn

sadasu · 2026-03-30T12:44:36Z

/override e2e-openstack-ovn

openshift-ci · 2026-03-30T12:45:43Z

@sadasu: Overrode contexts on behalf of sadasu: ci/prow/e2e-openstack-ovn

Details

In response to this:

/override ci/prow/e2e-openstack-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-03-30T12:47:17Z

@sadasu: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

e2e-openstack-ovn

Only the following failed contexts/checkruns were expected:

CodeRabbit
ci/prow/artifacts-images
ci/prow/e2e-aws-ovn
ci/prow/e2e-openstack-nfv-intel
ci/prow/e2e-openstack-ovn
ci/prow/e2e-openstack-proxy
ci/prow/gofmt
ci/prow/golint
ci/prow/govet
ci/prow/images
ci/prow/openstack-manifests
ci/prow/shellcheck
ci/prow/unit
ci/prow/verify-codegen
ci/prow/verify-deps
ci/prow/verify-vendor
ci/prow/yaml-lint
pull-ci-openshift-installer-fcos-gofmt
pull-ci-openshift-installer-fcos-golint
pull-ci-openshift-installer-fcos-govet
pull-ci-openshift-installer-fcos-images
pull-ci-openshift-installer-fcos-unit
pull-ci-openshift-installer-fcos-verify-codegen
pull-ci-openshift-installer-fcos-verify-vendor
pull-ci-openshift-installer-main-artifacts-images
pull-ci-openshift-installer-main-e2e-aws-ovn
pull-ci-openshift-installer-main-e2e-openstack-nfv-intel
pull-ci-openshift-installer-main-e2e-openstack-ovn
pull-ci-openshift-installer-main-e2e-openstack-proxy
pull-ci-openshift-installer-main-openstack-manifests
pull-ci-openshift-installer-main-shellcheck
pull-ci-openshift-installer-main-verify-deps
pull-ci-openshift-installer-main-yaml-lint
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override e2e-openstack-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sadasu · 2026-03-30T14:20:35Z

/retest-required

patrickdillon · 2026-03-30T17:44:46Z

/retest-required

openshift-ci-robot · 2026-03-30T20:30:35Z

/retest-required

Remaining retests: 0 against base HEAD 9d62459 and 1 for PR HEAD e99ff60 in total

openshift-ci · 2026-03-30T21:52:24Z

@eshulman2: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/openstack-manifests	`e99ff60`	link	true	`/test openstack-manifests`
ci/prow/images	`e99ff60`	link	true	`/test images`
ci/prow/e2e-aws-ovn	`e99ff60`	link	true	`/test e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot requested review from mandre and stephenfin March 17, 2026 10:24

eshulman2 force-pushed the release-4.20 branch from 6d4d430 to e99ff60 Compare March 17, 2026 12:27

eshulman2 changed the title ~~openstack: Disable LoadBalancer in cloud config when Octavia is unavailable~~ backport: openstack: Disable LoadBalancer in cloud config when Octavia is unavailable Mar 17, 2026

eshulman2 changed the title ~~backport: openstack: Disable LoadBalancer in cloud config when Octavia is unavailable~~ OCPBUGS-64842 backport: openstack: Disable LoadBalancer in cloud config when Octavia is unavailable Mar 17, 2026

eshulman2 changed the title ~~OCPBUGS-64842 backport: openstack: Disable LoadBalancer in cloud config when Octavia is unavailable~~ OCPBUGS-78694: backport: openstack: Disable LoadBalancer in cloud config when Octavia is unavailable Mar 17, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 17, 2026

stephenfin reviewed Mar 18, 2026

View reviewed changes

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 18, 2026

openshift-ci bot assigned stephenfin Mar 18, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2026

eshulman2 requested a review from stephenfin March 19, 2026 10:06

openshift-ci bot changed the title ~~OCPBUGS-78694: backport: openstack: Disable LoadBalancer in cloud config when Octavia is unavailable~~ OCPBUGS-78694: [release-4.20]: openstack: Disable LoadBalancer in cloud config when Octavia is unavailable Mar 19, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 23, 2026

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Mar 25, 2026

Conversation

eshulman2 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

eshulman2 commented Mar 17, 2026

Uh oh!

openshift-ci-robot commented Mar 17, 2026

Uh oh!

eshulman2 commented Mar 17, 2026

Uh oh!

openshift-ci-robot commented Mar 17, 2026

Uh oh!

stephenfin commented Mar 18, 2026

Uh oh!

stephenfin left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Mar 18, 2026

Uh oh!

stephenfin commented Mar 19, 2026

Uh oh!

stephenfin commented Mar 19, 2026

Uh oh!

mandre commented Mar 19, 2026

Uh oh!

eshulman2 commented Mar 23, 2026

Uh oh!

openshift-ci-robot commented Mar 23, 2026

Uh oh!

stephenfin commented Mar 24, 2026

Uh oh!

eshulman2 commented Mar 24, 2026

Uh oh!

openshift-ci-robot commented Mar 24, 2026

Uh oh!

eshulman2 commented Mar 24, 2026

Uh oh!

openshift-ci-robot commented Mar 24, 2026

Uh oh!

eshulman2 commented Mar 25, 2026

Uh oh!

openshift-ci-robot commented Mar 25, 2026

Uh oh!

stephenfin commented Mar 25, 2026

Uh oh!

openshift-ci-robot commented Mar 25, 2026

Uh oh!

stephenfin commented Mar 25, 2026

Uh oh!

openshift-ci-robot commented Mar 25, 2026

Uh oh!

eshulman2 commented Mar 25, 2026

Uh oh!

openshift-ci-robot commented Mar 25, 2026

Uh oh!

stephenfin commented Mar 25, 2026

Uh oh!

openshift-ci-robot commented Mar 25, 2026

Uh oh!

stephenfin commented Mar 25, 2026

Uh oh!

openshift-ci-robot commented Mar 25, 2026

Uh oh!

sadasu commented Mar 25, 2026

Uh oh!

openshift-ci-robot commented Mar 26, 2026

Uh oh!

sadasu commented Mar 30, 2026

Uh oh!

sadasu commented Mar 30, 2026

Uh oh!

openshift-ci bot commented Mar 30, 2026

Uh oh!

openshift-ci bot commented Mar 30, 2026

Uh oh!

sadasu commented Mar 30, 2026

eshulman2 commented Mar 17, 2026 •

edited

Loading

coderabbitai bot commented Mar 17, 2026 •

edited

Loading