Skip to content

CustomDNS feature enablement along with inclusion of 4.21 upstream installer#390

Draft
shaheen0b111 wants to merge 4 commits intorelease-4.21from
shaheen0b111/ARO-22038-CustomDNS-Feb
Draft

CustomDNS feature enablement along with inclusion of 4.21 upstream installer#390
shaheen0b111 wants to merge 4 commits intorelease-4.21from
shaheen0b111/ARO-22038-CustomDNS-Feb

Conversation

@shaheen0b111
Copy link
Copy Markdown
Collaborator

Initial changes includes

  • 4.21 upstream installer changes
  • CustomDNS feature flag set

@shaheen0b111 shaheen0b111 marked this pull request as draft February 24, 2026 08:30
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shaheen0b111
Once this PR has been reviewed and has the lgtm label, please assign hawkowl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment thread pkg/installer/custominstallconfig.go Outdated
@sankur-codes sankur-codes force-pushed the shaheen0b111/ARO-22038-CustomDNS-Feb branch from 0b1183b to 363e6d5 Compare March 5, 2026 14:21
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 10, 2026

@shaheen0b111: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate 363e6d5 link true /test validate
ci/prow/lint 363e6d5 link true /test lint
ci/prow/unit 363e6d5 link true /test unit
ci/prow/vendor 363e6d5 link true /test vendor

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants