Skip to content

SRVOCF-1074: Fix setup guide list number alignment in Firefox #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cragsmann wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −20
Open

SRVOCF-1074: Fix setup guide list number alignment in Firefox #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cf19d8
fix: align setup guide list numbers with text in Firefox
Cragsmann Sep 2, 2026
35fca47
chore: ignore .claude/worktrees local scratch dir
Cragsmann Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ AGENTS.override.md
.claude/*.local.*
.claude/settings*.json
.claude/pr/*
.claude/worktrees/
.mcp*
.tmp
.pi-subagents
Expand Down
4 changes: 1 addition & 3 deletions src/pages/function-list/components/EmptyState.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ export function FunctionsEmptyState({ isCreateDisabled }: FunctionsEmptyStatePro
"A GitHub Personal Access Token is required to create functions. Click 'Connect to GitHub' in the top-right corner to connect. Once connected, the create button will be enabled.",
)
: t('Create a serverless function to get started.')}
<div className="pf-v6-u-mt-sm">
<SetupGuide />
</div>
<SetupGuide className="pf-v6-u-display-block pf-v6-u-mx-auto pf-v6-u-mt-sm" />
</EmptyStateBody>
<EmptyStateFooter>
<EmptyStateActions>
Expand Down
31 changes: 14 additions & 17 deletions src/pages/function-list/components/SetupGuide.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import {
Button,
Content,
List,
ListItem,
Modal,
ModalBody,
ModalFooter,
Expand All @@ -11,18 +9,17 @@ import {
import { ReactNode, useState } from 'react';
import { useTranslation } from 'react-i18next';

export function SetupGuide() {
interface SetupGuideProps {
className?: string;
}

export function SetupGuide({ className }: SetupGuideProps) {
const { t } = useTranslation('plugin__console-functions-plugin');
const [isOpen, setIsOpen] = useState(false);

return (
<>
<Button
variant="link"
isInline
onClick={() => setIsOpen(true)}
data-test="setup-guide-button"
>
<Button variant="link" isInline onClick={() => setIsOpen(true)} className={className}>
{t('View setup guide.')}
</Button>
<SetupGuideModal isOpen={isOpen} onClose={() => setIsOpen(false)} />
Expand All @@ -39,25 +36,25 @@ function SetupGuideModal({ isOpen, onClose }: SetupGuideModalProps) {
const { t } = useTranslation('plugin__console-functions-plugin');

return (
<Modal isOpen={isOpen} onClose={onClose} variant="medium" data-test="setup-guide-modal">
<Modal isOpen={isOpen} onClose={onClose} variant="medium">
<ModalHeader title={t('Set up guide')} />
<ModalBody>
<Content component="p">
{t('Follow these steps to create and deploy your serverless function.')}
</Content>
<List component="ol" className="pf-v6-u-mt-md">
<Content component="ol" className="pf-v6-u-mt-md">
{steps(t).map((step) => (
<ListItem key={step.title}>
<Content component="p">
<strong>{step.title}</strong>
<Content component="li" key={step.title}>
<Content component="p" className="pf-v6-u-font-weight-bold">
{step.title}
</Content>
<Content component="p">{step.body}</Content>
</ListItem>
</Content>
))}
</List>
</Content>
</ModalBody>
<ModalFooter>
<Button variant="primary" onClick={onClose} data-test="setup-guide-close-button">
<Button variant="primary" onClick={onClose}>
{t('Close')}
</Button>
</ModalFooter>
Expand Down