Skip to content

DO NOT MERGE: OCPBUGS-103516: MADV_RANDOM removal on 4.22 (pre-6.4 kernel) - #400

Draft
hasbro17 wants to merge 1 commit into
openshift:openshift-4.22from
hasbro17:baseline-4.22-remove-madvise
Draft

DO NOT MERGE: OCPBUGS-103516: MADV_RANDOM removal on 4.22 (pre-6.4 kernel)#400
hasbro17 wants to merge 1 commit into
openshift:openshift-4.22from
hasbro17:baseline-4.22-remove-madvise

Conversation

@hasbro17

Copy link
Copy Markdown

DO NOT MERGE — throwaway PR for perfscale data gathering only.

Adds a go.mod replace pointing bbolt at the openshift/bbolt release-5.0
fork (v1.4.3 with madvise(MADV_RANDOM) removed) on openshift-4.22,
which runs on RHCOS9 / kernel 5.14 (el9_8).

Purpose: a control-plane-fips-24nodes perfscale run to confirm removing
MADV_RANDOM does not regress on a pre-6.4 kernel — closing the second
prong of the upstream argument (etcd-io/bbolt#939) that removal is safe on
older kernels.

Context: the current 4.22 baseline (stock bbolt, MADV_RANDOM present) already
performs well on el9_8 — compaction ~1.6s, major faults ~11.5/s — because the
RHEL 9.6 page-cache revert carried forward. This run should show removal stays
at parity (~1.6s), i.e. no regression.

Do not merge or review — this branch will be deleted once the data is
collected.

Ref: etcd-io/bbolt#939
Ref: https://redhat.atlassian.net/browse/OCPBUGS-103516

…perfscale

Add a go.mod replace pointing bbolt at the openshift/bbolt release-5.0
fork (v1.4.3 with madvise(MADV_RANDOM) removed) on the openshift-4.22
branch, which runs on RHCOS9 / kernel 5.14 (el9_8).

Purpose: a control-plane-fips-24nodes perfscale run to confirm removing
MADV_RANDOM does not regress on a pre-6.4 kernel. The current 4.22
baseline (stock bbolt, MADV_RANDOM present) already performs well on
el9_8 (compaction ~1.6s, low page faults), since the RHEL 9.6 page-cache
revert carried forward; this run shows removal stays neutral there.

Throwaway branch for data gathering only. Must not be merged.

Ref: etcd-io/bbolt#939
Ref: https://redhat.atlassian.net/browse/OCPBUGS-103516

Assisted-by: Claude Code (Opus 4.8)
@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2026
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 11, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@hasbro17: This pull request references Jira Issue OCPBUGS-103516, which is invalid:

  • expected the bug to target either version "4.22.0." or "openshift-4.22.0.", but it targets "5.0.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-103516 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

DO NOT MERGE — throwaway PR for perfscale data gathering only.

Adds a go.mod replace pointing bbolt at the openshift/bbolt release-5.0
fork (v1.4.3 with madvise(MADV_RANDOM) removed) on openshift-4.22,
which runs on RHCOS9 / kernel 5.14 (el9_8).

Purpose: a control-plane-fips-24nodes perfscale run to confirm removing
MADV_RANDOM does not regress on a pre-6.4 kernel — closing the second
prong of the upstream argument (etcd-io/bbolt#939) that removal is safe on
older kernels.

Context: the current 4.22 baseline (stock bbolt, MADV_RANDOM present) already
performs well on el9_8 — compaction ~1.6s, major faults ~11.5/s — because the
RHEL 9.6 page-cache revert carried forward. This run should show removal stays
at parity (~1.6s), i.e. no regression.

Do not merge or review — this branch will be deleted once the data is
collected.

Ref: etcd-io/bbolt#939
Ref: https://redhat.atlassian.net/browse/OCPBUGS-103516

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4826570f-17da-4277-bbbd-f8a89e381118

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2026
@hasbro17

Copy link
Copy Markdown
Author

/payload-job periodic-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-control-plane-fips-24nodes

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown

@hasbro17: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@hasbro17

Copy link
Copy Markdown
Author

/payload-job periodic-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-control-plane-fips-24nodes

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown

@hasbro17: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@hasbro17

Copy link
Copy Markdown
Author

/payload-job periodic-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-control-plane-fips-24nodes

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown

@hasbro17: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@afcollins

Copy link
Copy Markdown

/payload-job pull-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-control-plane-fips-24nodes

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown

@afcollins: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@afcollins

Copy link
Copy Markdown

/test pull-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-control-plane-fips-24nodes

@hasbro17

Copy link
Copy Markdown
Author

/test perfscale-payload-control-plane-6nodes

@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown

@hasbro17: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jtaleric

Copy link
Copy Markdown

/test ?

@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown

@jtaleric: The following commands are available to trigger required jobs:

/test configmap-scale
/test e2e-aws-ovn
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-upgrade
/test images
/test upstream-unit

The following commands are available to trigger optional jobs:

/test e2e-aws-etcd-recovery
/test e2e-hypershift
/test e2e-hypershift-conformance
/test perfscale-payload-control-plane-6nodes
/test upstream-e2e
/test upstream-integration
/test upstream-release

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-etcd-openshift-4.22-configmap-scale
pull-ci-openshift-etcd-openshift-4.22-e2e-aws-ovn
pull-ci-openshift-etcd-openshift-4.22-e2e-aws-ovn-serial
pull-ci-openshift-etcd-openshift-4.22-e2e-aws-ovn-upgrade
pull-ci-openshift-etcd-openshift-4.22-images
pull-ci-openshift-etcd-openshift-4.22-upstream-e2e
pull-ci-openshift-etcd-openshift-4.22-upstream-integration
pull-ci-openshift-etcd-openshift-4.22-upstream-release
pull-ci-openshift-etcd-openshift-4.22-upstream-unit
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants