Skip to content

STOR-3090: Enable pod-delete-after-umount CSI suite for driver OCP manifests - #596

Open
radeore wants to merge 1 commit into
openshift:mainfrom
radeore:umount-test
Open

STOR-3090: Enable pod-delete-after-umount CSI suite for driver OCP manifests#596
radeore wants to merge 1 commit into
openshift:mainfrom
radeore:umount-test

Conversation

@radeore

@radeore radeore commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds PodDeleteAfterUmountTest: true to OpenShift CSI driver config manifests for:

test/e2e/aws-ebs/ocp-manifest.yaml
test/e2e/aws-efs/ocp-manifest.yaml
test/e2e/azure-disk/ocp-manifest.yaml
test/e2e/azure-file/ocp-manifest.yaml

This enables the 'OpenShift CSI extended - Pod delete after umount suite' for these drivers, aligning csi-operator test manifests with the new origin test-gating flag introduced in openshift/origin#31488.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 11, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 11, 2026

Copy link
Copy Markdown

@radeore: This pull request references STOR-3090 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Adds PodDeleteAfterUmountTest: true to OpenShift CSI driver config manifests for:

test/e2e/aws-ebs/ocp-manifest.yaml
test/e2e/aws-efs/ocp-manifest.yaml
test/e2e/azure-disk/ocp-manifest.yaml
test/e2e/azure-file/ocp-manifest.yaml

This enables the 'OpenShift CSI extended - Pod delete after umount suite' for these drivers, aligning csi-operator test manifests with the new origin test-gating flag introduced in openshift/origin#31488.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from dobsonj and stephenfin August 11, 2026 18:51
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: radeore
Once this PR has been reviewed and has the lgtm label, please assign gnufied for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 6f742118-0284-44ff-a4c1-221a06e59b43

📥 Commits

Reviewing files that changed from the base of the PR and between 756f6b8 and 9e9a7a7.

📒 Files selected for processing (4)
  • test/e2e/aws-ebs/ocp-manifest.yaml
  • test/e2e/aws-efs/ocp-manifest.yaml
  • test/e2e/azure-disk/ocp-manifest.yaml
  • test/e2e/azure-file/ocp-manifest.yaml

📝 Walkthrough

Walkthrough

Enabled PodDeleteAfterUmountTest: true in the AWS EBS, AWS EFS, Azure disk, and Azure file OCP manifests.

Suggested reviewers: jsafrane

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes enabling the pod-delete-after-umount CSI suite in OCP driver manifests.
Description check ✅ Passed The description accurately identifies the manifest changes and explains that they enable the OpenShift CSI pod-delete-after-umount test suite.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only four YAML manifests by adding the static boolean PodDeleteAfterUmountTest: true; it adds no Ginkgo test titles or dynamic title values.
Test Structure And Quality ✅ Passed Not applicable: the commit changes only four YAML manifests (+1 field each) and contains no Ginkgo It blocks, setup, waits, or assertions to review.
Microshift Test Compatibility ✅ Passed The commit changes only four YAML manifests by adding PodDeleteAfterUmountTest; it adds no Ginkgo tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only four YAML manifests and adds no Ginkgo test declarations or test code, so the SNO multi-node compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The commit adds only a boolean test-suite flag to four OCP test configuration files; it adds no replicas, affinity, topology spread, node selectors, tolerations, or PDBs.
Ote Binary Stdout Contract ✅ Passed The PR changes only four YAML manifests; no OTE binary, suite setup, or process-level stdout write is added or present in the changed code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit adds only four YAML flags; it adds no Ginkgo tests, IP handling, URLs, or external connectivity.
No-Weak-Crypto ✅ Passed The patch adds only four boolean PodDeleteAfterUmountTest settings; no weak algorithms, custom crypto, or secret comparisons appear in the changed files.
Container-Privileges ✅ Passed The commit changes only four test configuration YAML files by adding PodDeleteAfterUmountTest: true; none contain privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed The commit adds only four boolean YAML settings. It adds no logging calls, log content, passwords, tokens, keys, PII, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@radeore: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants