OU-1488: [release-4.12] Sanitize alert runbook URLs

[dchromik]

• Backport of NO-JIRA: sanitize runbook_url monitoring-plugin#1255
• Jira ticket: https://redhat.atlassian.net/browse/OU-1488

Analysis / Root cause:
Maliciouse runbook_url could be passed to ExternalLink in frontend/public/components/monitoring/alerting.tsx.

Solution description:
Only render runbook_url annotations as links when they are absolute HTTP(S) URLs. This prevents unsafe annotation values from producing executable links while leaving them visible as text.

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

[openshift-ci-robot]

@dchromik: No Jira issue with key OU-1488 exists in the tracker at https://redhat.atlassian.net.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

• Backport of NO-JIRA: sanitize runbook_url monitoring-plugin#1255
• Jira ticket: https://redhat.atlassian.net/browse/OU-1488

Analysis / Root cause:
Maliciouse runbook_url could be passed to ExternalLink in frontend/public/components/monitoring/alerting.tsx.

Solution description:
Only render runbook_url annotations as links when they are absolute HTTP(S) URLs. This prevents unsafe annotation values from producing executable links while leaving them visible as text.

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 0bfca5f0-5567-4013-8acb-d11892fff2ce

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dchromik
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• frontend/public/components/monitoring/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[etmurasaki]

/verified by @etmurasaki

[openshift-ci-robot]

@etmurasaki: This PR has been marked as verified by @etmurasaki.

Details

In response to this:

/verified by @etmurasaki

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[etmurasaki]

/test images

[etmurasaki]

/label qe-approved

[openshift-ci-robot]

@dchromik: No Jira issue with key OU-1488 exists in the tracker at https://redhat.atlassian.net.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

• Backport of NO-JIRA: sanitize runbook_url monitoring-plugin#1255
• Jira ticket: https://redhat.atlassian.net/browse/OU-1488

Analysis / Root cause:
Maliciouse runbook_url could be passed to ExternalLink in frontend/public/components/monitoring/alerting.tsx.

Solution description:
Only render runbook_url annotations as links when they are absolute HTTP(S) URLs. This prevents unsafe annotation values from producing executable links while leaving them visible as text.

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@dchromik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	aa2e417	link	true	/test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.