Skip to content

[release-4.20] OCPBUGS-74158: Do not resolve disabled catalog type extensions#15931

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.20from
logonoff:OCPBUGS-74158-4.20-devfile
Jan 30, 2026
Merged

[release-4.20] OCPBUGS-74158: Do not resolve disabled catalog type extensions#15931
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.20from
logonoff:OCPBUGS-74158-4.20-devfile

Conversation

@logonoff
Copy link
Member

This is an automated cherry-pick of #15930

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 20, 2026
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-74158, which is invalid:

  • expected dependent Jira Issue OCPBUGS-74157 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #15930

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 20, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@logonoff logonoff force-pushed the OCPBUGS-74158-4.20-devfile branch from 7fc9786 to 117534b Compare January 20, 2026 14:31
@openshift-ci openshift-ci bot requested review from jhadvig and spadgett January 20, 2026 14:31
@openshift-ci openshift-ci bot added component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 20, 2026
@logonoff logonoff force-pushed the OCPBUGS-74158-4.20-devfile branch from 117534b to 770b694 Compare January 20, 2026 14:45
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026
@logonoff
Copy link
Member Author

/assign @yapei

@logonoff
Copy link
Member Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 20, 2026
@logonoff
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 20, 2026
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-74158, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-74157 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-74157 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei January 20, 2026 15:30
@logonoff
Copy link
Member Author

/cherry-pick release-4.19

@openshift-cherrypick-robot

@logonoff: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@logonoff logonoff force-pushed the OCPBUGS-74158-4.20-devfile branch from 770b694 to bc05b7e Compare January 22, 2026 23:32
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2026
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logonoff
Copy link
Member Author

/cc @yanpzhan

@openshift-ci openshift-ci bot requested a review from yanpzhan January 28, 2026 01:01
@yanpzhan
Copy link
Contributor

yanpzhan commented Jan 28, 2026

Tested on cluster launched against the pr, set Cluster Samples Operator as 'managementState: removed' and disabled devfiles catalog from customization page, checked catalogs by clicking "All services", "Database" or "Samples" from "+Add" page. There was not error msg, and no https request for 'devfiles' in network.
Screenshot from 2026-01-28 18-58-43

@yanpzhan
Copy link
Contributor

/verified by yanpzhan

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 28, 2026
@openshift-ci-robot
Copy link
Contributor

@yanpzhan: This PR has been marked as verified by yanpzhan.

Details

In response to this:

/verified by yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 52fe23a and 2 for PR HEAD bc05b7e in total

@logonoff
Copy link
Member Author

/retest

3 similar comments
@logonoff
Copy link
Member Author

/retest

@logonoff
Copy link
Member Author

/retest

@logonoff
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0493d8f into openshift:release-4.20 Jan 30, 2026
8 checks passed
@openshift-ci-robot
Copy link
Contributor

@logonoff: Jira Issue Verification Checks: Jira Issue OCPBUGS-74158
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-74158 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #15930

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@logonoff: #15931 failed to apply on top of branch "release-4.19":

Applying: OCPBUGS-74158: Do not resolve disabled catalog type extensions
Using index info to reconstruct a base tree...
M	frontend/packages/console-shared/src/components/catalog/__tests__/CatalogController.spec.tsx
M	frontend/packages/console-shared/src/components/catalog/hooks/useCatalogExtensions.ts
M	frontend/packages/console-shared/src/components/catalog/utils/catalog-utils.tsx
M	frontend/packages/console-shared/src/utils/__tests__/isSubCatalogTypeEnabled.spec.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/console-shared/src/utils/__tests__/isSubCatalogTypeEnabled.spec.ts
Auto-merging frontend/packages/console-shared/src/components/catalog/utils/catalog-utils.tsx
CONFLICT (content): Merge conflict in frontend/packages/console-shared/src/components/catalog/utils/catalog-utils.tsx
Auto-merging frontend/packages/console-shared/src/components/catalog/hooks/useCatalogExtensions.ts
CONFLICT (content): Merge conflict in frontend/packages/console-shared/src/components/catalog/hooks/useCatalogExtensions.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-74158: Do not resolve disabled catalog type extensions

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@logonoff logonoff deleted the OCPBUGS-74158-4.20-devfile branch January 30, 2026 02:44
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.20.0-0.nightly-2026-01-30-225120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/shared Related to console-shared jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants