OCPBUGS-72260: '0 of pods' are shown in Status column on DaemonSets list page. #15928

cajieh · 2026-01-19T19:55:28Z

Before:

After:

Summary by CodeRabbit

Bug Fixes
- Fixed pod count display for DaemonSet resources to show accurate current and desired replica counts.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-19T19:55:35Z

📝 Walkthrough

Walkthrough

This change modifies the workload table component to correctly handle replica count display for DaemonSet resources. Previously, the component used uniform property access patterns for all workload types. The update introduces conditional logic that distinguishes between DaemonSets and other workload kinds, using currentNumberScheduled and desiredNumberScheduled for DaemonSets while using standard replicas properties for other resource types. This ensures the replica information displayed in the table accurately reflects the semantic differences between workload controllers.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main bug fix: DaemonSets were showing '0 of pods' in the Status column, and this PR fixes that issue by implementing proper replica counting logic for DaemonSet resources.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-01-19T19:55:39Z

@cajieh: This pull request references Jira Issue OCPBUGS-72260, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhamilto

/lgtm

rhamilto · 2026-01-20T15:19:27Z

frontend/public/components/workload-table.tsx

+
+  // DaemonSets use different status fields than Deployments
+  const isDaemonSet = kind?.includes('DaemonSet');
+  const statusReplicas = kind?.includes('DaemonSet')


Nit

Suggested change

const statusReplicas = kind?.includes('DaemonSet')

const statusReplicas = isDaemonSet

rhamilto

/lgtm

openshift-ci · 2026-01-20T18:16:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [cajieh,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cajieh · 2026-01-26T14:39:38Z

/jira refresh

openshift-ci-robot · 2026-01-26T14:39:47Z

@cajieh: This pull request references Jira Issue OCPBUGS-72260, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cajieh · 2026-01-26T14:40:44Z

/verified

openshift-ci-robot · 2026-01-26T14:40:47Z

@cajieh: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cajieh · 2026-01-26T14:41:01Z

/verified later @yapei

openshift-ci-robot · 2026-01-26T14:41:16Z

@cajieh: This PR has been marked to be verified later by @yapei.

Details

In response to this:

/verified later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-01-26T20:33:22Z

/retest-required

Remaining retests: 0 against base HEAD 4a2fec7 and 2 for PR HEAD ffbe733 in total

openshift-ci-robot · 2026-01-27T14:33:37Z

/retest-required

Remaining retests: 0 against base HEAD 1d96e43 and 1 for PR HEAD ffbe733 in total

openshift-ci-robot · 2026-01-27T19:33:15Z

/retest-required

Remaining retests: 0 against base HEAD c1a5050 and 0 for PR HEAD ffbe733 in total

openshift-ci · 2026-01-28T02:47:44Z

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-01-28T02:50:48Z

@cajieh: Jira Issue OCPBUGS-72260: All pull requests linked via external trackers have merged:

openshift/console#15928

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-72260 has been moved to the MODIFIED state.

Details

In response to this:

Before:

After:

Summary by CodeRabbit

Bug Fixes

Fixed pod count display for DaemonSet resources to show accurate current and desired replica counts.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2026

openshift-ci bot requested review from Leo6Leo and spadgett January 19, 2026 19:55

openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 19, 2026

cajieh force-pushed the OCPBUGS-72260 branch from 33b1b6b to e897cfd Compare January 20, 2026 13:53

cajieh changed the title ~~[WIP] OCPBUGS-72260: '0 of pods' are shown in Status column on DaemonSets list page.~~ OCPBUGS-72260: '0 of pods' are shown in Status column on DaemonSets list page. Jan 20, 2026

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2026

cajieh force-pushed the OCPBUGS-72260 branch from e897cfd to 0c0fb86 Compare January 20, 2026 14:08

rhamilto reviewed Jan 20, 2026

View reviewed changes

openshift-ci bot assigned rhamilto Jan 20, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026

'0 of pods' are shown in Status column on DaemonSets list page.

ffbe733

cajieh force-pushed the OCPBUGS-72260 branch from 0c0fb86 to ffbe733 Compare January 20, 2026 15:37

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026

rhamilto approved these changes Jan 20, 2026

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 26, 2026

openshift-ci bot requested a review from yapei January 26, 2026 14:39

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Jan 26, 2026

openshift-merge-bot bot merged commit c947e17 into openshift:main Jan 28, 2026
8 checks passed

	const statusReplicas = kind?.includes('DaemonSet')
	const statusReplicas = isDaemonSet

OCPBUGS-72260: '0 of pods' are shown in Status column on DaemonSets list page. #15928

OCPBUGS-72260: '0 of pods' are shown in Status column on DaemonSets list page. #15928

Conversation

cajieh commented Jan 19, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before:

After:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

openshift-ci-robot commented Jan 19, 2026

Uh oh!

rhamilto left a comment

Choose a reason for hiding this comment

Uh oh!

rhamilto Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

rhamilto left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 20, 2026

Uh oh!

cajieh commented Jan 26, 2026

Uh oh!

openshift-ci-robot commented Jan 26, 2026

Uh oh!

cajieh commented Jan 26, 2026

Uh oh!

openshift-ci-robot commented Jan 26, 2026

Uh oh!

cajieh commented Jan 26, 2026

Uh oh!

openshift-ci-robot commented Jan 26, 2026

Uh oh!

openshift-ci-robot commented Jan 26, 2026

Uh oh!

openshift-ci-robot commented Jan 27, 2026

Uh oh!

openshift-ci-robot commented Jan 27, 2026

Uh oh!

openshift-ci bot commented Jan 28, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 28, 2026

Before:

After:

Summary by CodeRabbit

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cajieh commented Jan 19, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 19, 2026 •

edited

Loading