OCPBUGS-65887: Update a lot of deps by logonoff · Pull Request #93 · openshift/console-plugin-template

logonoff · 2025-11-21T16:35:23Z

Closes #92

after:

openshift-ci-robot · 2025-11-21T16:35:28Z

@logonoff: This pull request references Jira Issue OCPBUGS-65887, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-11-21T16:36:02Z

/jira refresh

openshift-ci-robot · 2025-11-21T16:36:10Z

@logonoff: This pull request references Jira Issue OCPBUGS-65887, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-21T16:38:36Z

@logonoff: This pull request references Jira Issue OCPBUGS-65887, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

after:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Bumps minimum OCP version to 4.19.0

vojtechszocs · 2025-11-21T17:55:37Z

.vscode/settings.json

@@ -1,5 +1,10 @@
 {
  "typescript.tsdk": "./node_modules/typescript/lib",
+  "editor.formatOnSave": false,


Do we need this to be an explicit option?

Does setting editor.codeActionsOnSave cause editor.formatOnSave to be enabled by default?

We should explicitly disable formatOnSave (even overriding user workspace preferences) because it has problems with our eslint config. codeActionsOnSave is run before formatOnSave, but the formatOnSave formatting is incorrect according to the linter. This is very annoying.

README.md

vojtechszocs · 2025-11-21T17:57:49Z

README.md

 with this namespace as follows:

 ```tsx
-conster Header: React.FC = () => {


😆 conster sounds like a const but stronger

vojtechszocs · 2025-11-21T17:59:52Z

package.json

+    "@babel/preset-env": "^7.28.5",
+    "@cypress/webpack-preprocessor": "^7.0.2",
+    "@openshift-console/dynamic-plugin-sdk": "4.19.1",
+    "@openshift-console/dynamic-plugin-sdk-webpack": "4.19.0",


Big update to Console plugin SDK packages 👍

vojtechszocs · 2025-11-21T18:01:14Z

package.json

    },
    "dependencies": {
-      "@console/pluginAPI": "*"
+      "@console/pluginAPI": "^4.19.0"


This should encourage real world plugins to utilize the @console/pluginAPI dependency 👍

package.json

src/components/ExamplePage.tsx

vojtechszocs · 2025-11-21T18:05:31Z

tsconfig.json

+    "jsx": "react-jsx",
    "allowJs": true,
-    "strict": false,
+    "strict": true,


👍 for the switch to TS strict mode

openshift-ci · 2025-11-21T18:09:50Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff
Once this PR has been reviewed and has the lgtm label, please ask for approval from vojtechszocs. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

README.md

logonoff · 2025-12-15T17:02:18Z

/retest

logonoff · 2025-12-17T14:21:55Z

/retest

jhadvig · 2026-01-30T09:14:02Z

/retest

openshift-ci · 2026-01-30T09:18:43Z

@logonoff: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-plugin-template	`6075b34`	link	true	`/test e2e-aws-plugin-template`
ci/prow/images	`6075b34`	link	true	`/test images`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 21, 2025

openshift-ci bot requested review from christianvogt and florkbr November 21, 2025 16:35

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 21, 2025

openshift-ci bot requested a review from yapei November 21, 2025 16:36

logonoff force-pushed the OCPBUGS-65887-deps branch 5 times, most recently from bb3f145 to 6c4adfd Compare November 21, 2025 17:14

logonoff added 4 commits November 21, 2025 12:14

OCPBUGS-65887: Update a lot of deps

c8ddb09

Bumps minimum OCP version to 4.19.0

OCPBUGS-65887: Update i18n strings

ba1b415

OCPBUGS-65887: Add auto format on save for vscode

f52a36b

OCPBUGS-68557: Resolve all missing peerDeps warnings

7016f3b

logonoff force-pushed the OCPBUGS-65887-deps branch from 6c4adfd to 7016f3b Compare November 21, 2025 17:15

vojtechszocs suggested changes Nov 21, 2025

View reviewed changes

openshift-ci bot assigned vojtechszocs Nov 21, 2025

logonoff force-pushed the OCPBUGS-65887-deps branch from 9631b59 to ec19900 Compare November 21, 2025 18:09

lavocatt mentioned this pull request Nov 25, 2025

Bump dependencies for 4.19 arkmq-org/activemq-artemis-self-provisioning-plugin#167

Open

vojtechszocs suggested changes Nov 25, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

logonoff added 3 commits November 25, 2025 09:37

OCPBUGS-65887: Ban all colours and update README

ee255d7

OCPBUGS-65887: Bump to 4.20 SDK

623ccaa

NO-JIRA: add myself to owners

6075b34

logonoff force-pushed the OCPBUGS-65887-deps branch from af8a1c4 to 6075b34 Compare November 25, 2025 14:38

openshift-ci-robot mentioned this pull request Dec 15, 2025

OCPBUGS-65887: add kind/demo-plugin label and bump console-plugin-template to node 22 openshift/release#71710

Merged

Conversation

logonoff commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 21, 2025

Uh oh!

logonoff commented Nov 21, 2025

Uh oh!

openshift-ci-robot commented Nov 21, 2025

Uh oh!

openshift-ci-robot commented Nov 21, 2025

Uh oh!

vojtechszocs Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

logonoff Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vojtechszocs Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

vojtechszocs Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

vojtechszocs Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vojtechszocs Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 21, 2025

Uh oh!

Uh oh!

logonoff commented Dec 15, 2025

Uh oh!

logonoff commented Dec 17, 2025

Uh oh!

jhadvig commented Jan 30, 2026

Uh oh!

openshift-ci bot commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

logonoff commented Nov 21, 2025 •

edited

Loading

logonoff Nov 21, 2025 •

edited

Loading