chore: remove AWSServiceLBNetworkSecurityGroup feature gate

[damdo]

Summary

• Remove the AWSServiceLBNetworkSecurityGroup feature gate from features/features.go — it has been enabled by default across all profiles and feature sets and is no longer needed
• Regenerate payload feature gate manifests (8 files) to reflect the removal
• Update test data in featuregate-test-analyzer_test.go to use a different AWS gate (AWSClusterHostedDNS)

Test plan

• make test-unit passes (including TestOKDHasAllDefaultFeatureGates)
• hack/verify-payload-featuregates.sh passes
• No remaining references to AWSServiceLBNetworkSecurityGroup in the codebase

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @damdo! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f3aa1721-be36-43b9-951b-ac39afed9979

📥 Commits

Reviewing files that changed from the base of the PR and between 8f52beb and 83f1c8b.

📒 Files selected for processing (11)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
• tools/codegen/cmd/featuregate-test-analyzer_test.go

💤 Files with no reviewable changes (10)

• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
• features.md
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

---

📝 Walkthrough

Walkthrough

Removed the AWSServiceLBNetworkSecurityGroup feature-gate declaration and feature support matrix entry. Removed the feature gate from HyperShift and self-managed HA manifests. Updated the AWS HyperShift analyzer test to use AWSClusterHostedDNS.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the removal of the AWSServiceLBNetworkSecurityGroup feature gate.
Description check	✅ Passed	The description directly explains the feature-gate removal, manifest updates, test changes, and validation steps.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes no Ginkgo test titles; its only test change is a static feature-gate value in a standard-library t.Run table.
Test Structure And Quality	✅ Passed	The only touched test is a standard table-driven Go unit test for filterVariants; it uses a diagnostic t.Errorf and has no Ginkgo, cluster resources, cleanup, or wait operations.
Microshift Test Compatibility	✅ Passed	The pull request adds no Ginkgo e2e tests; it changes one literal in the existing standard Go Test_filterVariants unit test and adds no MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR adds no Ginkgo e2e tests; its only added Go line changes a feature-gate string in a standard testing.T unit test.
Topology-Aware Scheduling Compatibility	✅ Passed	The patch only removes a feature-gate declaration, matrix row, and FeatureGate entries, plus test data; it adds no workload or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only feature-gate metadata, manifests, and one test literal; the patch adds no main/init/suite setup or stdout/logging writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR adds no Ginkgo e2e tests. The only changed test is a standard Go Test_filterVariants unit test, and no new IPv4 or external-connectivity requirement is introduced.
No-Weak-Crypto	✅ Passed	The patch only removes feature-gate entries and changes one test string; scans found no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons in changed paths.
Container-Privileges	✅ Passed	The patch adds no privilege settings; all eight JSON manifests are FeatureGate resources, and changed files contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalat...
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds only the non-sensitive feature-gate string AWSClusterHostedDNS; all other changes delete declarations or manifest entries, with no new logging calls or sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment