add Insights capability to Insights CRDs

[opokornyy]

User description

This PR adds the capability.openshift.io/name=Insights annotation to all Insights related CRDs.

---

PR Type

Enhancement

---

Description

• Add capability.openshift.io/name=Insights annotation to all Insights CRDs

• Update type definitions across multiple API versions (v1, v1alpha1, v1alpha2)

• Regenerate CRD manifests with capability metadata

• Update featuregated CRD manifests and payload manifests

---

Diagram Walkthrough

flowchart LR
  A["Insights CRD Type Definitions"] -->|Add capability annotation| B["Updated Go Type Files"]
  B -->|Generate manifests| C["CRD Manifests"]
  C -->|Update metadata| D["Generated YAML Manifests"]
  D -->|Propagate to| E["Payload Manifests"]

Loading

File Walkthrough

	Relevant files
Enhancement	6 files types_insights.go Add Insights capability annotation to v1 type                        +1/-0      types_insights.go Add Insights capability annotation to v1alpha1 type            +1/-0      types_insights.go Add Insights capability annotation to v1alpha2 type            +1/-0      types_insights.go Add Insights capability annotation to insights v1 type      +1/-0      types_insights.go Add Insights capability annotation to insights v1alpha1 type +1/-0      types_insights.go Add Insights capability annotation to insights v1alpha2 type +1/-0
Configuration changes	15 files 0000_10_config-operator_01_insightsdatagathers-CustomNoUpgrade.crd.yaml Add capability annotation to CustomNoUpgrade manifest        +1/-0      0000_10_config-operator_01_insightsdatagathers-DevPreviewNoUpgrade.crd.yaml Add capability annotation to DevPreviewNoUpgrade manifest +1/-0      0000_10_config-operator_01_insightsdatagathers-TechPreviewNoUpgrade.crd.yaml Add capability annotation to TechPreviewNoUpgrade manifest +1/-0      zz_generated.featuregated-crd-manifests.yaml Update Capability field from empty to Insights                      +1/-1      InsightsConfig.yaml Add capability annotation to featuregated manifest              +1/-0      0000_10_config-operator_01_insightsdatagathers-CustomNoUpgrade.crd.yaml Add capability annotation to v1alpha1 CustomNoUpgrade manifest +1/-0      0000_10_config-operator_01_insightsdatagathers-DevPreviewNoUpgrade.crd.yaml Add capability annotation to v1alpha1 DevPreviewNoUpgrade manifest +1/-0      0000_10_config-operator_01_insightsdatagathers-TechPreviewNoUpgrade.crd.yaml Add capability annotation to v1alpha1 TechPreviewNoUpgrade manifest +1/-0      zz_generated.featuregated-crd-manifests.yaml Update Capability field from empty to Insights                      +1/-1      InsightsConfig.yaml Add capability annotation to v1alpha1 featuregated manifest +1/-0      0000_10_config-operator_01_insightsdatagathers-CustomNoUpgrade.crd.yaml Add capability annotation to v1alpha2 CustomNoUpgrade manifest +1/-0      0000_10_config-operator_01_insightsdatagathers-DevPreviewNoUpgrade.crd.yaml Add capability annotation to v1alpha2 DevPreviewNoUpgrade manifest +1/-0      0000_10_config-operator_01_insightsdatagathers-TechPreviewNoUpgrade.crd.yaml Add capability annotation to v1alpha2 TechPreviewNoUpgrade manifest +1/-0      zz_generated.featuregated-crd-manifests.yaml Update Capability field from empty to Insights                      +1/-1      InsightsConfig.yaml Add capability annotation to v1alpha2 featuregated manifest +1/-0
Additional files	21 files 0000_10_insights_01_datagathers-CustomNoUpgrade.crd.yaml +1/-0      0000_10_insights_01_datagathers-DevPreviewNoUpgrade.crd.yaml +1/-0      0000_10_insights_01_datagathers-TechPreviewNoUpgrade.crd.yaml +1/-0      zz_generated.featuregated-crd-manifests.yaml +1/-1      InsightsOnDemandDataGather.yaml +1/-0      0000_10_insights_01_datagathers-CustomNoUpgrade.crd.yaml +1/-0      0000_10_insights_01_datagathers-DevPreviewNoUpgrade.crd.yaml +1/-0      0000_10_insights_01_datagathers-TechPreviewNoUpgrade.crd.yaml +1/-0      zz_generated.featuregated-crd-manifests.yaml +1/-1      InsightsOnDemandDataGather.yaml +1/-0      0000_10_insights_01_datagathers-CustomNoUpgrade.crd.yaml +1/-0      0000_10_insights_01_datagathers-DevPreviewNoUpgrade.crd.yaml +1/-0      0000_10_insights_01_datagathers-TechPreviewNoUpgrade.crd.yaml +1/-0      zz_generated.featuregated-crd-manifests.yaml +1/-1      InsightsOnDemandDataGather.yaml +1/-0      0000_10_config-operator_01_insightsdatagathers-CustomNoUpgrade.crd.yaml +1/-0      0000_10_config-operator_01_insightsdatagathers-DevPreviewNoUpgrade.crd.yaml +1/-0      0000_10_config-operator_01_insightsdatagathers-TechPreviewNoUpgrade.crd.yaml +1/-0      0000_10_insights_01_datagathers-CustomNoUpgrade.crd.yaml +1/-0      0000_10_insights_01_datagathers-DevPreviewNoUpgrade.crd.yaml +1/-0      0000_10_insights_01_datagathers-TechPreviewNoUpgrade.crd.yaml +1/-0

---

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @opokornyy! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request adds Insights capability declarations across multiple CRD definitions and API versions. It introduces the +openshift:capability=Insights annotation to type definition files in config and insights API groups (versions v1, v1alpha1, and v1alpha2), updates generated feature-gated CRD manifests to set the Capability field to "Insights", and adds capability.openshift.io/name annotations to CRD YAML manifests. These changes apply to both InsightsDataGather and DataGather resources across multiple feature gate variants.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and accurately summarizes the main change: adding the Insights capability to Insights CRDs across multiple API versions and manifests.
Description check	✅ Passed	The description is directly related to the changeset, providing context about adding capability.openshift.io/name=Insights annotations to Insights CRDs with clear file categorization and visual workflow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

No code suggestions found for the PR.

[JoelSpeed]

/lgtm

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/override ci/prow/e2e-aws-serial-techpreview
/override ci/prow/e2e-aws-serial

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial, ci/prow/e2e-aws-serial-techpreview

Details

In response to this:

/override ci/prow/e2e-aws-serial-techpreview
/override ci/prow/e2e-aws-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[JoelSpeed]

/test e2e-aws-ovn-hypershift-conformance

[qodo-code-review]

PR-Agent: could not fine a component named e2e-aws-ovn-hypershift-conformance in a supported language in this PR.

[openshift-ci]

@opokornyy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.