MCO-1870: Update MachineConfigNode printcolumns

[isabella-janssen]

User description

This updates the printcolumns for MachineConfigNodes to align with the changes made for MCO-1870:

• Addition of AppliedOSImage and AppliedFiles conditions
• Removal of UpdatedFilesAndOS condition

---

PR Type

Enhancement

---

Description

• Replace UpdatedFilesAndOS printcolumn with AppliedOSImage and AppliedFiles

• Update condition type references from AppliedFilesAndOS to separate conditions

• Synchronize changes across all CRD manifest files and feature-gated variants

---

Diagram Walkthrough

flowchart LR
  A["UpdatedFilesAndOS<br/>printcolumn"] -->|"Replace with"| B["AppliedOSImage<br/>printcolumn"]
  A -->|"Replace with"| C["AppliedFiles<br/>printcolumn"]
  D["AppliedFilesAndOS<br/>condition type"] -->|"Split into"| E["AppliedOSImage<br/>condition"]
  D -->|"Split into"| F["AppliedFiles<br/>condition"]

Loading

File Walkthrough

	Relevant files
Enhancement	1 files types_machineconfignode.go Update kubebuilder printcolumn annotations for conditions +2/-1
Configuration changes	25 files 0000_80_machine-config_01_machineconfignodes-Hypershift-CustomNoUpgrade.crd.yaml Update printcolumns in Hypershift CustomNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-Default.crd.yaml Update printcolumns in Hypershift Default CRD manifest      +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-DevPreviewNoUpgrade.crd.yaml Update printcolumns in Hypershift DevPreviewNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-OKD.crd.yaml Update printcolumns in Hypershift OKD CRD manifest              +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-TechPreviewNoUpgrade.crd.yaml Update printcolumns in Hypershift TechPreviewNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-CustomNoUpgrade.crd.yaml Update printcolumns in SelfManagedHA CustomNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-Default.crd.yaml Update printcolumns in SelfManagedHA Default CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml Update printcolumns in SelfManagedHA DevPreviewNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-OKD.crd.yaml Update printcolumns in SelfManagedHA OKD CRD manifest        +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml Update printcolumns in SelfManagedHA TechPreviewNoUpgrade CRD manifest +6/-2      zz_generated.featuregated-crd-manifests.yaml Update printcolumns in featuregated CRD manifests aggregation +6/-2      ImageModeStatusReporting.yaml Update printcolumns in ImageModeStatusReporting feature gate +6/-2      IrreconcilableMachineConfig.yaml Update printcolumns in IrreconcilableMachineConfig feature gate +6/-2      MachineConfigNodes.yaml Update printcolumns in MachineConfigNodes feature gate      +6/-2      NoRegistryClusterInstall.yaml Update printcolumns in NoRegistryClusterInstall feature gate +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-CustomNoUpgrade.crd.yaml Update printcolumns in payload Hypershift CustomNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-Default.crd.yaml Update printcolumns in payload Hypershift Default manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-DevPreviewNoUpgrade.crd.yaml Update printcolumns in payload Hypershift DevPreviewNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-OKD.crd.yaml Update printcolumns in payload Hypershift OKD manifest      +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-TechPreviewNoUpgrade.crd.yaml Update printcolumns in payload Hypershift TechPreviewNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-CustomNoUpgrade.crd.yaml Update printcolumns in payload SelfManagedHA CustomNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-Default.crd.yaml Update printcolumns in payload SelfManagedHA Default manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml Update printcolumns in payload SelfManagedHA DevPreviewNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-OKD.crd.yaml Update printcolumns in payload SelfManagedHA OKD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml Update printcolumns in payload SelfManagedHA TechPreviewNoUpgrade manifest +6/-2

---

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1870 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This updates the printcolumns for MachineConfigNodes to align with the changes made for MCO-1870:

• Addition of AppliedOSImage and AppliedFiles conditions
• Removal of UpdatedFilesAndOS condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @isabella-janssen! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request refactors machine configuration node status tracking by replacing a single combined condition UpdatedFilesAndOS with two separate conditions: AppliedOSImage and AppliedFiles. Changes are applied across Go type definitions and multiple CustomResourceDefinition (CRD) manifest files for different deployment scenarios. The modifications update printer column definitions and condition mappings to reflect the new condition types, with explicit priority and type specifications. In some CRD variants, the Cordoned condition is renamed to CordonedNode. The overall resource schema structure and remaining status conditions remain unchanged.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: updating printcolumns for MachineConfigNode to align with MCO-1870 changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The PR description clearly relates to the changeset, explaining the replacement of UpdatedFilesAndOS with AppliedOSImage and AppliedFiles printcolumns across multiple CRD manifest files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1870 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

User description

This updates the printcolumns for MachineConfigNodes to align with the changes made for MCO-1870:

• Addition of AppliedOSImage and AppliedFiles conditions
• Removal of UpdatedFilesAndOS condition

---

PR Type

Enhancement

---

Description

• Replace UpdatedFilesAndOS printcolumn with AppliedOSImage and AppliedFiles

• Update condition type references from AppliedFilesAndOS to separate conditions

• Synchronize changes across all CRD manifest files and feature-gated variants

---

Diagram Walkthrough

flowchart LR
 A["UpdatedFilesAndOS<br/>printcolumn"] -->|"Replace with"| B["AppliedOSImage<br/>printcolumn"]
 A -->|"Replace with"| C["AppliedFiles<br/>printcolumn"]
 D["AppliedFilesAndOS<br/>condition type"] -->|"Split into"| E["AppliedOSImage<br/>condition"]
 D -->|"Split into"| F["AppliedFiles<br/>condition"]

Loading

File Walkthrough

	Relevant files
Enhancement	1 files types_machineconfignode.go Update kubebuilder printcolumn annotations for conditions +2/-1
Configuration changes	25 files 0000_80_machine-config_01_machineconfignodes-Hypershift-CustomNoUpgrade.crd.yaml Update printcolumns in Hypershift CustomNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-Default.crd.yaml Update printcolumns in Hypershift Default CRD manifest      +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-DevPreviewNoUpgrade.crd.yaml Update printcolumns in Hypershift DevPreviewNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-OKD.crd.yaml Update printcolumns in Hypershift OKD CRD manifest              +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-TechPreviewNoUpgrade.crd.yaml Update printcolumns in Hypershift TechPreviewNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-CustomNoUpgrade.crd.yaml Update printcolumns in SelfManagedHA CustomNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-Default.crd.yaml Update printcolumns in SelfManagedHA Default CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml Update printcolumns in SelfManagedHA DevPreviewNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-OKD.crd.yaml Update printcolumns in SelfManagedHA OKD CRD manifest        +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml Update printcolumns in SelfManagedHA TechPreviewNoUpgrade CRD manifest +6/-2      zz_generated.featuregated-crd-manifests.yaml Update printcolumns in featuregated CRD manifests aggregation +6/-2      ImageModeStatusReporting.yaml Update printcolumns in ImageModeStatusReporting feature gate +6/-2      IrreconcilableMachineConfig.yaml Update printcolumns in IrreconcilableMachineConfig feature gate +6/-2      MachineConfigNodes.yaml Update printcolumns in MachineConfigNodes feature gate      +6/-2      NoRegistryClusterInstall.yaml Update printcolumns in NoRegistryClusterInstall feature gate +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-CustomNoUpgrade.crd.yaml Update printcolumns in payload Hypershift CustomNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-Default.crd.yaml Update printcolumns in payload Hypershift Default manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-DevPreviewNoUpgrade.crd.yaml Update printcolumns in payload Hypershift DevPreviewNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-OKD.crd.yaml Update printcolumns in payload Hypershift OKD manifest      +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-TechPreviewNoUpgrade.crd.yaml Update printcolumns in payload Hypershift TechPreviewNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-CustomNoUpgrade.crd.yaml Update printcolumns in payload SelfManagedHA CustomNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-Default.crd.yaml Update printcolumns in payload SelfManagedHA Default manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml Update printcolumns in payload SelfManagedHA DevPreviewNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-OKD.crd.yaml Update printcolumns in payload SelfManagedHA OKD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml Update printcolumns in payload SelfManagedHA TechPreviewNoUpgrade manifest +6/-2

---

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1870 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

User description

This updates the printcolumns for MachineConfigNodes to align with the changes made for MCO-1870:

• Addition of AppliedOSImage and AppliedFiles conditions
• Removal of UpdatedFilesAndOS condition

---

PR Type

Enhancement

---

Description

• Replace UpdatedFilesAndOS printcolumn with AppliedOSImage and AppliedFiles

• Update condition type references from AppliedFilesAndOS to separate conditions

• Synchronize changes across all CRD manifest files and feature-gated variants

---

Diagram Walkthrough

flowchart LR
 A["UpdatedFilesAndOS<br/>printcolumn"] -->|"Replace with"| B["AppliedOSImage<br/>printcolumn"]
 A -->|"Replace with"| C["AppliedFiles<br/>printcolumn"]
 D["AppliedFilesAndOS<br/>condition type"] -->|"Split into"| E["AppliedOSImage<br/>condition"]
 D -->|"Split into"| F["AppliedFiles<br/>condition"]

Loading

File Walkthrough

	Relevant files
Enhancement	1 files types_machineconfignode.go Update kubebuilder printcolumn annotations for conditions +2/-1
Configuration changes	25 files 0000_80_machine-config_01_machineconfignodes-Hypershift-CustomNoUpgrade.crd.yaml Update printcolumns in Hypershift CustomNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-Default.crd.yaml Update printcolumns in Hypershift Default CRD manifest      +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-DevPreviewNoUpgrade.crd.yaml Update printcolumns in Hypershift DevPreviewNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-OKD.crd.yaml Update printcolumns in Hypershift OKD CRD manifest              +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-TechPreviewNoUpgrade.crd.yaml Update printcolumns in Hypershift TechPreviewNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-CustomNoUpgrade.crd.yaml Update printcolumns in SelfManagedHA CustomNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-Default.crd.yaml Update printcolumns in SelfManagedHA Default CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml Update printcolumns in SelfManagedHA DevPreviewNoUpgrade CRD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-OKD.crd.yaml Update printcolumns in SelfManagedHA OKD CRD manifest        +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml Update printcolumns in SelfManagedHA TechPreviewNoUpgrade CRD manifest +6/-2      zz_generated.featuregated-crd-manifests.yaml Update printcolumns in featuregated CRD manifests aggregation +6/-2      ImageModeStatusReporting.yaml Update printcolumns in ImageModeStatusReporting feature gate +6/-2      IrreconcilableMachineConfig.yaml Update printcolumns in IrreconcilableMachineConfig feature gate +6/-2      MachineConfigNodes.yaml Update printcolumns in MachineConfigNodes feature gate      +6/-2      NoRegistryClusterInstall.yaml Update printcolumns in NoRegistryClusterInstall feature gate +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-CustomNoUpgrade.crd.yaml Update printcolumns in payload Hypershift CustomNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-Default.crd.yaml Update printcolumns in payload Hypershift Default manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-DevPreviewNoUpgrade.crd.yaml Update printcolumns in payload Hypershift DevPreviewNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-OKD.crd.yaml Update printcolumns in payload Hypershift OKD manifest      +6/-2      0000_80_machine-config_01_machineconfignodes-Hypershift-TechPreviewNoUpgrade.crd.yaml Update printcolumns in payload Hypershift TechPreviewNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-CustomNoUpgrade.crd.yaml Update printcolumns in payload SelfManagedHA CustomNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-Default.crd.yaml Update printcolumns in payload SelfManagedHA Default manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml Update printcolumns in payload SelfManagedHA DevPreviewNoUpgrade manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-OKD.crd.yaml Update printcolumns in payload SelfManagedHA OKD manifest +6/-2      0000_80_machine-config_01_machineconfignodes-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml Update printcolumns in payload SelfManagedHA TechPreviewNoUpgrade manifest +6/-2

---

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Improve visibility of new columns Change the priority of the new AppliedOSImage and AppliedFiles print columns from 1 to 0 to make them visible in the default kubectl output, enhancing observability. machineconfiguration/v1/types_machineconfignode.go [26-27] -// +kubebuilder:printcolumn:name="AppliedOSImage",type="string",JSONPath=.status.conditions[?(@.type=="AppliedOSImage")].status,priority=1 -// +kubebuilder:printcolumn:name="AppliedFiles",type="string",JSONPath=.status.conditions[?(@.type=="AppliedFiles")].status,priority=1 +// +kubebuilder:printcolumn:name="AppliedOSImage",type="string",JSONPath=.status.conditions[?(@.type=="AppliedOSImage")].status,priority=0 +// +kubebuilder:printcolumn:name="AppliedFiles",type="string",JSONPath=.status.conditions[?(@.type=="AppliedFiles")].status,priority=0 Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion correctly points out that the new columns have priority=1 and proposes changing it to priority=0 for better default visibility. While this is a valid usability improvement, the original UpdatedFilesAndOS column also had priority=1, so the PR is consistent with the previous behavior. The suggestion is a subjective improvement rather than a correction.	Low
More

[openshift-ci]

@isabella-janssen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/minor-e2e-upgrade-minor	0cb6a49	link	true	/test minor-e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[everettraven]

I looked back at the .status.conditions field and it is mentioned that the AppliedOSImage and AppliedFiles conditions are only available when the ImageModeStatusReporting feature gate is enabled.

I took a look and it looks like that feature gate isn't enabled by default:

api/features/features.go

Lines 277 to 283 in c16ec2b

	FeatureGateImageModeStatusReporting = newFeatureGate("ImageModeStatusReporting").
	reportProblemsToJiraComponent("MachineConfigOperator").
	contactPerson("ijanssen").
	productScope(ocpSpecific).
	enhancementPR("https://github.com/openshift/enhancements/pull/1809").
	enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
	mustRegister()

Are these status conditions no longer blocked by enablement of the feature gate?