Don't include agent GUI log bundle in screenshot archive#1899
Open
zaneb wants to merge 1 commit into
Open
Conversation
If we get past a certain point in installation (presumably the start of bootstrapping), the log bundle downloaded from assisted-service contains secrets that set off the secret detector in CI. (In practice all of these secrets seem to relate to the cluster under test, which has been deleted by the time the CI artifacts are published.) Including this in the screenshots archive (which is the artifact collected by the CI step) means that the entire screenshot archive is redacted. Continue to download the log bundle for local debugging, but don't include it in the screenshot archive.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we get past a certain point in installation (presumably the start of bootstrapping), the log bundle downloaded from assisted-service contains secrets that set off the secret detector in CI. (In practice all of these secrets seem to relate to the cluster under test, which has been deleted by the time the CI artifacts are published.) Including this in the screenshots archive (which is the artifact collected by the CI step) means that the entire screenshot archive is redacted.
Continue to download the log bundle for local debugging, but don't include it in the screenshot archive.