shellcheck fixes part 1#1898
Conversation
| # overwrite an existing installation of the golang version, though, | ||
| # so check if we have a yq before installing. | ||
| if ! which yq 2>&1 >/dev/null; then | ||
| if ! which yq >/dev/null 2>&1; then |
There was a problem hiding this comment.
nit: if you do
| if ! which yq >/dev/null 2>&1; then | |
| if ! which yq &>/dev/null; then |
then nobody ever has to think about whether this is the right order or not (it is now) again.
There was a problem hiding this comment.
First form is more visible and and is everywhere in the repo, let's leave it like this.
| AVAIL=$(df -h --output=avail -B 1G "$WORKING_DIR" | tail -n 1) | ||
|
|
||
| if (( $AVAIL < $MIN_SPACE_REQUIRED )); then | ||
| if (( "$AVAIL" < "$MIN_SPACE_REQUIRED" )); then |
There was a problem hiding this comment.
| if (( "$AVAIL" < "$MIN_SPACE_REQUIRED" )); then | |
| if (( AVAIL < MIN_SPACE_REQUIRED )); then |
| sed -i -e "s%${IMAGE}%${IMAGE_MIRRORED}%g" "$ASSET_NEW" | ||
| done | ||
| done | ||
| done < <(find "${ASSETS_EXTRA_FOLDER}" \( -name \*.yml -or -name \*.yaml \) -print0) |
There was a problem hiding this comment.
What do you mean here?
| role="$3" | ||
|
|
||
| for ((idx=$start_idx;idx<$(($1 + $start_idx));idx++)); do | ||
| for ((idx=start_idx;idx<$((num_hosts + start_idx));idx++)); do |
There was a problem hiding this comment.
| for ((idx=start_idx;idx<$((num_hosts + start_idx));idx++)); do | |
| for ((idx=start_idx; idx < num_hosts + start_idx; idx++)); do |
| EOF | ||
| for ((idx=0;idx<$(($NUM_MASTERS));idx++)); do | ||
| hostname="$(printf $MASTER_HOSTNAME_FORMAT ${idx})" | ||
| for ((idx=0;idx<$((NUM_MASTERS));idx++)); do |
There was a problem hiding this comment.
| for ((idx=0;idx<$((NUM_MASTERS));idx++)); do | |
| for ((idx=0; idx < NUM_MASTERS; idx++)); do |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
2 participants
No description provided.