Add extra worker to cluster after dev-scripts install is complete#1807
Add extra worker to cluster after dev-scripts install is complete#1807MahnoorAsghar wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Assisted by: Claude
MahnoorAsghar
force-pushed
the
add-vm-bmc-post-install
branch
from
4a379ed to
de2a91f
Compare
There was a problem hiding this comment.
You should not commit this file
| name: ${CLUSTER_NAME}-${WORKER_NAME} | ||
| namespace: openshift-machine-api | ||
| labels: | ||
| infraenvs.agent-install.openshift.io: ${CLUSTER_NAME} |
There was a problem hiding this comment.
This should not be here: it requires assisted components
| address: ${BMC_FULL_ADDRESS} | ||
| credentialsName: ${CLUSTER_NAME}-${WORKER_NAME}-bmc-secret | ||
| disableCertificateVerification: true | ||
| automatedCleaningMode: disabled |
| BMH_NAME="${CLUSTER_NAME}-${WORKER_NAME}" | ||
| if oc get baremetalhost -n openshift-machine-api "$BMH_NAME" &>/dev/null; then | ||
| echo "Deleting BareMetalHost ${BMH_NAME}..." | ||
| oc delete baremetalhost -n openshift-machine-api "$BMH_NAME" || true |
There was a problem hiding this comment.
I wonder why errors are ignored in all these calls
| MACHINES=$(oc get machine -n openshift-machine-api -o name | grep -i "$WORKER_NAME" || true) | ||
| if [ -n "$MACHINES" ]; then | ||
| echo "Found machines: $MACHINES" | ||
| echo "$MACHINES" | xargs -r oc delete -n openshift-machine-api || true |
There was a problem hiding this comment.
Are you sure it's the right process? I think you need to scale down MachineSet, otherwise it will create another machine
2 participants
Assisted by: Claude