[WIP] Convert 01_install_requirements to ansible#1789
[WIP] Convert 01_install_requirements to ansible#1789elfosardo wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
Do not use this in production, yet! This patch converts the 01_install_requirements.sh file from pure bash to use a mix of few bash commands and extensive ansible playbooks. The initial conversion has been obtained using Cursor prompt using claude-4-sonnet model. Lots of manual changes have been applied to be able to get a successful outcome, and more testing is needed to verify the entire worflow work as intended.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@elfosardo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| - name: Template daemon.json to /etc/docker/daemon.json | ||
| template: | ||
| src: "{{ DAEMON_JSON_PATH }}/daemon.json" |
There was a problem hiding this comment.
This one looks weird.
Instead of a template, this lives under files, but we pass the path to it as an environment variable.
zaneb
left a comment
zaneb
left a comment
There was a problem hiding this comment.
Is it me or is there waaay more Ansible here than what was happening in just 01_install_requirements?
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Do not use this in production, yet!
This patch converts the 01_install_requirements.sh file from pure bash to use a mix of few bash commands and extensive ansible playbooks.
The initial conversion has been obtained using Cursor prompt using claude-4-sonnet model.
Lots of manual changes have been applied to be able to get a successful outcome, and more testing is needed to verify the entire worflow work as intended.