Fix duplicate data-index values in property editor add/save handlers - #13
Merged
Conversation
Co-authored-by: matteius <479892+matteius@users.noreply.github.com>
Co-authored-by: matteius <479892+matteius@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Fix duplicate data-index values in property editor add/save handlers
Aug 3, 2026
Contributor
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: matteius <479892+matteius@users.noreply.github.com>
Contributor
Author
Resolved. Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Add Condition/Validation/Dependency" click handlers captured the array
.lengthat listener-registration time as the new row'sdata-index. After any add or delete, subsequent clicks produced duplicate indices, causing save-time lookups to read the wrong row's data.Changes
Click handlers — compute the next index at click time by counting current
.cardelements in the container instead of closing over the stale array length:Save-time loops — replace the
forEachenumeration index withel.dataset.indexso lookups match the actualdata-indexattribute on each row, regardless of insertion/deletion history:Affects all three tabs: Conditional Logic, Validation Rules, and Dependencies.