Add relevance search function support for unified SQL query#5279
Draft
dai-chen wants to merge 1 commit intoopensearch-project:mainfrom
Draft
Add relevance search function support for unified SQL query#5279dai-chen wants to merge 1 commit intoopensearch-project:mainfrom
dai-chen wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Contributor
|
Failed to generate code suggestions for PR |
Add lightweight SQL operators and a convertlet table that enables relevance search functions (match, match_phrase, match_bool_prefix, match_phrase_prefix, multi_match, simple_query_string, query_string) in the unified query SQL planning path. The SQL path uses MAP literal syntax for parameters: SELECT * FROM t WHERE match(MAP['field', name], MAP['query', 'text']) Implementation: - SqlExtensionFunctions: lightweight operators for SQL parsing and validation, chained with SqlStdOperatorTable via FrameworkConfig - RelevanceSearchConvertletTable: swaps lightweight operators with PPL operators (PPLBuiltinOperators) during SqlToRelConverter, bypassing the PPL type checker entirely - UnifiedQueryContext: wires operator table and convertlet table The convertlet approach avoids touching core/ module. The PPL path continues to resolve functions via PPLFuncImpTable independently. Natural syntax with named parameters (field => name, query => 'text') is blocked by CALCITE-6245: checkRollUp incorrectly resolves parameter name identifiers as column references for scalar functions in WHERE. Signed-off-by: Chen Dai <daichen@amazon.com>
8e54956 to
5f80dfc
Compare
Contributor
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable 7 PPL relevance search functions (match, matchphrase, matchboolprefix, matchphraseprefix, simplequerystring, querystring, multi_match) in the Calcite SQL planning path.
which correctly handle variable-arity.
Relevance Search Function Support Matrix
Note: SQL V2 supports additional aliases (matchquery, matchphrase, multimatch, wildcardquery, matchphrasequery, multimatchquery) that are not listed separately. The Calcite SQL path uses MAP literal syntax for parameters (MAP['field', col], MAP['query', 'text']), while SQL V2 uses native syntax (match(field,
'text')).
Related Issues
Part of #5248
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.