Skip to content

Extend the set of valid characters allowed in JacksonEvent keys#6425

Open
Subrahmanyam-Gollapalli wants to merge 3 commits intoopensearch-project:mainfrom
Subrahmanyam-Gollapalli:jackson-event-key-additional-chars
Open

Extend the set of valid characters allowed in JacksonEvent keys#6425
Subrahmanyam-Gollapalli wants to merge 3 commits intoopensearch-project:mainfrom
Subrahmanyam-Gollapalli:jackson-event-key-additional-chars

Conversation

@Subrahmanyam-Gollapalli
Copy link
Copy Markdown
Contributor

Description

Extend the valid character set for JacksonEventKey and JacksonEvent keys
to include parentheses, percent and colon characters.
Updated validation logic and test cases in both JacksonEventKeyTest and
JacksonEventTest.

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Subrahmanyam-Gollapalli <subrahmanyam.gollapalli@freshworks.com>
@dlvenable
Copy link
Copy Markdown
Member

I see these test failures:

CsvProcessorTest > test_when_ColumnNames_with_invalid_keys_parsedCorrectly() FAILED
    java.lang.AssertionError: 
    Expected: <true>
         but: was <false>

CsvProcessorTest > test_when_multLine_invalid_keys_then_parsedCorrectly() FAILED
    java.lang.AssertionError: 
    Expected: <true>
         but: was <false>

Maybe this test was relying on some invalid characters.

Signed-off-by: Subrahmanyam-Gollapalli <subrahmanyam.gollapalli@freshworks.com>
@dlvenable
Copy link
Copy Markdown
Member

@Subrahmanyam-Gollapalli , It looks like some other tests are failing:

KeyValueProcessorTests > testInvalidKeyCharsReplacement() FAILED
    java.lang.AssertionError: 
    Expected: is <true>
         but: was <false>

You may benefit from running the following command locally to get faster feedback.

./gradlew --parallel build

Signed-off-by: Subrahmanyam-Gollapalli <subrahmanyam.gollapalli@freshworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants