Skip to content

fix(rpcs): redact sensitive URLs and handle non-HTTP endpoints#267

Open
josealoha666 wants to merge 3 commits intoopenscan-explorer:release/v1.2.2-afrom
josealoha666:fix/pr264-review-items
Open

fix(rpcs): redact sensitive URLs and handle non-HTTP endpoints#267
josealoha666 wants to merge 3 commits intoopenscan-explorer:release/v1.2.2-afrom
josealoha666:fix/pr264-review-items

Conversation

@josealoha666
Copy link

@josealoha666 josealoha666 commented Feb 28, 2026

Description

This PR addresses follow-up review items from #264 focused on the new RPC testing experience and E2E reliability.

Related Issue

Follow-up to: #264

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Performance improvement
  • Other (please describe):

Changes Made

  • Redacted sensitive data in RPC URLs shown in UI:
    • Masks credential-like query parameters (e.g. api_key, token, secret, etc.)
    • Masks token-like path segments
    • Copy action now copies the redacted URL
  • Fixed latency display semantics:
    • Offline/timeout/untested no longer show 0ms
    • They now show N/A
  • Improved protocol handling in RPC tests:
    • Non-HTTP(S) endpoints (e.g. ws://, wss://) are marked as untested instead of being falsely marked offline
  • Fixed RPC page copy consistency:
    • Updated EN/ES description text to match current behavior (re-test + copy flow)
  • Fixed effect dependency stability on RPC page:
    • Removed dependency suppression and updated useEffect dependencies to avoid stale endpoint runs
  • Split EVM E2E workflow into two parallel shards to reduce timeout risk:
    • shard-a: arbitrum/base/optimism
    • shard-b: bsc/polygon

Screenshots (if applicable)

N/A (logic/workflow focused changes).

Checklist

  • I have run npm run format:fix and npm run lint:fix
  • I have run npm run typecheck with no errors
  • I have run tests with npm run test:run
  • I have tested my changes locally
  • I have updated documentation if needed
  • My code follows the project's architecture patterns

Additional Notes

  • Local validation executed:
    • npm run lint
    • npm run typecheck
  • PR includes commits:
    • fix(rpcs): redact sensitive URLs and improve endpoint test handling
    • fix(rpcs): align copy text and stabilize auto-test effect deps
    • ci(e2e): split evm network tests into two parallel shards

@github-actions
Copy link

github-actions bot commented Feb 28, 2026

🚀 Preview: https://pr-267--openscan.netlify.app
📝 Commit: d09ba488e189efbf54d63a975dac9926fdca552f

{
"pageTitle": "Endpoints RPC",
"description": "Probá y compará el rendimiento de los endpoints RPC en distintas redes. Agregá endpoints rápidos a tu configuración con un click.",
"description": "Probá y compará el rendimiento de los endpoints RPC en distintas redes. Re-probá proveedores y copiá URLs para tu configuración.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josealoha666 This sounds better:

Compará el rendimiento de los endpoints RPC por red, volvé a probar proveedores y copiá las URLs para tu configuración.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants