Fix downloads link #172
Open
Fix downloads link #172
+51
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the home page of OpenSCAD, the download links are not available.
It is trying to use the
*_release_links.jswhich has been replaced byreleases.js. It also seems like the linux version uses the Mac links.This change makes the links work and unifies some of the logic between the home and downloads page. I also cleaned up some of the logic for determining the OS and made it grab the proper links based on OS.
I tested this on Mac Safari and I now get this:
I also made it say the arch that is related to that package. I made added
Intelto Mac because that is the version in the linked dmg, and it does not support linux 32 bit because that hasN/Ain thereleases.js.Someone might want to do a basic test on some other OSs to make sure I didn't miss anything. Just a simple go on the home page and see what link it gives.